Adding PR Builds

Learn Content
,
1

Since this is an open source project and we will have many a hands in it, I was thinking we ought to make a build system that tries to build PR code, simply for checking for compile errors and the like. It’s pretty easy to accidentally introduce compile errors, or for it to “work on my box” but mess up during a merge.

Using Jenkins or the tool that Unity already provides :wink:

This way when someone opens a PR, their code must have a passing build as a requirement, like the CLA.

I know it’a possible with branches in the same repo, should be possible with forks too I believe.

This could help keep master/release healthy. Thoughts? @cirocontinisio

2

Is this being done already when you see things like this in your PR? This might be a git native behaviour. If so, can probably dis-regard this thread.

6385074--711546--35499B9F-928C-488D-8CAA-78909CDAE978.jpeg
6385074--711546--35499B9F-928C-488D-8CAA-78909CDAE978.jpeg1125×2436 283 KB

3

that just looks like a merge issue between your branch and master (ie something new on master) , recommend rebasing your branch on master.

4

Yeah that’s correct, I can fix that soon. My question for branch builds still stands though! :smile:

5

Yes, many other projects use something like this especially ones using CD/CI. I think it would be a good idea if checks could be set up.

1 Like