Am I doing this right? I'm, trying to start an engine using a button. The button on the inspector ha

Unity Engine
1

Here’s the code:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class engineStart : MonoBehaviour
{

    public bool engineOn = false;

    public GameObject engLight;

    public GameObject engineActiveText;
    public GameObject startingText;
    public GameObject idleText;
    public GameObject canpressText;
    public GameObject pressTimeText;
    public GameObject startTimeText;

    public AudioSource start;
    public AudioSource idle;

    public bool canPress = true;
    public bool cranking = false;
    public bool idling = false;
    public bool EngineTimer = false;

    public float startupTime = 100;
    public float pressTime = 10;

    // Start is called before the first frame update
    void Start()
    {

    }

    // Update is called once per frame
    void Update()
    {

        engineActiveText.GetComponent<Text>().text = "Engine Active:  " + engineOn;
        startingText.GetComponent<Text>().text = "Crankiing:  " + cranking;
        idleText.GetComponent<Text>().text = "Idling:  " + idling;
        canpressText.GetComponent<Text>().text = "CanPress:  " + canPress;
        pressTimeText.GetComponent<Text>().text = "Press Time:  " + pressTime;
        startTimeText.GetComponent<Text>().text = "Crank Time:  " + startupTime;
       
        //So the EngineSwitch void sets engineOn to true/false.

        if (engineOn == false)
        {
            engLight.SetActive(false);
            start.Stop();
            idle.Stop();
           

        }
        else if (engineOn == true)
        {
            startupTime -= 1;
            engLight.SetActive(true);


        }

/*        if (canPress == false)
        {
            pressTime -= 1;
        }
        if (pressTime < 0)
        {
            pressTime = 10;
            canPress = true;
        }*/
       
        //StartupTime is essentially controls the transition from the engine cranking to the engine being active

        if (startupTime < 0)
        {
            startupTime = 100;
            cranking = false;
            idling = true;
            EngineTimer = false;

        }

        if (cranking == true)
        {
            start.Play();
            cranking = false;
        }


        if (idling == true)
        {
            idle.Play();
            idling = false;
        }
           


    }

/*    private void OnTriggerExit(Collider other)
    {
        if (other.tag == "engStart" && canPress == true)
        {
            canPress = false;
            EngineActive();
           
        }
    }*/

    public void EngineSwitch(bool engineActive = false)
    {

        // start engine if not already active

        if (engineActive == false)
        {
            engineActive = true;
            engineOn = true;
            cranking = true;
            EngineTimer = true;
           
        }
        //stop engine if active
        else if (engineActive == true)
        {
            engineActive = false;
            engineOn = false;
        }
    }

   
}

1207×105 12.3 KB

2

You’ll know it is right when it works. Otherwise, how to report your problem productively in the Unity3D forums:

http://plbm.com/?p=220

This is the bare minimum of information to report:

  • what you want
  • what you tried
  • what you expected to happen
  • what actually happened, especially any errors you see
  • links to documentation you used to cross-check your work (CRITICAL!!!)

You may edit your post above.

If you have no idea what is going on, fix that first. Here’s how:

What is often happening in these cases is one of the following:

  • the code you think is executing is not actually executing at all
  • the code is executing far EARLIER or LATER than you think
  • the code is executing far LESS OFTEN than you think
  • the code is executing far MORE OFTEN than you think
  • the code is executing on another GameObject than you think it is
  • you’re getting an error or warning and you haven’t noticed it in the console window

To help gain more insight into your problem, I recommend liberally sprinkling Debug.Log() statements through your code to display information in realtime.

Doing this should help you answer these types of questions:

  • is this code even running? which parts are running? how often does it run? what order does it run in?
  • what are the values of the variables involved? Are they initialized? Are the values reasonable?
  • are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

Knowing this information will help you reason about the behavior you are seeing.

You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as Debug.Log("Problem!",this);

If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

You could also just display various important quantities in UI Text elements to watch them change as you play the game.

If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: How To - Capturing Device Logs on iOS or this answer for Android: How To - Capturing Device Logs on Android

Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

Here’s an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

You must find a way to get the information you need in order to reason about what the problem is.

3

dont u need to implement a click event for the button, all you have set atm is the button text and some non relevant button non click functions.