c# Mecanum problem

Scripting C# & .NET
1

Hello, again unity community I come to you with a problem that has stalled our development for about a day and half. Our Player uncontrollably won’t stop cycling through he’s animation states over and over again in a endless loop. Even though the parameters for his transitions in mecanum haven’t been meant. Below I have posted a breakdown of the problem.

Breakdown from the editor:

The player’s animations are cycling like this uncontrollably:

Besides this the print statements in my code, Just won’t stop printing over and over again. When they should be printing only once per player input. Another symptom to the problem I guess.

My profiler also showed that my function (to set the animation’s parameter) is being called over and over again when there is no input from the player:

Code Breakdown:

From SwimmingTurtlePlayer to TurtleBack (TurtleBack is a Blend tree between to clips) we were using a float parameter for speed (note that the player is moving backwards on the x-axis in the negative direction);

Code:

    public Animator TurtlePlayer;
    public Rigidbody2D Turtle;
    public Vector2 velocity;
    public Vector2 backVelocity;
    public float BackVelocity;
    public float Velocity;

if (Input.GetKey (KeyCode.Mouse2)) {

       Turtle.MovePosition (Turtle.position - backVelocity *Time.fixedDeltaTime); 
             //move player's rigid body backwards.

       TurtlePlayer.SetFloat ("TurtleSpeed",BackVelocity);   
             //set float parameter for player's speed.

            Invoke("StartReverseTrans", 3); // invoke new function to give player time to move before starting the coroutine.
        }

Then from TurtleBack to TurtleBackToNormal we are using a bool parameter called TurtleSwimNow that is set equal to true.

Code:

void StartReverseTrans()
    {
        TurtlePlayer.SetBool("TurtleSwimNow",true); // set player's animation bool parameter.
        Turtle.velocity = Vector2.zero; // set player's speed to zero as a reset. Speed will change upon player's new input.
        print ("I'm A transitioning Turtle");
       
        StartCoroutine(TurtleSwimNow()); //start coroutine.
    }

Finally, from TurtleBackToNormal to SwimmingTurtlePlayer the bool parameter TurtleSwimNow is set to false.

Code:

IEnumerator TurtleSwimNow ()
    {
        TurtlePlayer.SetBool ("TurtleSwimNow", true);  // set player's animation bool parameter.
       
        yield return new WaitForSeconds (2f);
       
        TurtlePlayer.SetBool ("TurtleSwimNow", false); // set player's animation bool parameter. Player then returns to default animation in mecanum.
        print ("I'm Swimming Normally Now");
    }

Can someone help us, we will appreciate it.

2

Can you post more code. The first segment you posted doesnt appear valid.

3

I send you a message.

4

Anymore suggestions?

5

Yeah, don’t send private messages to individuals. Just because they respond once doesn’t make them obligated to keep helping until the problem is solved. Also, more than half of debugging is trial and error, with printing/Debug.Logs making up the rest. By keeping part of the problem-solving process out of the thread and in private messages, you’re killing some of the “trial and error” benefits- in other words we don’t know what someone else may have already told you to try, so we’re likely to tell you to try some of the same things and waste time.

if (Input.GetKey (KeyCode.Mouse2)) {

needs to be:

if(Input.GetKeyDown(KeyCode.Mouse2)) {

It’s checking it every single frame for “if mouse button is held down”, which means it’s triggering your invoke method several dozen times per second, which is then starting several dozen coroutines a second. If you want movement to be possible on GeyKey and animation triggering to occur on GeyKeyDown and GetKeyUp, those need to be separate conditionals.

6

Noted, I’m very sorry about that, I do apologize.

Well, I tested it and the player’s backwards animation doesn’t even play. However I do see the print statements from the method that gets invoked and the print statement from the coroutine.

7

If you look at the parameter list while in Play mode, you can see what the values are at any given moment (just remember to select your character in the scene view, rather than leaving it on the prefab or w/e, or else it won’t show the “instance” version in the Animator screen).

With Debug.Logs that aren’t jamming up on the console 10,000 times a second and combined with the parameter values being shown, you should be able to narrow down where things are messing up.

8

While, I went through and added a Debug.Log statement for each line and I got all of them back:

if (Input.GetKeyDown(KeyCode.Mouse2))
        {
            Turtle.MovePosition(Turtle.position - backVelocity * Time.unscaledDeltaTime);
            Debug.Log("player is moving backwards");
            TurtlePlayer.SetFloat ("TurtleSpeed",BackVelocity);
            Debug.Log("player's animation is set");
        }

        else if (Input.GetKeyUp(KeyCode.Mouse2) && !invokeReset)
        {
            Invoke("StartReverseTrans", 3);
            Debug.Log("player's aniamtion method is invoked");
            invokeReset = true;
            Debug.Log("player's invoke reset is true");
        }

void StartReverseTrans()
    {
        TurtlePlayer.SetBool("TurtleSwimNow",true);
        Debug.Log("player's animation bool is set");
        Turtle.velocity = Vector2.zero;
        Debug.Log ("player's velocity is reset");
        invokeReset = false;
        print ("I'm A transitioning Turtle");
       
        StartCoroutine(TurtleSwimNow());
    }

IEnumerator TurtleSwimNow ()
    {
        TurtlePlayer.SetBool ("TurtleSwimNow", true);
        Debug.Log ("player's animation bool is true, start to transition");
       
        yield return new WaitForSeconds (2f);
       
        TurtlePlayer.SetBool ("TurtleSwimNow", false);
        print ("I'm Swimming Normally Now");
    }

However the player doesn’t move backwards anymore so the parameter for his speed isn’t being triggered. But the parameter for bool is.

Should I change the line of code that moves the player? why isn’t the player movement working now when it was before with get key vs get key down? I thank you for helping me solve this problem.

9

Oh, that. Sorry, I was more worried about the infinite Invoke than anything.

GetKeyDown is only allowing the inside of the conditional to run for a single frame- when the button is first pressed- it won’t return true again until you release and press the button again. You should move the “MovePosition” to within a separate GetKey conditional (which will activate every frame the button is held), or alternatively you could create a “moving direction” Vector2 value that serves to activate a separate conditional in FixedUpdate when it’s “not Vector2.zero”, and… well, like this:

if(moveDirection != Vector2.zero)
{
    Turtle.MovePosition(Turtle.position - (moveDirection * Time.unscaledDeltaTime));
}

You’ll just have to pre-multiply moveDirection with your forward/backward velocity when the button is pressed, and then it’ll keep going until the button is released, at which point you’ll set moveDirection to Vector2.zero again.

Hope that helps!

10

Well, I got him to move backwards again, by adding another conditional for GetKey and placing the player movement code there.

if (Input.GetKey(KeyCode.Mouse2))
        {
            Turtle.MovePosition(Turtle.position - backVelocity * Time.unscaledDeltaTime);
            Debug.Log("player is moving backwards");
           
            TurtlePlayer.SetFloat ("TurtleSpeed",BackVelocity);
            Debug.Log("player's speed animation is set");
        }

        else if (Input.GetKeyUp(KeyCode.Mouse2) && !invokeReset)
        {
            Invoke("StartReverseTrans", 3);
            Debug.Log("player's aniamtion method is invoked");
            invokeReset = true;
            Debug.Log("player's invoke reset is true");
        }

However the speed parameter still isn’t working. I found some strange behavior in my blend tree (“TurtleBack”), My speed parameter was set to transition SwimmingTurtlePlayer to Turtleback if speed is less than -0.01. When I look at the slider in my blend tree before I start play mode it is normal, but when I start play mode and press the middle mouse key, the slider jumps to 30. Thus keeping my animations from playing and transitioning properly.

11 
TurtlePlayer.SetFloat("TurtleSpeed",BackVelocity);

This says you’re setting it to whatever value “BackVelocity” is in the inspector, which I now assume is 30. There’s nothing in any of the scripts you’ve shown that has you setting BackVelocity or TurtleSpeed to anything other than this, so either this is the problem, or it’s in some script you haven’t posted- either way there’s absolutely no way for me to figure it out from here.

Need to go get some sleep so I won’t be able to help you further, I hope you get it all figured out!

12

You were right I set to 30 in the inspector, at least now it’s set back to normal. Well I hope that you get a good sleep :).

Anyways, I got the infinite loop between animations again just like before. As a test I cut out the invoke to see if that is what was causing the loop. So when I did cut it from the code it stills loops. could is possibly be the coroutine?

new code:

if (Input.GetKey(KeyCode.Mouse2))
        {
            Turtle.MovePosition(Turtle.position - backVelocity * Time.unscaledDeltaTime);
            //Debug.Log("player is moving backwards");

            TurtlePlayer.SetFloat ("TurtleSpeed",BackVelocity);
            //Debug.Log("player's speed animation is set");
        }

        else if (Input.GetKeyUp(KeyCode.Mouse2))
        {
            TurtlePlayer.SetBool("TurtleSwimNow",true);
            //print ("I'm A transitioning Turtle");
           
            StartCoroutine(TurtleSwimNow());
        }

IEnumerator TurtleSwimNow ()
    {
        TurtlePlayer.SetBool ("TurtleSwimNow", true);
        //Debug.Log ("player's animation bool is true, start to transition");
       
        yield return new WaitForSeconds (2f);

        TurtlePlayer.SetBool ("TurtleSwimNow", false);
        //print ("I'm Swimming Normally Now");
    }
13

Hello, again I just run another test to diagnose this problem. I put another Debug.Log at the beginning of the if statement with the Player’s movement code. When tested the console printed that statement 46 times even I only pressed the middle mouse button once. Also note that the other print statements printed only once, including the ones in the coroutine.

if (Input.GetKey(KeyCode.Mouse2))
        {
            Debug.Log ("Start moving Turtle Backwards");

            Turtle.MovePosition(Turtle.position - backVelocity * Time.unscaledDeltaTime);
            //Debug.Log("player is moving backwards");

            TurtlePlayer.SetFloat("TurtleSpeed",BackVelocity);
            //Debug.Log("player's speed animation is set");
        }

        else if (Input.GetKeyUp(KeyCode.Mouse2))
        {
            TurtlePlayer.SetBool("TurtleSwimNow",true);
            //print ("I'm A transitioning Turtle");
           
            StartCoroutine(TurtleSwimNow());
        }
14

That sounds like it’s doing what it’s supposed to be doing- GetKey fires every frame that the button is held. How exactly are the parameter transition requirements set in the Animator window? Click on the arrow between TurtleBack and TurtleBackToNormal for me and screenshot it, please.

15

Ok, this first transition is our speed parameter from “swimming turtle player” to “turtle back”:

This is from “turtle swim back” to “turtle back to normal”, we used a bool here thats set to true:

Finally, this transition is from “turtle back to normal” to “Swimming turtle player”. The bool parameter is now set to false:

16

I think the problem is you need to uncheck has exit time. Im no mecanim expert though. I never got to look at your code, but it seems like youve had plenty of help here.

tbh, you dont need to worry about posting full code. There wasnt anything special about it, and often you get people that will give you tips on how to improve it. ie, I would cache your co-routine enumerators.

17

Thanks, I’m just wondering what you meant by “cache your co-routine enumerators” ?

But, I did turn off the exit time and I still got the same result.

18

obviously not that then :wink: I do hate the animations. Ill have a look at some of the stuff ive done later and see if i can spot something.

as for co-routine and caching…

19

Thanks, it’s has been done. I formerly had no knowledge of caching cor-routines so this was very helpful for me.

20

Houston we are still having problems. The animation is still acting weird