Calling CharacterController's SimpleMove crashing Unity

[VentaGames]

Hello, just working on my game. So, I found that calling _characterController.SimpleMove(Vector3.zero);

• Unity freezes and becomes unresponsive. The only way to restart it is just to kill the process.
  Tried on Unity 2021.3.x and 2022.1. Both are Silicon edition.

Thanks.

[PraetorBlue]

Are you sure it’s just that? What’s the whole script look like?

[Kurt-Dekker]

@VentaGames

_characterController.SimpleMove(Vector3.zero);

Are you saying that the line above, done alone in Update() with NOTHING else in the scene crashes it?

[VentaGames]

Ok, the script is pretty big, but here is the code for this:
The functions is:

public void SetPlayerPosition(Vector3 position)
    {
        //FixMe: Crash!
        //_controller.SimpleMove(Vector3.zero);
      
        transform.position = position;
    }

Called from the same script:

 private void OnTriggerEnter(Collider other)
    {
        if (other.gameObject.CompareTag("Teleport"))
        {
           
            SetPlayerPosition(_teleportPosition);
        }
    }

The Update function is:

private void Update()
    {
        if (_isMovementStopped)
        {
            return;
        }
      
        //Debug
        if (_controlType == GameSettingsScript.ControlType.TwoFingerGestures)
        {
            _gamePlayUIScript.EnableLeftControl(_primaryTouchIsActive);
            _gamePlayUIScript.EnableRightControl(_secondaryTouchIsActive);
        }
      
        var playerSpeed = _playerSpeed + (_playerSpeedPowerupRate * (_isPowerUpSpeed ? 1f : 0f));

        var turnSpeed = _playerTurnSpeed;

        Vector2 movementDirection = _movementDirection;

        if (_controlType == GameSettingsScript.ControlType.TwoFingerGestures)
        {
            turnSpeed = _playerLookSpeed;
        }
      
        var sensitivityScale = ControllerSensitivityScale;
      
        float sen = sensitivityScale * (_controllerSensitivity);

        if (_isGrounded)
        {
            var maxSpeed = Math.Max(Math.Abs(movementDirection.y), Math.Abs(_steering.x));
            _playerAnimator.SetFloat(MoveSpeed, maxSpeed);
        }
      
        var moveDirection = transform.forward * (movementDirection.y * playerSpeed * Time.smoothDeltaTime);

        gameObject.transform.Rotate(0, movementDirection.x * (turnSpeed * sen) * Time.smoothDeltaTime, 0);

        if (_controller)
        {
            _controller.Move(moveDirection + new Vector3(0f, _verticalVelocity, 0f) * Time.smoothDeltaTime);
        }

        if (_controller.isGrounded && _controller.velocity.magnitude > 2.0f)
        {
            AudioManager.Instance.PlayFootSteps();
        }
    }

The idea of calling SimpleMove is just to stop the player while “teleporting” to some position.
The code is far from the production level, as some R&Ds in progress.

Thanks.

[Kurt-Dekker]

Your problem is far more likely because you’re calling the move from within OnTriggerEnter.

Also, you’re mixing and matching physics / collision stuff (OnTriggerEnter, which implies Rigidbody, which IS Physics) with CharacterController.

Pick one. They don’t play well together and were never meant to play well together.

If you pick physics, then you must NEVER manipulate the transform directly because you bypass physics.

With Physics (or Physics2D), never manipulate the Transform directly. If you manipulate the Transform directly, you are bypassing the physics system and you can reasonably expect glitching and missed collisions and other physics mayhem.

Always use the .MovePosition() and .MoveRotation() methods on the Rigidbody (or Rigidbody2D) instance in order to move or rotate things. Doing this keeps the physics system informed about what is going on.

Collisions in high speed without unity physic / rigidbody

You say you're not using 2D physics but you're using queries therefore obviously colliders. This IS using 2D physics therefore you need to use it correctly so here are some basic rules: Don't ever modify the Transform if using 2D physics components If you want a 2D Collider to move then add a Rigidbody2D and use its API to move it; many ways to do this. Rigidbody2D don't make it "unresponsive". If you want explicit control then set the body-type to Kinematic; it's what it's for. When you qu…

OnCollisionEnter2D not being called

That’s not related to body-type. You should never drive via the Transform. The main thing to understand here is that the Rigidbody2D role is to write to the Transform after the physics simulation, not the other way around. It acts as a proxy to the Transform because you want physics behaviour. Does “it work” if you write to the Transform and force the Rigidbody2D to read from the Transform? Yes! It works like that because otherwise it’d be reported as a bug and so we’re forced to “support” it.…

With a wheel collider, use the motor or brake torque to effect motion.

If you just need a handy starter character controller, here is a super-basic starter prototype FPS based on Character Controller (BasicFPCC):

A Basic First Person Character Controller for prototyping

https://www.youtube.com/watch?v=t0oN-PFXZEM Gist Link After some interest in an old post here , I spent the weekend frankensteining snippets of code to make a single script FPCC that could be used like the FPCC from Unity 4~5, including the crouch and run from Aldo, and I also added farcry sliding. There is a Menu Item function to easily create and configure a new FPCC object. Otherwise very easy to set up, it only requires a layer to exclude itself from sphere/raycasts. There is a check to …

That one has run, walk, jump, slide, crouch… it’s crazy-nutty!!

[VentaGames]

Thanks a lot for this.
There are still things to learn.

Regards.