Can't get player to destroy

Unity Engine
1

I’m following the Brackey’s 2D platformer tutorial, (his forums won’t validate my email address so I can’t post there), but my script won’t delete my player object when he falls off the screen.

Here’s my player script. Line 15-18 is where it doesn’t seem to be doing calling DamagePlayer()

using UnityEngine;
using System.Collections;

public class Player : MonoBehaviour {

    [System.Serializable]
    public class PlayerStats {
        public int Health = 100;
    }

    public PlayerStats  playerStats = new PlayerStats();

    public int fallBoundary = -20;

    void update(){
        if (transform.position.y <= fallBoundary)
                        DamagePlayer (9999999);
    }

    public void DamagePlayer(int Damage) {
        playerStats.Health -= Damage;
        if (playerStats.Health <= 0) {
            GameMaster.KillPlayer(this);  
        }
    }  

}

Here’s the GameMaster Script that kills the player:

using UnityEngine;
using System.Collections;

public class GameMaster : MonoBehaviour {

    public static void KillPlayer (Player player) {
        Destroy (Player.gameObject);
    }

}

Using Unity 4.6.1

2

Put this in your player script and just tell it to destroy itself

3

Destroy(player.gameObject);

4

I put the lower case ‘p’ but it made no difference.

I’m pretty new to all of this, and this is my first attempt at scripting (I’m just typing what the video tells me, and learning what each line does) but where would I put that in on the script? within the update part? IT doesn’t like the word function anywhere, and when I put it within the update script, it doesn’t like the ‘}’ Oh man, I’m pretty lost if I cant even add a damn line of code

5

Functions can’t go inside other functions, so you can’t put OnBecameInvisible() inside Update(). You put OnBecameInvisible() outside of Update() as it’s a function just like Update(). The function will only run when the object its attached to goes outside the view of the camera. So put the function in your Player script outside of Update() with Destroy(gameObject); inside of it

6

I tried

    void OnBecameInvisible () {
        enabled = false;
        Destroy (GameObject);
    }

and tried

    void OnBecameInvisible () {
        //enabled = false;
        Destroy (Player.GameObject);
    }

and a few others, and it gives me errors:

“Expression denotes a ‘type’ , where a ‘variable’, or ‘value’ or ‘method group’ was expected.”

The best overload method match for UnityEngine.Object.Destroy(UnityEngine.Object)’ has some invalid arguments

and

Argument ‘#1’ cannot convert ‘object’ expression to type ‘UnityEngine.Object’

I’m a frustrated failure… are there any easier platforming tutorials that I could start with that anyone suggests? I can program, and made a few good games in C2 (I know, visual programming :stuck_out_tongue_winking_eye: ) but I can’t seem to really get all the tiny things that can make the code blow up.

7

you cant use a class as the parameter…

Player is a class
GameObject is a class

Player player;

player is the object (which you would destroy), of class Player

GameObject is the class
gameObject is the object

Pay attention to the casing used, as its important.

Destroy(gameObject) will work.
Destroy(player.gameObject) should also work.

The following will never work as they are referencing classes rather than the objects themselves.
Destroy(GameObject)
Destory(Player.GameObject)
Destrory(Player.gameObject)
Destroy(player.GameObject)

8

Yeah James is correct. You can’t use GameObject, only gameObject will work whichever way you use it.

9

that worked! Thanks guys! But how did that work as gameObject was never defined anywhere. I didn’t think that the code would know that gameObject was tied to either GameObject or Player. I know it’s case sensitive, but I figured if I changed the case of something that was already defined, it wouldn’t know what to match it up with.

and why would the other code not work? That way I don’t make these mistakes again

10

I don’t properly know myself, I’m pretty sure what James said above is what you’re looking for. GameObject is the base class for all entities in Unity scenes. gameObject is the actual object though? I think. Don’t quote me on it.

11

Your class is derived from another class, which knows it.