Character can jump mid air forever

Questions & Answers
1

my character can jump forever, even in the air. How can I fix this?

here is my code:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PlayerMovement : MonoBehaviour

{

public CharacterController controller; 
public float speed = 12f;
public float gravity = -9.81f;
public float jumpHeight = 3f;

public Transform groundCheck; 
public float groundDistance = 0.4f;
public LayerMask groundMask;

Vector3 velocity;
bool isGrounded;


// Start is called before the first frame update
void Start()
{
    
}

// Update is called once per frame
void Update()
{

	isGrounded = Physics.CheckSphere(groundCheck.position, groundDistance, groundMask);
	if(isGrounded && velocity.y < 0){
		velocity.y = -2f;
	}

    float x = Input.GetAxis("Horizontal");
    float z = Input.GetAxis("Vertical");

    Vector3 move = transform.right * x + transform.forward * z;
    controller.Move(move * speed * Time.deltaTime);

    if(Input.GetButtonDown("Jump") && isGrounded){
        velocity.y = Mathf.Sqrt(jumpHeight * -2 * gravity);
    }

    velocity.y += gravity * Time.deltaTime;
    controller.Move(velocity * Time.deltaTime);

}

}

2

IsGrounded is never set to false. Does your groundCheck object move with the player, and is the groundDistance a suitable radius, such as 0.25f? @Unity_GameBreaker

3

Is it possible that your own character is getting picked up by the checkSphere? You might want to use tags to see if the player’s jump should be refreshed

4

Ok, so I managed to get it working by using controller.isGrounded instead of the checkSphere. But now I cant jump while standing still :confused: Here’s the updated code: using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PlayerMovement : MonoBehaviour

{

public CharacterController controller; 
public float speed = 12f;
public float gravity = -9.81f;
public float jumpHeight = 3f;

public Transform groundCheck; 
public float groundDistance = 0.4f;
public LayerMask groundMask;

Vector3 velocity;
bool isGrounded;


// Update is called once per frame
void Update()
{ 

	
	if(controller.isGrounded == true && velocity.y < 0)
    {
		velocity.y = -2f;
	}

    float x = Input.GetAxis("Horizontal");
    float z = Input.GetAxis("Vertical");

    Vector3 move = transform.right * x + transform.forward * z;
    controller.Move(move * speed * Time.deltaTime);

    if(Input.GetButtonDown("Jump") && controller.isGrounded == true)
    {
        velocity.y = Mathf.Sqrt(jumpHeight * -2f * gravity);
    }

    velocity.y += gravity * Time.deltaTime;
    controller.Move(velocity * Time.deltaTime);

}

}