Class Programming to build an inventory system

Archived Forums Questions & Answers
1

I am doing inventory system, and try to implement it in Classes way. But there are some problems.

class Inventory{
private var items:Item[]=new Item[GameData.player_max_slots];

function Inventory(){
    print("1");
    for(var i=0;i<GameData.player_max_slots;i++)
    items*=null;*
*}*
*function Print_Item_Names(){*
 *for(var i=0;i<GameData.player_max_slots;i++)*
 _print(items*.GetName);*_
 _*print("2");*_
_*}*_
<em>*function Add_Item(_item:Item)*</em>
_*{*_
 <em>*for(var i=0;i<GameData.player_max_slots;i++)*</em>
 <em><em>items*=_item;*</em></em>
 <em>_*print("3");*_</em>
<em>_*}*_</em>
<em>_*```*_</em>
<em>_*<p>}</p>*_</em>
<em>_*```*_</em>
 <em>_*class Item{*_</em>
<em>_*private var name:String;*_</em>
<em><em>*function Item(_name:String)*</em></em>
<em>_*{*_</em>
 <em><em>*name=_name;*</em></em>
<em>_*}*_</em>
<em>_*function GetName():String{*_</em>
 <em>_*return name;*_</em>
<em>_*}*_</em>
<em>_*```*_</em>
<em>_*<p>}</p>*_</em>
<em>_*<p>And I try to test it:</p>*_</em>
<em>_*```*_</em>
<em>_*if (Input.GetKeyDown ("q"))*_</em>
<em>_*{*_</em>
 <em><em>*var player_inventory:Inventory=new Inventory();*</em></em>
 <em><em>*player_inventory.Add_Item(new Item("ff"));*</em></em>
 <em><em>*player_inventory.Print_Item_Names();*</em></em>
<em>_*}*_</em>
<em>_*```*_</em>
<em><em>*<p>Print_Item_Names() doesn't work.*</em></em>
<em>_*And even print("1"); print("2"); print("3"); in methods of the inventory Class are not called.</p>*_</em>

3 Answers

3
2

Sounds like the constructor is not getting called.

If you put a print("0"); in front of the first line, does IT print?

Is your script attached to an object that's enabled?

Is it in an OnGUI or Update function (or something like it)?

If you put a print("0"); in front of the first line, does IT print? No, it doesn't print. Is your script attached to an object that's enabled? 1. The 2 classes scripts doesn't attach to anything, do I need to? 2. The script of press "q" and print result is attached to an empty object, this function will execute. I have tested. Is it in an OnGUI or Update function (or something like it)? Yes, the press "q" function is in Update(); Thanks

 –

err. why no line break...maybe need to press shift+enter? I try try 1 more time

 –

I typically attach scripts with OnGUI() or Update() functions to the GameObjects they interact with. In your case I would attach that script to an empty, enabled GameObject for testing purposes. Or to anything in your scene.

 –
3

First of all, you don't need to initialize reference type variables to null. I.e., in your Inventory constructor, don't loop through the array, setting items*=null;. When you create an empty static array of objects, the elements are automatically null.

* *

That said, I'm not sure why at least print("1") wouldn't get called. All other errors aside, when you hit q, the first thing that happens is that the Inventory constructor is invoked, which calls print("1") as its very first action. Therefore, I suspect there's a problem with this code's location in your program. Where have you put the if-statement testing for the q-key? Is it in some script's Update? Is that script enabled?

*

if statement will be executed, I have tested. It's in Update. I agree constructor is invoked, theory print will run first. Very wired ahhhh~~~

 –
4

Classes that don't derive from MonoBehaviour don't properly recognize the `print` function, though I don't remember why anymore. For whatever reason they don't throw an error on it, but it just doesn't do anything. You can use `Debug.Log` and it will work, or you can make your class derive from MonoBehaviour - depending on your needs.

Yes, you got the point. I found print() not applicable in class methods, other methods function normal.

 –