Converting java to C#

[Colmonkey]

Hi,

I am very new to coding. And I have been reading alot, I just havn’t actually started coding. So I figured I wasn’t learning anything because I wasn’t actually doing it. I decided to try to make a small test FPS by converting javascript over to C#.

So I tried to make a mouse(camera) controller for my FPS. And I have no idea what I did wrong. I’m sure there is plenty wrong… But I thought the best way to learn would be to hear what I did wrong instead of just guessing for hours.

Here is my code that I am having trouble with:

using UnityEngine;
using System.Collections;

public class cameraControl : MonoBehaviour {

public float defaultCameraAngle = 60f;
public float currentTargetCameraAngle = 60f;
public float racioZoom = 1f;
public float racioZoomV;
public float racioZoomSpeed = 0.2f;
public float lookSensitivity = 5f;
public float yRotation;
public float xRotation;
public float currentYRotation;
public float currentXRotation;
public float yRotationV;
public float xRotationV;
public float lookSmoothDamp = 0.1f;
public float currentAimRacio = 1f;

// Use this for initialization
void Start () {

}

// Update is called once per frame
void Update () {

if (currentAimRacio == 1)
{
racioZoom = Mathf.SmoothDamp (racioZoom, 1, racioZoomV, racioZoomSpeed);
}
else
{
racioZoom = Mathf.SmoothDamp (racioZoom, 0, racioZoomV, racioZoomSpeed);

camera.fieldOfView = Mathf.Lerp (currentTargetCameraAngle, defaultCameraAngle, racioZoom);

yRotation += Input.GetAxis (“Mouse X”) * lookSensitivity * currentAimRacio;
xRotation -= Input.GetAxis (“Mouse Y”) * lookSensitivity * currentAimRacio;

xRotation = Mathf.Clamp (xRotation, -90, 90);

currentXRotation = Mathf.SmoothDamp (currentXRotation, xRotation, xRotationV, lookSmoothDamp);
currentYRotation = Mathf.SmoothDamp (currentYRotation, yRotation, yRotationV, lookSmoothDamp);
transform.rotation = Quaternion.Euler (currentXRotation, currentYRotation, 0);
}

}
}

[wolvz38]

I think you want some code like this:

h += Input.GetAxis ("Mouse X") * horizontalSensitivity * Time.deltaTime;
v -= Input.GetAxis ("Mouse Y") * verticalSensitivity * Time.deltaTime;

v = ClampAngle (v, minVerticalAngle, maxVerticalAngle);
		
newRotation = Quaternion.Euler (v, h, 0.0f);
cameraTransform.rotation = newRotation;

Also if you want to add smoothing just add a new Quaternion variable and use Quaternion.Slerp function.

[Colmonkey]

@wolvz38

I think you want some code like this:

h += Input.GetAxis ("Mouse X") * horizontalSensitivity * Time.deltaTime;
v -= Input.GetAxis ("Mouse Y") * verticalSensitivity * Time.deltaTime;

v = ClampAngle (v, minVerticalAngle, maxVerticalAngle);
		
newRotation = Quaternion.Euler (v, h, 0.0f);
cameraTransform.rotation = newRotation;

Also if you want to add smoothing just add a new Quaternion variable and use Quaternion.Slerp function.

Hey thanks man, but I guess I wasn’t really looking for a new script. I was more so looking for an explanation of what was wrong with my script. I’m only really making this game to learn to code.

[wolvz38]

Yeah I wasn’t trying to give you different code to use. I was just showing you a way it can be done. The camera updates should be in LateUpdate() not Update(). Also you might want to make a new function like the one I have called ClampAngle. It should check if the angle is over 360 and subtract 360 from it, or if it’s lower than -360 it should add 360 to it. Then it takes the final angle and clamps it using Mathf.Clamp and returns it.

    public static float ClampAngle(float angle, float min, float max)
    {
        if (angle < -360F)
            angle += 360F;
        if (angle > 360F)
            angle -= 360F;
        return Mathf.Clamp(angle, min, max);
    }