Custom editor tool causes crash

Unity Engine
1

I’ve encountered a very strange problem that I can’t seem to find a solution too. However I suspect that it’s an issue related to serialization.

I have an A-star based pathing system, and in order to quickly create pathing graphs I’ve written a simple tool to connect nodes. The nodes are basically just game objects with a simple script that contains a list of references to other node objects. My editor tool takes all the nodes (called Cookies) in the current selection and attempts to connect them to eachother. To save the changes it makes, I’m calling SetDirty on the node object after modifying its edges.

The thing is, that it seems to work just fine. And in fact, it works just fine on my machine (running OSX), but some scenes just crash the unity editor when they are loaded by my teammates working on windows machines. I haven’t got a crash log atm, but from what I could tell there was not really any information about what went wrong.

If I load up the corrupted scenes (on osx) and remove all the node objects, the other guys can load the scene again. Crash occurs when opening the scene in the editor or attempting to load it using LoadLevelAsync.

    public class NodeTool
    {
        [MenuItem("Pathing/Connect Nodes %g")]
        public static void InterconnectNodes()
        {
            var cookies = new List<Cookie>();
            foreach(var obj in Selection.gameObjects) {
                var cookie = obj.GetComponentInChildren<Cookie>();
                if (cookie != null)
                    cookies.Add(cookie);
            }

            Debug.Log(string.Format("Connecting {0} cookies", cookies.Count));

            foreach(var cookie in cookies) {
                foreach(var other in cookies) {
                    if (cookie == other)
                        continue;
                    cookie.Connect(other);
                }
                EditorUtility.SetDirty(cookie);
            }
        }
    }

And the actual cookie class:

    [Serializable]
    public class Cookie : MonoBehaviour
    {
        [SerializeField]
        public List<Cookie> Edges = new List<Cookie>();

        public void Connect(Cookie other) {
            if (!Edges.Contains(other))
                Edges.Add(other);
        }
    }

(I added the serialization attributes recently, but they don’t seem to make any difference what so ever)

2

Shameless bump :slight_smile:

I’ve read something about the serializer perhaps inlining objects and then deserializing multiple instances instead of one referenced object, but in my case this shouldn’t happen right? Since all the references are MonoBehaviours owned by the scene, it should properly serialize them as references?

3

They are saved by reference. [Serialize] ad [SerializedField] are both redundant, since MonoBehaviour are always serialized, and the same thing for public fields.

Frankly, without the crash log, there’s no evidence towards this snippet being the culprit.

4

Thanks for your reply. I kind of figured that the serialization attributes were reduntant, I just put them there to make sure :slight_smile:

I’m pretty sure the problem is related to this code since I can “un-corrupt” scenes by removing all the cookie objects. I’m guessing that the problem is related to serialization since the problem appears the first time you reload the scene.

Anyways, I’ve got a crash log (not sure if it’s the right one though).

5

That’s a Window crash report, try getting the Unity’s crash report. On Windows, it should be in "%localappdata%\Unity\Editor"

Note that only 2 editor log are kept, the current one, and the previous one.

6

Ah yeah. This is the actual editor crash log :slight_smile:

From what I can see in the stack trace it looks like some kind of mesh corruption? hmm

7

At first sight, sure looks like it.