Deduct health on collision

Questions & Answers
1

The last question went a bit off topic. This script I am writing is supposed to decrease the players health if anything with a tag of Enemy collides with it. It doesn’t seem to do this and Im not sure what Im supposed to do, also if I could have some more help with having a timer so it only takes of damage every second or so, that would be great, thanks.

var fullHealth : int = 100;
var curHealth : int = 100;

function OnCollisionEnter(collision: Collision) {

if(collision.gameObject.tag == "Enemy");
  curHealth -= 10;
  print ("hit");
}

function Update () {

if(curHealth >= fullHealth){
    curHealth = fullHealth;
}

  if(curHealth <= 0){
    curHealth = 0;
    Debug.Log("You are Dead");
}
}

function OnGUI() {
    GUI.Label (Rect (25, 40, 100, 20), "Health = "+curHealth);
}
2

This is bit confusing. First, is curHealth supposed to be the current health, then it is the one you should be editing, not the full health. also, I don’t understand the purpose of checking if curHealth is => fullHealth. But that is aside the point. In any case, it should work fine with this code, what I would guess is the issue is that OnCollisionEnter is never called, so there is no hit. have you established that the function is called? (that is, do you see your hit debug message?)

3

It seems, at least from a logic perspective, that you are misusing “Full” and “Current” health levels. The “Full Health” represents the highest health level, a static number that should not be changed. “Current Health” is your bread and butter.

I’ll make a leap and assume that your checking Current against Full in the Update to assure that Current never exceeds the maximum. I would change the second IF to reflect:

if ( curHealth <= 0 ) {
    curHealth = 0;
    Debug.Log ( "You are Dead" );
}

Similar issue in your OnCollisionEnter FUNCTION:

if ( collision.gameObject.tag == "Enemy" );
  curHealth -= 10;
  print ( "hit" );
}

Concentrate on using Current Health as your “working” health level and leave the Full Health variable to simply describe the maximum.

Hope that helps.

Edited to Add: You’ll need to change your GUI as well (Full to Current).