Design question

Unity Engine
1

I have AI and Player units and buildings. Now, for selection for example, AI and Player units and buildings are treated the same. I want to escape code duplication. To summarize, no matter a unit or a building, no matter AI or Player selection methods are same.

Options:

  1. I can prefix the methods with PB, PU, AIB or AIU. That means player building, player unit, ai building or ai unit. And yeah you get code duplication this way. There are tiny differences only.

  2. I can have one method for all, but it will take two bool arguments “player” and “unit”. If we have player == true and unit == true then i will execute code for player unit. If for example we have player == true and unit == false then i execute code for player building. Similar for ai units and buildings.

Let me know what you guys think

PS: Not Unity directly related maybe, but I am new to component-based programming so I am still not sure about such design questions

2

It sounds to me like you’re trying to do something to the unit, rather than responding to the selection. Is that right? It’s hard to tell without code. If that is the case, I’d reverse the interaction.