Destroying enemie prefab clones when running from battle

Unity Engine
1

I’ve made it so that the enemy spawns when I enter battle, I have a function that allows me to run from battle which works but the problem I’m having is the enemies which are prefab clones don’t destroy themselves once I’ve left the battle so when I enter battle again they are still the same ones as before… Anyone got any ideas?

// Enemy Prefabs
var Enemy1 : GameObject;
var Enemy2 : GameObject;
var Enemy3 : GameObject;

var spawn1 : Transform;
var spawn2 : Transform;
var spawn3 : Transform;


function Start () {
spawnEnemies ();
}
function spawnEnemies () {
        for(var i=0;i<3;i++) {
                var random1 : int = Random.Range(0,3);
                switch (random1) {
                        case (0):
                        var spawnEnemy1 = Instantiate(Enemy1);
                        switch (i) {
                                case (0):
                                spawnEnemy1.transform.position = new Vector3(spawn1.transform.position.x, spawn1.transform.position.y, spawn1.transform.position.z);
                                spawnEnemy1.transform.tag = "enemy1"; 
                                break;
                                case (1):
                                spawnEnemy1.transform.position = new Vector3(spawn2.transform.position.x, spawn2.transform.position.y, spawn2.transform.position.z);
                                spawnEnemy1.transform.tag = "enemy2"; 
                                break;
                                case (2):
                                spawnEnemy1.transform.position = new Vector3(spawn3.transform.position.x, spawn3.transform.position.y, spawn3.transform.position.z);
                                spawnEnemy1.transform.tag = "enemy3"; 
                                break;
                                }
                        break;          
                        case (1):
                        var spawnEnemy2 = Instantiate(Enemy2);
                                switch (i) {
                                case (0):
                                spawnEnemy2.transform.position = new Vector3(spawn1.transform.position.x, spawn1.transform.position.y, spawn1.transform.position.z);
                                spawnEnemy2.transform.tag = "enemy1"; 
                                break;
                                case (1):
                                spawnEnemy2.transform.position = new Vector3(spawn2.transform.position.x, spawn2.transform.position.y, spawn2.transform.position.z);
                                spawnEnemy2.transform.tag = "enemy2"; 
                                break;
                                case (2):
                                spawnEnemy2.transform.position = new Vector3(spawn3.transform.position.x, spawn3.transform.position.y, spawn3.transform.position.z);
                                spawnEnemy2.transform.tag = "enemy3"; 
                                break;
                                }
                        break; 
                        case (2):
                        var spawnEnemy3 = Instantiate(Enemy3);
                                switch (i) {
                                case (0):
                                spawnEnemy3.transform.position = new Vector3(spawn1.transform.position.x, spawn1.transform.position.y, spawn1.transform.position.z);
                                spawnEnemy3.transform.tag = "enemy1"; 
                                break;
                                case (1):
                                spawnEnemy3.transform.position = new Vector3(spawn2.transform.position.x, spawn2.transform.position.y, spawn2.transform.position.z);
                                spawnEnemy3.transform.tag = "enemy2"; 
                                break;
                                case (2):
                                spawnEnemy3.transform.position = new Vector3(spawn3.transform.position.x, spawn3.transform.position.y, spawn3.transform.position.z);
                                spawnEnemy3.transform.tag = "enemy3"; 
                                break;
                                }
                        break; 
}
}
}
2

Alright, I see a number of of problems here.

Getting a Random index of 0-3 results in 4 possible values, but you only consider 3 in your switch case. It should be Random.Range(0,2)

If there is a reason you’re giving your enemy game objects different tags, they should be more descriptive. Otherwise it should just be “Enemy”. Tags offer a builtin way to find objects by type. Having two different tags called “enemy1” and “enemy2” serves no purpose.

There is a lot of redundant code here. Your prefabs and transforms should really be in a builtin array, so that you wouldn’t have to duplicate code while writing your switch case.
This entire thing could be refactored as follows:

var enemies : GameObject[];
var spawns : Transform[];

function Start(){
    spawnEnemies();
}

function spawnEnemies() {
   
    for (var i = 0; i < spawns.Length; i++) {
   
        var prefab_index : int = Random.Range(0, enemies.Length - 1);
       
        var enemy = Instantiate(enemies[prefab_index], spawns[i].position, Quaternion.identity);
        enemy.tag = "enemy";

    }

}

Finally, you’ve only supplied with part of your code. You’ve shown us how you create enemies, but not what happens when the battle ends. You don’t call the Destroy() function anywhere here. Whatever function is called when the battle ends, you’d need to iterate through each of your enemy gameObjects and destroy them accordingly:

function endBattle() {
   
    var active_enemies = GameObject.FindGameObjectsWithTag("enemy");
   
    for(var enemy in active_enemies) {
        Destroy(enemy);
    }
   
}

It might benefit you to take some coding tutorials! We all had to start somewhere, and I think you’ll find you’ll have a lot of confusing and frustrating problems if you don’t have a good grasp on the basics. Making games is fantastic practice, but it would help if you had a good foundation to practice on.

3

Followed tutorials etc just didnt know you could do it other ways to how I’ve learnt lol.
Cheers though ill read through what you’ve put and see what new things I learn. :slight_smile:

4

Destroying the prefabs makes it so they don’t respawn again when you next go into battle :confused: lol

5

Y

You can’t destroy prefabs at runtime, it isn’t possible, so you should be using prefabs from the project browser and not instancing gameobjects placed in the scene. The code I gave you destroys the instances of the prefabs, which would be the gameObjects in play.

6

Yup saved it as a prefab and put it into my list, it spawns before I even go into battle and then once I click Run to go back to the map it just doesn’t come back when I go back to the battle plane thats under my map, would it be better to make a scene for the battle? :confused:

7

Once again, I’m going to suggest some fundamentals! I’d go back and do some more tutorials and really wrap your head around unity’s workings. There are a lot of correct ways to create in unity, and without a strong understanding of how your project is set up, the answers I’d give you wouldn’t be of much benefit.

Tell you what though, upload your scene and additional code, I’ll take a look and give you some pointers.

8

will do ill upload it to dropbox and message you a link :slight_smile: if the problem can be solved, i can post back on here with the answer. So people know if they come across this. :slight_smile: