Fire Rate Script

Unity Engine
,
1

Hello, I need help with my scripts to change fire rate of the weapon, I still don’t understand coding too much, I’m very new to this, if anyone can help me I would be so grateful.

RaycastWeapon:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.InputSystem;

public class RaycastWeapon : MonoBehaviour

{   
    [SerializeField]
    private GameObject bulletPrefab;
    [SerializeField]
    private Transform barrelTransform;
    [SerializeField]
    private Transform bulletParent;

    private CharacterController controller;
    private PlayerInput playerInput;
    private float bulletHitMissDistance = 50f;
    private Transform cameraTransform;
    private InputAction shootAction;
    public ParticleSystem muzzleFlash;
    public ParticleSystem hitEffect;
    public TrailRenderer tracerEffect;

    private void Awake()
    {
        controller = GetComponent<CharacterController>();
        playerInput = GetComponent<PlayerInput>();
        cameraTransform = Camera.main.transform;
        shootAction = playerInput.actions["Shoot"];

        Cursor.lockState = CursorLockMode.Locked;
    }
    private void OnEnable()
    {
       
        shootAction.performed += _ => ShootGun();
    }

    private void OnDisable()
    {
        shootAction.performed -= _ => ShootGun();
    }

    private void ShootGun()
    {
        RaycastHit hit;
        GameObject bullet = GameObject.Instantiate(bulletPrefab, barrelTransform.position, Quaternion.identity, bulletParent);
        BulletController bulletController = bullet.GetComponent<BulletController>();

        var tracer = Instantiate(tracerEffect, barrelTransform.position, Quaternion.identity);
        tracer.AddPosition(barrelTransform.position);

        if (Physics.Raycast(cameraTransform.position, cameraTransform.forward, out hit, Mathf.Infinity))
        {
            bulletController.target = hit.point;
            bulletController.hit = true;
            hitEffect.transform.position = hit.point;
            hitEffect.transform.forward = hit.normal;
            hitEffect.Emit(1);
            muzzleFlash.Emit(1);
            tracer.transform.position = hit.point;
        }
        else
        {
            bulletController.target = cameraTransform.position + cameraTransform.forward * bulletHitMissDistance;
            bulletController.hit = false;
        }
    }
}

Bullet Controller:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class BulletController : MonoBehaviour
{
[SerializeField]
private GameObject bulletDecal;

private float speed = 500f;
private float timeToDestroy = 3f;

public Vector3 target { get; set; }
public bool hit { get; set; }

private void OnEnable()
{
Destroy(gameObject, timeToDestroy);
}

void Update()
{
transform.position = Vector3.MoveTowards(transform.position, target, speed * Time.deltaTime);
if (!hit && Vector3.Distance(transform.position, target) < .01f)
{
Destroy(gameObject);
}
}

private void OnCollisionEnter(Collision other)
{
ContactPoint contact = other.GetContact(0);
GameObject.Instantiate(bulletDecal, contact.point + contact.normal * 0.03f, Quaternion.LookRotation(contact.normal));
Destroy(gameObject);
}

}

2

Welcome, but I don’t see where in the code relates to firing more than once, except if you repeatedly call the bullet firing mechanism.

It may not be code. It may be somewhere else like perhaps the input system setup. Go find out!

It’s possible you got this out of a tutorial without fully understanding what it does. You should probably go back and revisit this material.

Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

How to do tutorials properly, two (2) simple steps to success:

Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That’s how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.
Fortunately this is the easiest part to get right: Be a robot. Don’t make any mistakes.
BE PERFECT IN EVERYTHING YOU DO HERE!!

If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there’s an error, you will NEVER be the first guy to find it.

Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

1 Like