For loop - two conditions are executed if and else, why?

Questions & Answers
1

Hey,
I am not familiar with loops and an array. Unfortunately now I have to deal with both of them :frowning:

In my scene I have some zones - box colliders as triggers. When my player enters one of these zones, camera behavior changes. Everything worked perfectly untill now. Now I added a new line in an If statement where I want to increase smoothSpeed variable when the player enters the zone. But when he exits it, I am not able to change smoothSpeed value back.

What’s strange, I print string in if and else statement and when the player enters the zone, both of them are prented. Why?

Here’s my code:

if(changeCamBehaviorCubes != null)
{
	for (int i = 0; i < changeCamBehaviorCubes.Length; i++)
	{
		ChangeCameraBehavior changeCameraBehavior_current = changeCamBehaviorCubes*.GetComponent<ChangeCameraBehavior>();*

  •  if(changeCameraBehavior_current.breakPattern == true)*

  •  {*

  •  	moveUp = player.transform.position.y;*

  •  	cameraPosition.x = 0;*

  •  	smoothSpeed = 8;*

  •  	print("In a box.");*

  •  }*

  •  else*

  •  	print ("Out of box.");*

  • }*
    }

2

It’s very vague what you actually want. I guess something like this:

 bool outOfAll = true;
 for (int i = 0; i < changeCamBehaviorCubes.Length; i++)
 {
     ChangeCameraBehavior changeCameraBehavior_current = changeCamBehaviorCubes*.GetComponent<ChangeCameraBehavior>();*

if(changeCameraBehavior_current.breakPattern == true)
{
moveUp = player.transform.position.y;
cameraPosition.x = 0;
smoothSpeed = 8;
outOfAll = false;
print(“In a box.”);
}
}
if (outOfAll)
{
// We’re not inside any box
}
Additionally, since you get your “changeCamBehaviorCubes” array once at start you might want to directly store your “ChangeCameraBehavior” instances in the array instead of GameObjects. That way you avoid calling GetComponent all the time.
// add at the top
using System.Linq;
private ChangeCameraBehavior[] changeCamBehaviorCubes;

void Awake ()
{
changeCamBehaviorCubes = GameObject.FindGameObjectsWithTag (“ChangeBehavior”).Select(g => g.GetComponent()).ToArray();
}
If you don’t want to use Linq you can do it manually in a loop
void Awake ()
{
GameObject[] tmp = GameObject.FindGameObjectsWithTag (“ChangeBehavior”);
changeCamBehaviorCubes = new ChangeCameraBehavior[tmp.Length];
for(int i = 0; i < tmp.Length; i++)
{
changeCamBehaviorCubes = tmp*.GetComponent();*
}
}
Using arrays and loops are useful when you want to do the same thing to multiple objects. However since each trigger has already a script attached, wouldn’t it be easier to implement those actions right there? OnTriggerEnter2D / OnTriggerExit2D are events which are only called when something happens. By just setting a flag and then poll through an array seems a bit wasteful.

3

Ok, I did not try @Bunny83 's solution but I solved it pretty easy with a static bool.

My ChangeCameraBehavior script:

	void OnTriggerEnter2D (Collider2D other)
	{
		if(other.tag == "Player")
			CameraScript.breakPattern = true;
	}

	void OnTriggerExit2D (Collider2D other)
	{
		if(other.tag == "Player")
			CameraScript.breakPattern = false;
	}

Just like that. But my Camera script:

public static bool breakPattern;

if (breakPattern)
			print("In a box.");
		else
			print ("Out of a box.");

It is working with how many box colliders I want because it is working with only one static bool variable and it is realy simple solution.

Thanks to everyone for help, especially to @Linus - He put me on a right track :slight_smile: thanks.