For some reason the function of the script dies after one scene.

justinmed · May 21, 2024, 6:46pm

For some reason the function of this script dies on scene change and never works again until I restart the editor and after the first scene it dies again. Can anyone see what might be going on here?

It is for a piano app as you might notice and the pattern just continues to go down the keys which I excluded most of but left enough that one should get the jist. I am not plugging any of the notes into the script manually as you can see.

using System;
using System.Collections;
using System.Collections.Generic;
using FullscreenEditor;
using Minis;
using UnityEngine;
using UnityEngine.EventSystems;
using UnityEngine.InputSystem;
using UnityEngine.UI;



public class MIDI_InputTest : MonoBehaviour
{

    public Button A0Button;
    public Button A1Button;
    public Button A2Button;
    public Button A3Button;
    public Button A4Button;
    public Button A5Button;
    public Button A6Button;
    public Button A7Button;
    public Button Ab1Button;
    public Button Ab2Button;
    public Button Ab3Button;
    public Button Ab4Button;
    public Button Ab5Button;
    public Button Ab6Button;
    public Button Ab7Button;
    public Button B0Button;
    public Button B1Button;
    public Button B2Button;
    public Button B3Button;
    public Button B4Button;
    public Button B5Button;
    public Button B6Button;
    public Button B7Button;
    public Button Bb0Button;
    public Button Bb1Button;
    public Button Bb2Button;
    public Button Bb3Button;
    public Button Bb4Button;
    public Button Bb5Button;
    public Button Bb6Button;
    public Button Bb7Button;
    public Button C1Button;
    public Button C2Button;
    public Button C3Button;
    public Button C4Button;
    public Button C5Button;
    public Button C6Button;
    public Button C7Button;
    public Button C8Button;
    public Button D1Button;
    public Button D2Button;
    public Button D3Button;
    public Button D4Button;
    public Button D5Button;
    public Button D6Button;
    public Button D7Button;
    public Button Db1Button;
    public Button Db2Button;
    public Button Db3Button;
    public Button Db4Button;
    public Button Db5Button;
    public Button Db6Button;
    public Button Db7Button;
    public Button E1Button;
    public Button E2Button;
    public Button E3Button;
    public Button E4Button;
    public Button E5Button;
    public Button E6Button;
    public Button E7Button;
    public Button Eb1Button;
    public Button Eb2Button;
    public Button Eb3Button;
    public Button Eb4Button;
    public Button Eb5Button;
    public Button Eb6Button;
    public Button Eb7Button;
    public Button F1Button;
    public Button F2Button;
    public Button F3Button;
    public Button F4Button;
    public Button F5Button;
    public Button F6Button;
    public Button F7Button;
    public Button G1Button;
    public Button G2Button;
    public Button G3Button;
    public Button G4Button;
    public Button G5Button;
    public Button G6Button;
    public Button G7Button;
    public Button Gb1Button;
    public Button Gb2Button;
    public Button Gb3Button;
    public Button Gb4Button;
    public Button Gb5Button;
    public Button Gb6Button;
    public Button Gb7Button;


   

    void Start()
   
   
    {
        A1Button = GameObject.Find("A1Button").GetComponent<Button>();
        A0Button = GameObject.Find("A0Button").GetComponent<Button>();
        A2Button = GameObject.Find("A2Button").GetComponent<Button>();
        A3Button = GameObject.Find("A3Button").GetComponent<Button>();
        A4Button = GameObject.Find("A4Button").GetComponent<Button>();
        A5Button = GameObject.Find("A5Button").GetComponent<Button>();
        A6Button = GameObject.Find("A6Button").GetComponent<Button>();
        A7Button = GameObject.Find("A7Button").GetComponent<Button>();
        Ab1Button = GameObject.Find("Ab1Button").GetComponent<Button>();
        Ab2Button = GameObject.Find("Ab2Button").GetComponent<Button>();
        Ab3Button = GameObject.Find("Ab3Button").GetComponent<Button>();
        Ab4Button = GameObject.Find("Ab4Button").GetComponent<Button>();
        Ab5Button = GameObject.Find("Ab5Button").GetComponent<Button>();
        Ab6Button = GameObject.Find("Ab6Button").GetComponent<Button>();
        Ab7Button = GameObject.Find("Ab7Button").GetComponent<Button>();
        B0Button = GameObject.Find("B0Button").GetComponent<Button>();
        B1Button = GameObject.Find("B1Button").GetComponent<Button>();
        B2Button = GameObject.Find("B2Button").GetComponent<Button>();
        B3Button = GameObject.Find("B3Button").GetComponent<Button>();
        B4Button = GameObject.Find("B4Button").GetComponent<Button>();
        B5Button = GameObject.Find("B5Button").GetComponent<Button>();
        B6Button = GameObject.Find("B6Button").GetComponent<Button>();
        B7Button = GameObject.Find("B7Button").GetComponent<Button>();
        Bb0Button = GameObject.Find("Bb0Button").GetComponent<Button>();
        Bb1Button = GameObject.Find("Bb1Button").GetComponent<Button>();
        Bb2Button = GameObject.Find("Bb2Button").GetComponent<Button>();
        Bb3Button = GameObject.Find("Bb3Button").GetComponent<Button>();
        Bb4Button = GameObject.Find("Bb4Button").GetComponent<Button>();
        Bb5Button = GameObject.Find("Bb5Button").GetComponent<Button>();
        Bb6Button = GameObject.Find("Bb6Button").GetComponent<Button>();
        Bb7Button = GameObject.Find("Bb7Button").GetComponent<Button>();
        C1Button = GameObject.Find("C1Button").GetComponent<Button>();
        C2Button = GameObject.Find("C2Button").GetComponent<Button>();
        C3Button = GameObject.Find("C3Button").GetComponent<Button>();
        C4Button = GameObject.Find("C4Button").GetComponent<Button>();
        C5Button = GameObject.Find("C5Button").GetComponent<Button>();
        C6Button = GameObject.Find("C6Button").GetComponent<Button>();
        C7Button = GameObject.Find("C7Button").GetComponent<Button>();
        C8Button = GameObject.Find("C8Button").GetComponent<Button>();
        D1Button = GameObject.Find("D1Button").GetComponent<Button>();
        D2Button = GameObject.Find("D2Button").GetComponent<Button>();
        D3Button = GameObject.Find("D3Button").GetComponent<Button>();
        D4Button = GameObject.Find("D4Button").GetComponent<Button>();
        D5Button = GameObject.Find("D5Button").GetComponent<Button>();
        D6Button = GameObject.Find("D6Button").GetComponent<Button>();
        D7Button = GameObject.Find("D7Button").GetComponent<Button>();
        Db1Button = GameObject.Find("Db1Button").GetComponent<Button>();
        Db2Button = GameObject.Find("Db2Button").GetComponent<Button>();
        Db3Button = GameObject.Find("Db3Button").GetComponent<Button>();
        Db4Button = GameObject.Find("Db4Button").GetComponent<Button>();
        Db5Button = GameObject.Find("Db5Button").GetComponent<Button>();
        Db6Button = GameObject.Find("Db6Button").GetComponent<Button>();
        Db7Button = GameObject.Find("Db7Button").GetComponent<Button>();
        E1Button = GameObject.Find("E1Button").GetComponent<Button>();
        E2Button = GameObject.Find("E2Button").GetComponent<Button>();
        E3Button = GameObject.Find("E3Button").GetComponent<Button>();
        E4Button = GameObject.Find("E4Button").GetComponent<Button>();
        E5Button = GameObject.Find("E5Button").GetComponent<Button>();
        E6Button = GameObject.Find("E6Button").GetComponent<Button>();
        E7Button = GameObject.Find("E7Button").GetComponent<Button>();
        Eb1Button = GameObject.Find("Eb1Button").GetComponent<Button>();
        Eb2Button = GameObject.Find("Eb2Button").GetComponent<Button>();
        Eb3Button = GameObject.Find("Eb3Button").GetComponent<Button>();
        Eb4Button = GameObject.Find("Eb4Button").GetComponent<Button>();
        Eb5Button = GameObject.Find("Eb5Button").GetComponent<Button>();
        Eb6Button = GameObject.Find("Eb6Button").GetComponent<Button>();
        Eb7Button = GameObject.Find("Eb7Button").GetComponent<Button>();
        F1Button = GameObject.Find("F1Button").GetComponent<Button>();
        F2Button = GameObject.Find("F2Button").GetComponent<Button>();
        F3Button = GameObject.Find("F3Button").GetComponent<Button>();
        F4Button = GameObject.Find("F4Button").GetComponent<Button>();
        F5Button = GameObject.Find("F5Button").GetComponent<Button>();
        F6Button = GameObject.Find("F6Button").GetComponent<Button>();
        F7Button = GameObject.Find("F7Button").GetComponent<Button>();
        G1Button = GameObject.Find("G1Button").GetComponent<Button>();
        G2Button = GameObject.Find("G2Button").GetComponent<Button>();
        G3Button = GameObject.Find("G3Button").GetComponent<Button>();
        G4Button = GameObject.Find("G4Button").GetComponent<Button>();
        G5Button = GameObject.Find("G5Button").GetComponent<Button>();
        G6Button = GameObject.Find("G6Button").GetComponent<Button>();
        G7Button = GameObject.Find("G7Button").GetComponent<Button>();
        Gb1Button = GameObject.Find("Gb1Button").GetComponent<Button>();
        Gb2Button = GameObject.Find("Gb2Button").GetComponent<Button>();
        Gb3Button = GameObject.Find("Gb3Button").GetComponent<Button>();
        Gb4Button = GameObject.Find("Gb4Button").GetComponent<Button>();
        Gb5Button = GameObject.Find("Gb5Button").GetComponent<Button>();
        Gb6Button = GameObject.Find("Gb6Button").GetComponent<Button>();
        Gb7Button = GameObject.Find("Gb7Button").GetComponent<Button>();
       
       
       
        InputSystem.onDeviceChange += (device, change) =>
        {
            var midiDevice = device as Minis.MidiDevice;
            if (midiDevice == null) return;

            midiDevice.onWillNoteOn += (note, velocity) =>
            {

                // When middle C (MIDI #60) is pressed:
                if (note.noteNumber == 21)
                {

                   
                    ExecuteEvents.Execute(A0Button.gameObject, new PointerEventData(EventSystem.current), ExecuteEvents.submitHandler);

                }
               
                if (note.noteNumber == 22)
                {

                   
                    ExecuteEvents.Execute(Bb0Button.gameObject, new PointerEventData(EventSystem.current), ExecuteEvents.submitHandler);

                }
                if (note.noteNumber == 23)
                {

                   
                    ExecuteEvents.Execute(B0Button.gameObject, new PointerEventData(EventSystem.current), ExecuteEvents.submitHandler);

                }

justinmed · May 21, 2024, 6:59pm

The script is intended to play a piano that is on the screen that is entirely made of buttons with an MIDI controller

justinmed · May 21, 2024, 7:10pm

I tried giving them separate scripts that were duplicates with different namespaces and it still did not work.

lordofduct · May 21, 2024, 7:14pm

When you transition a scene usually the gameobjects (the things scripts are attached to) in that scene are deleted unless marked otherwise by calling DoNotDestroyOnLoad for said gameobject.

Also… what is lords name is this script? Have you not heard of these things called arrays???

justinmed · May 21, 2024, 7:16pm

Right, but all of the objects in each scene that are being called have the same name. All of the piano keys go by the same name in each scene A0Button, Bb0Button, and so on and so forth, I am new. I have heard of them, but did not know enough to use them if it were possible. But, I do not think that is the problem. The script should still grab each object by its name in each new scene and I think maybe it is the MIDI side of things.

lordofduct · May 21, 2024, 7:25pm

Just because they have the same name doesn’t mean the script will survive the scene transition. Nor does it mean that the objects found by name will remain referenced when you transition to the same screen.

2 scenes can have objects all named the same but they’re still different objects. Just like how in my town there can be a Bob Smith, and in the town down the way can also have a Bob Smith.

…

To properly assist you we’ll need to know what the setup is of both scenes, how you transition the scenes, and if you’ve modified any objects to persist between scenes?

justinmed · May 21, 2024, 7:28pm

Okay, so I tried putting the script into a prefab game object and put DontDestroyOnLoad(GameObject), but the script did not function when I did that. So each piano key for the corresponding not sends the player to the next scene within range of that particular key, CMajor or C Minor and so on and so forth, whatever game mode they are in and it sits within a random range of those scenes. If that helps.

lordofduct · May 21, 2024, 7:35pm

justinmed · May 21, 2024, 7:47pm

I have prefabs for each scene that consist of a scoring system and main menu and gameplay helper which I put this script into an empty object and put it in those prefabs and as soon as a new scene loads it just kills the script. I had it in a prefab that also had a dont destroy on load command on it and it still killed it.

spiney199 · May 21, 2024, 11:11pm

You really need to learn how to use arrays/collections and basic loops. I will again reiterate that you still need to learn basic C# principles because you continuously struggling due to ignoring the fundamentals. You’re way out of depth here and you need to spend time to learn how things actually work instead of just writing code and hoping that it does work.

And as mentioned your input management still makes no sense. You’re subscribing to a delegate within a delegate and it is 100% not at all doing what you expect it to. We can’t help you if you don’t spend time to learn properly.

Ryiah · May 21, 2024, 11:18pm

Or a dictionary.

GPT-4o

using System;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class MIDI_InputTest : MonoBehaviour
{
    private Dictionary<string, Button> buttons;

    void Start()
    {
        ConnectButtons();
    }

    void ConnectButtons()
    {
        string[] notes = { "A", "Ab", "B", "Bb", "C", "D", "Db", "E", "Eb", "F", "G", "Gb" };
        int[] noteCounts = { 8, 7, 8, 8, 9, 7, 7, 7, 7, 7, 7, 7 };

        buttons = new Dictionary<string, Button>();

        for (int i = 0; i < notes.Length; i++)
        {
            for (int j = 0; j < noteCounts[i]; j++)
            {
                string buttonName = notes[i] + (j + (notes[i] == "C" ? 1 : 0)) + "Button";
                buttons[buttonName] = GameObject.Find(buttonName).GetComponent<Button>();
            }
        }
    }
}

Were the buttons in the prefab too? Because if they weren’t the script may have survived but all of those button connections were lost and needed to be reattached. That’s why the above script has ConnectButtons. When a scene transition is made you call that method again to reattach all of the buttons.

justinmed · May 21, 2024, 11:52pm

Ryiah:

Or a dictionary.

GPT-4o

using System;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class MIDI_InputTest : MonoBehaviour
{
    private Dictionary<string, Button> buttons;

    void Start()
    {
        ConnectButtons();
    }

    void ConnectButtons()
    {
        string[] notes = { "A", "Ab", "B", "Bb", "C", "D", "Db", "E", "Eb", "F", "G", "Gb" };
        int[] noteCounts = { 8, 7, 8, 8, 9, 7, 7, 7, 7, 7, 7, 7 };

        buttons = new Dictionary<string, Button>();

        for (int i = 0; i < notes.Length; i++)
        {
            for (int j = 0; j < noteCounts[i]; j++)
            {
                string buttonName = notes[i] + (j + (notes[i] == "C" ? 1 : 0)) + "Button";
                buttons[buttonName] = GameObject.Find(buttonName).GetComponent<Button>();
            }
        }
    }
}

Were the buttons in the prefab too? Because if they weren’t the script may have survived but all of those button connections were lost and needed to be reattached. That’s why the above script has ConnectButtons. When a scene transition is made you call that method again to reattach all of the buttons.

So, try and bear with me. As for Spiney, I really do not think I am going to just find all of this stuff in basic C# tutorials. And that is a very interesting method of achieving the button designation, however, it must be true, that that cannot be the issue. I only have the actual script in a prefab. The buttons are not in prefabs. When I look at them live in the hierarchy after a scene has loaded it shows all of the buttons are plugged in where they should be. I think that it has to be something to do with the MIDI. Thank you for all the help, I do appreciate it.

CodeSmile · May 22, 2024, 6:56am

Why are you changing the scene in the first place?

I figure it could very well be done with a single scene. If you need to show some fullscreen GUI, have that canvas object in the scene and disable it, then enable it when you need it. You can avoid most of the “change scene” issues that way.

You could also use additive scene loading - load a scene with the GUI in it additively, then unload it as needed. That way the rest of the scene also remains as is.

This is where AI can be really helpful because you can just ask.

Btw, Unity has it’s own AI chat which provides better answers. You can trial it for two weeks so be sure to make the most of the free time.

spiney199 · May 22, 2024, 7:42am

It’s not about finding what you’re specifically try to do in a tutorial. It’s about giving yourself the tools to solve each development challenge as they arise. You’re throwing yourself in with no tools, and hit constant road blocks as a result.

We give you solutions, but you seldom are ever able to apply them as you don’t have a grip on the core fundamentals.

I think this is bad advice honestly. Using chat bots for programming only really works if you understand programming in the first place. What OP needs is do a good course on C#.

CodeSmile · May 22, 2024, 9:08am

I meant asking AI things like “what is a variable in C#” and what I put in the spoiler.
How will using variables improve my code?

Using variables in your code offers numerous benefits that improve readability, maintainability, and efficiency. Here are some of the key advantages:

1. Readability
Variables make your code more readable and understandable by giving meaningful names to data values. This helps others (and yourself) understand the purpose of specific data in the code.

Example:
Without variables:

csharp
Console.WriteLine(3.14159 * 2 * 5); // What does 3.14159 and 5 represent?

With variables:

csharp
double pi = 3.14159;
double radius = 5;
Console.WriteLine(pi * 2 * radius); // Clear that we are calculating the circumference of a circle

2. Reusability
Variables allow you to reuse values throughout your code without having to repeatedly write the same value.

Example:
csharp
double radius = 5;
double circumference = 2 * Math.PI * radius;
double area = Math.PI * radius * radius;

Console.WriteLine("Circumference: " + circumference);
Console.WriteLine("Area: " + area);

3. Maintainability
Variables make your code easier to maintain and modify. If a value needs to be changed, you only have to update it in one place.

Example:
Without variables:

csharp
Console.WriteLine(2 * 3.14159 * 5);
Console.WriteLine(3.14159 * 5 * 5);

With variables:

csharp
double radius = 5;
double pi = 3.14159;

Console.WriteLine(2 * pi * radius);
Console.WriteLine(pi * radius * radius);

If you need to change the radius, you only change it in one place.

4. Debugging
Variables help in debugging by allowing you to inspect and modify values during the execution of your program. You can set breakpoints and watch specific variables to understand how values change over time.

5. Avoiding Magic Numbers
Using variables helps eliminate “magic numbers” (hard-coded values) in your code, making it more self-explanatory and less error-prone.

Example:
Without variables:

csharp
if (age > 18) {
// Some logic
}

With variables:

csharp
int legalAge = 18;
if (age > legalAge) {
// Some logic
}

6. Parameterization
Variables allow you to write more generic and flexible code that can handle different inputs and scenarios.

Example:
csharp
void PrintArea(double radius) {
double area = Math.PI * radius * radius;
Console.WriteLine("Area: " + area);
}

PrintArea(5);
PrintArea(10);

7. Logical Grouping
Variables enable you to logically group related data, making it easier to understand the relationships between different parts of your code.

Example:
csharp
string firstName = “John”;
string lastName = “Doe”;
int age = 30;

Console.WriteLine("Name: " + firstName + " " + lastName + ", Age: " + age);

Summary
Using variables improves code quality by:

Enhancing readability
Increasing reusability
Simplifying maintenance
Aiding in debugging
Eliminating magic numbers
Allowing for parameterization
Enabling logical grouping of data

These benefits contribute to writing cleaner, more efficient, and maintainable code.

I know most would ask “how to implement feature x” - that indeed is often ripe with issues when you don’t understand the code handed to you.

justinmed · May 22, 2024, 7:21pm

OMG! Thank you for this suggestion! With the help of Muse I was able to prevent my MIDI from dying on scene change. It turned out to be something with buttons and suggested something along the lines of this but not exactly and I figured to put it over every buttons assignment to search for the named object in the scene and it worked! The chat bot is a lot nicer too! It is a piano sight reading learning improvement assistance application and I wanted to have modes where you can use the mouse, but I wanted those modes to be compatible with MIDI as well and the game modes consist of notes being displayed that correspond to a UI button keyboard on the screen that the player has to match the correct key to the note that is being displayed on the Staff for the score to go up and because with a mouse cursor you onlly have one input and it is 88 to 1 rather than just 88 to 88 switching I could not find any other way than to go over scenes rather than by an index within one scene. And it works fine, the user has no idea.

SceneManager.sceneLoaded += (arg0, mode) =>
        A1Button = GameObject.Find("A1Button").GetComponent<Button>();

Topic		Replies	Views
I need scripting advice Unity Engine Scripting	2	1219	August 19, 2009
Same script not working on subsequent scenes Unity Engine Scripting	21	4040	March 11, 2019
Midi launch Scene script help Unity Engine Scripting	1	753	September 29, 2019
Help needed on script Unity Engine Scripting	2	1011	May 9, 2013
Fade out and triggered load of next scene not working after update Unity Engine Scripting	3	778	August 12, 2017

For some reason the function of the script dies after one scene.

Related topics