Gun is not shooting? Please Help!

[micky2171]

My gun script for my multiplayer game does not work? is there something that i am doing wrong?
Code:
using UnityEngine;
using System.Collections;

public class Shoot : MonoBehaviour {
	
	public GameObject bullet_prefab;
	float bulletImpulse = 50f;
	float delay;
	
	// Use this for initialization
	void Start () {
		
	}
	
	// Update is called once per frame
	void FixedUpdate ()
	{
		if(Input.GetButtonDown("Fire1") && delay <= Time.time)
		{
			Camera cam = Camera.main;
			GameObject thebullet = (GameObject)Instantiate(bullet_prefab, cam.transform.position + cam.transform.forward, cam.transform.rotation);
			thebullet.rigidbody.AddForce(cam.transform.forward * bulletImpulse, ForceMode.Impulse);
			delay = Time.time + 1.0f; //change 1.0f to the delay you want
		}
	}
	
	void OnGUI(){
		GUI.Box(new Rect(Screen.width/2,Screen.height/2, 10, 10), "");
	}
}

Please Help!

Thanks,
Micky2171

EDIT:
UPDATED SCRIPT:

using UnityEngine;
using System.Collections;

public class Shoot : MonoBehaviour {
	
	public GameObject bullet_prefab;
	float bulletImpulse = 50f;
	float delay = 0	;
	
	// Use this for initialization
	void Start () {
		
	}
	
	// Update is called once per frame
	void FixedUpdate ()
	{
		if(Input.GetButtonDown("Fire1") && delay <= Time.time)
		{
			Camera cam = Camera.main;
			GameObject thebullet = Instantiate(bullet_prefab, cam.transform.position + cam.transform.forward, cam.transform.rotation);
			thebullet.rigidbody.AddForce(cam.transform.forward * bulletImpulse, ForceMode.Impulse);
			delay = Time.time + 1.0f; //change 1.0f to the delay you want
		}
	}
	
	void OnGUI(){
		GUI.Box(new Rect(Screen.width/2,Screen.height/2, 10, 10), "");
	}
}

[thomlaurent95]

For me the only thing wrong in your code is you don’t initialize your delay, so your script doesn’t go inside of your if statement because delay runs a random number that nobody knows in advance.

To fix it, just float delay = 0; at line 5

It should work now

[Nomabond]

Its generally a better idea to call the Input methods from the Update() method rather than the FixedUpdate(). Change your FixedUpdate() method to Update() and see if your gun fires.

I believe that Input is actually
broadcasted per-frame, so when the
FixedUpdate() is behind and needs to
catch up by firing multiple times, the
Input check will fail.

Edit: To include the modified script that I’ve tested and is working. You will want to work on destroying the instantiated objects though.

using UnityEngine;
   using System.Collections;

    public class Shoot : MonoBehaviour {

        public GameObject bullet_prefab;
        float bulletImpulse = 50f;
        float delay = 0;
        Camera cam;

        // Use this for initialization
        void Start () {
            cam = Camera.main;
        }

        // Update is called once per frame
        void Update ()
        {
            if(Input.GetButtonDown("Fire1") && delay <= Time.time)
            {

                GameObject thebullet = Instantiate(bullet_prefab, cam.transform.position + cam.transform.forward, cam.transform.rotation) as GameObject;
                thebullet.rigidbody.AddForce(cam.transform.forward * bulletImpulse, ForceMode.Impulse);
                delay = Time.time + 1.0f; //change 1.0f to the delay you want
            }
        }

        void OnGUI(){
            GUI.Box(new Rect(Screen.width/2,Screen.height/2, 10, 10), "");
        }
    }

Additional Resources:

What's the difference between Update and FixedUpdate? When are they called?

Is it really wrong to use Input.GetKey() on FixedUpdate?

[Addyarb]

My suggestion would be to take line 19 out and add it in the update function of a script attached to your bullet prefab.
Also, take (GameObject) out of the script on line 18.