using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class PlayerMovementScript : MonoBehaviour
{
public CharacterController controller;
public float speed = 12f;
// Update is called once per frame
void Update()
{
float x = Input.GetAxis("Horizontal");
float y = Input.GetAxis("Vertical");
Vector3 move = transform.right * x + transform.forward * z;
controller.Move(move * speed *Time.deltaTime);
}
}
Where do you think z is defined in your code? Eg, which line?
This just looks like a typo. You cannot have ANY typos whatsoever in coding.
Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:
How to do tutorials properly, two (2) simple steps to success:
Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That’s how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.
Fortunately this is the easiest part to get right: Be a robot. Don’t make any mistakes.
BE PERFECT IN EVERYTHING YOU DO HERE!!
If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.
Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.
Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.
Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there’s an error, you will NEVER be the first guy to find it.
Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!
Finally, when you have errors…
Remember: NOBODY here memorizes error codes. That’s not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.
The complete error message contains everything you need to know to fix the error yourself.
The important parts of the error message are:
- the description of the error itself (google this; you are NEVER the first one!)
- the file it occurred in (critical!)
- the line number and character position (the two numbers in parentheses)
- also possibly useful is the stack trace (all the lines of text in the lower console window)
Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.
All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don’t have to stop your progress and fiddle around with the forum.
its line 17
Not sure you linked the right tutorial, because nothing in that tutorial matches your code that I could see while skimming through it.
@Kurt-Dekker knows what line the error is on. And as he said, you most likely have a typo. But that being said, the error is very clear and Kurt’s very first line in his reply tells you what the error means.
If you’re getting stuck on this, I would suggest hitting up basic c# tutorials to help get you started. That should help you understand the most basic errors and hopefully give you a sense on how to troubleshoot them.
oh sorry that was a different video
https://www.youtube.com/watch?v=_QajrabyTJc
this si the right one and he put a z on the end and it works fine
No, that’s your use of the variable z that is causing the error.
I said specifically:
Where are you defining z ?
ngl to you i havent a clue in code i just watched the video copyed every move and it didnt work
btw skip to 12:55 on the 2nd video i sent thats where he put it
Then do what he does in the tutorial. I can see just by skimming the tutorial that you have not done what he did. Look at around 12:00 minutes in and you should see how your code is different.
no i actually did everything until the z error
Did you really? Because you didn’t. Babi somehow had the patience to rewatch a tutorial to find YOUR TYPO.
Hint: you did NOT declare a variable named z. You declared some other variables. Go look at them.
I’ll post a screencap of your code above and then it is entirely up to you:
The computer is RELENTLESS. It absolutely does not tolerate typos, not even one character.
Sorry, but no you didn’t. As proof, here is your line 15:
float y = Input.GetAxis("Vertical");
and here is the one from the tutorial:
Now tell me that you have done exactly what was in the tutorial again as you clearly have not.
wait what should i do?
As we are telling you, type it in exactly as it is in the tutorial. Don’t deviate from the code, don’t change the variable names, just type it in exactly as it is in the tutorial.
Go look at your variables again. You will see the difference if you keep staring at the letters. Babi even pointed it out for you. Go stare. However long it takes. It’s right in front of you and in my screenshot and in Babi’s post.
Then go back to the tutorial and start over with the two-step guide I posted above. So far today in six lines of typed code you have managed to make an error that has cost you eight hours of wasted time. That’s not a good strategy.
ok tysm
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class MouseLook : MonoBehaviour
{
public float mousespeed = 1000f;
public Transform playerbody;
float xRotation = 0f;
// Start is called before the first frame update
void Start()
{
Cursor.lockState = CursorLockMode.Locked;
}
// Update is called once per frame
void Update()
{
float mouseX = Input.GetAxis("Mouse X") * mousespeed * Time.deltaTime;
float mouseY = Input.GetAxis("Mouse Y") * mousespeed * Time.deltaTime;
xRotation -= mouseY;
xRotation = Mathf.Clamp(xRotation, -90f, 90f);
transform.localRotation = Quaternion.Euler(xRotation, 0f, 0f);
playerbody.Rotate(Vector3.up * mouseX);
}
}
You have duplicate scripts called MouseLook.
NEXT!
lol thanks