Help I get three errors with my code I get unexpected symbol for "foreach" and"}" and parsing error.

Unity Engine
1

voidStart ()
{

rig2d = GetComponent ();
anim = GetComponentInChildren ();

jmpForce = JumpForce;
GameObject[ ] players = GameObject.FindGameObjectsWithTag(“Player”)

foreach(GameObjectplinplayers)
{

if (pl.transform != this.transform)
{
enemy = pl.transform;
}
}
}

voidUpdate()
{
AttackInput();
ScaleCheck();
OnGroundCheck();
Damage();
UpdateAnimator();
}

//voidAttackInput()
// {
//if(Input.GetButtonDown(“Attack1” = PlayerNumber.ToString())
// }

voidOnGroundCheck()
{
if (!onGround)
{
rig2d.gravityScale = 5;
}
else
{
rig2d.gravityScale = 1;
}
}

voidFixedUpdate ()

{

horizontal = Input.GetAxis (“Horizontal” + PlayerNumber.ToString ());
vertical = Input.GetAxis(“Vertical” + PlayerNumber.ToString());

Vector3movement = newVector3(horizontal, 0, 0);

crouch = (vertical < -0.1f);

if (vertical > 0.1f)
{
if (!jumpKey)
{
jmpDuration += Time.deltaTime;
jmpForce += Time.deltaTime;

if (jmpDuration < jumpDuration)
{
rig2d.velocity = newVector2(rig2d.velocity.x, jmpForce);
}
else
{
jumpKey = true;
}
}
}

if(!onGround && vertical < 0.1f)
{
falling = true;
}

if(attack[0] && !jumpKey || attack[1] && !jumpKey)
{
movement = Vector3.zero;
}
if (!crouch)
rig2d.AddForce (movement * maxSpeed);
else
rig2d.velocity = Vector3.zero;
}

voidScaleCheck()
{
if(transform.position.x < enemy.position.x)
transform.localScale = newVector3(-1,1,1);
else
transform.localScale = Vector3.one;
}

voidAttackInput()
{
if(Input.GetButtonDown(“Attack1” + PlayerNumber.ToString()))
{
attack[0] = true;
attacktimer[0] = 0;
timesPressed[0] ++;
}

if(attack[0])
{
attacktimer[0] += Time.deltaTime;

if(attacktimer[0] > attackRate || timesPressed[0] >=4)
{
attacktimer[0] = 0;
attack[0] = false;
timesPressed [0] = 0;
}
}

if(Input.GetButtonDown(“Attack2” + PlayerNumber.ToString()))
{
attack[1] = true;
attacktimer[1] = 0;
timesPressed[1] ++;
}

if(attack[1])
{
attacktimer[1] += Time.deltaTime;

if(attacktimer[1] > attackRate || timesPressed[1] >=4)
{
attacktimer[1] = 0;
attack[1] = false;
timesPressed [1] = 0;
}
}
}

voidDamage()
{
{
noDamageTimer += Time.deltaTime;

if (noDamageTimer > noDamage)
{
damage = false;
noDamgaeTimer = 0;
}
}

//if(!onGround)
//{
//rig2d.gravityScale = 10;
//Vector3dir = enemy.position - transform.position;
//rig2d.AddForce(-dir * 25);
//}

}

voidUpdateAnimator()
{
anim.SetBool (“Crouch”, crouch);
anim.SetBool (“OnGround”, this.onGround);
anim.SetBool (“Falling”, this.falling);
anim.SetFloat (“Movement”, Mathf.Abs(horizontal));
anim.SetBool (“Attack1”, attack [0]);
anim.SetBool (“Attack2”, attack[1]);
}

voidOnCollisionEnter2D(Collision2Dcol)
{

if (col.collider.tag == “Ground”)
{
onGround = true;

jumpKey = false;
jmpDuration = 0;
jmpForce = JumpForce;
falling = false;
}

}

voidOnCollisionExit2D(Collision2Dcol)
{
if (col.collider.tag == “Ground”)
{
onGround = false;
}
}
}

2

If you could write it again using code tags we could help you.

3

Also just double click on the first error, and it will open the code editor to the line with the problem. give us just that line

4

you’re missing a ; … if you put the above in code tags we’ll tell you where :slight_smile: :stuck_out_tongue:

5

  1. As mentioned, use code tags

  2. Paste the text of the errors in. (You can copy from the console) I know it looks like gobbeldygook, but it is valuable information that can point us to right what needs to be fixed.

6

The semicolon is missing on line 8, before the ForEach loop:

GameObject[] players = GameObject.FindGameObjectsWithTag("Player");
7

I got help already heres the code in working order if you were curious.

using UnityEngine;
using System.Collections;

public class PlayerControl : MonoBehaviour
{
   
    public int PlayerNumber = 1;
    Transform enemy;
   
    Rigidbody2D rig2d;
    Animator anim;
   
    float horizontal;
    float vertical;
    public float maxSpeed = 25;
    Vector3 movement;
    bool crouch;
   
   
    public float JumpForce = 20;
    public float jumpDuration = .1f;
    float jmpDuration;
    float jmpForce;
    bool jumpKey;
    bool falling;
    bool onGround;
   
    public float attackRate = 0.3f;
    bool[] attack = new bool[2];
    float[] attacktimer = new float[2];
    int[] timesPressed = new int[2];
   
    public bool damage;
    public float noDamage = 1;
    float noDamageTimer;
   
    void Start ()
    {
       
        rig2d = GetComponent<Rigidbody2D> ();
        anim = GetComponentInChildren<Animator> ();
       
        jmpForce = JumpForce;
        GameObject[] players = GameObject.FindGameObjectsWithTag("Player");
       
       
        foreach(GameObject pl in players)
        {
           
            if (pl.transform != this.transform)
            {
                enemy = pl.transform;
            }
        }
    }
   
    void Update()
    {
        AttackInput();
        ScaleCheck();
        OnGroundCheck();
        Damage();
        UpdateAnimator();
    }
   
   
    void OnGroundCheck()
    {
        if (!onGround)
        {
            rig2d.gravityScale = 5;
        }
        else
        {
            rig2d.gravityScale = 1;
        }
    }
   
    void FixedUpdate ()
       
    {
       
        horizontal = Input.GetAxis ("Horizontal" + PlayerNumber.ToString ());
        vertical = Input.GetAxis("Vertical" + PlayerNumber.ToString());
       
        Vector3 movement = new Vector3(horizontal, 0, 0);
       
        crouch = (vertical < -0.1f);
       
        if (vertical > 0.1f)
        {
            if (!jumpKey)
            {
                jmpDuration += Time.deltaTime;
                jmpForce += Time.deltaTime;
               
                if (jmpDuration < jumpDuration)
                {
                    rig2d.velocity = new Vector2(rig2d.velocity.x, jmpForce);
                }
                else
                {
                    jumpKey = true;
                }
            }
        }
       
        if(!onGround && vertical < 0.1f)
        {
            falling = true;
        }
       
        if(attack[0] && !jumpKey || attack[1] && !jumpKey)
        {
            movement = Vector3.zero;
        }
        if (!crouch)
            rig2d.AddForce (movement * maxSpeed);
        else
            rig2d.velocity = Vector3.zero;
    }
   
    void ScaleCheck()
    {
        if(transform.position.x < enemy.position.x)
            transform.localScale = new Vector3(-1,1,1);
        else
            transform.localScale = Vector3.one;
    }
   
    void AttackInput()
    {
        if(Input.GetButtonDown("Attack1" + PlayerNumber.ToString()))
        {
            attack[0] = true;
            attacktimer[0] = 0;
            timesPressed[0] ++;
        }
       
        if(attack[0])
        {
            attacktimer[0] += Time.deltaTime;
           
            if(attacktimer[0] > attackRate || timesPressed[0] >=4)
            {
                attacktimer[0] = 0;
                attack[0] = false;
                timesPressed [0] = 0;
            }
        }
       
       
        if(Input.GetButtonDown("Attack2" + PlayerNumber.ToString()))
        {
            attack[1] = true;
            attacktimer[1] = 0;
            timesPressed[1] ++;
        }
       
        if(attack[1])
        {
            attacktimer[1] += Time.deltaTime;
           
            if(attacktimer[1] > attackRate || timesPressed[1] >=4)
            {
                attacktimer[1] = 0;
                attack[1] = false;
                timesPressed [1] = 0;
            }
        }
    }
   
    void Damage()
    {
        {
            noDamageTimer += Time.deltaTime;
           
            if (noDamageTimer > noDamage)
            {
                damage = false;
                noDamageTimer = 0;
            }
        }
       
        // if(!onGround)
        //{
        //rig2d.gravityScale = 10;
        //Vector3 dir = enemy.position - transform.position;
        //rig2d.AddForce(-dir * 25);
        //}
       
    }
   
   
    void UpdateAnimator()
    {
        anim.SetBool ("Crouch", crouch);
        anim.SetBool ("OnGround", this.onGround);
        anim.SetBool ("Falling", this.falling);
        anim.SetFloat ("Movement", Mathf.Abs(horizontal));
        anim.SetBool ("Attack1", attack [0]);
        anim.SetBool ("Attack2", attack[1]);
    }
   
    void OnCollisionEnter2D(Collision2D col)
    {
       
        if (col.collider.tag == "Ground")
        {
            onGround = true;
           
            jumpKey = false;
            jmpDuration = 0;
            jmpForce = JumpForce;
            falling = false;
        }
       
    }
   
    void OnCollisionExit2D(Collision2D col)
    {
        if (col.collider.tag == "Ground")
        {
            onGround = false;
        }
    }
}