Help OnCollisionScript Not Working C#

Unity Engine
1

Hey I have a script that’s supposed to damage a Npc but it does’nt work.

public class WoodSwordLL : MonoBehaviour
{
    public GameObject OrcOrc;
    private OrcHealth Orc;
    void Start ()
    {
        Orc = OrcOrc.GetComponent<OrcHealth>();
    }
    void OnCollisionEnter (Collision Col)
    {
        if(Col.gameObject.name == "Icon");
        {
            Debug.Log("Hit Orc");
            Orc.HpOrc = Orc.HpOrc - 1;
        }
    }
}

I also made another script But it works I can’t find how to get it to work any ideas?

public class AxeHit : MonoBehaviour
{
    public GameObject CharChar;
    private CharMain Char;
    void Start ()
    {
        Char = CharChar.GetComponent<CharMain>();
    }
    void OnCollisionEnter (Collision Col)
    {
        if(Col.gameObject.name == "IconChar");
        {
            Char.HpChar = Char.HpChar - 1;
        }
    }
}
2

I think you posted the same thing earlier this evening. The trouble is that you’re not helping us to help you much. “It doesn’t work” doesn’t tell us much. How does it not work? Does an error appear? Does your Debug.Log message appear? Have you tried stepping through it in the debugger?

Taking some guesses as to the probable answers, my next guess would be that you don’t have your colliders set up properly. Remember that for collision events to fire, you need at least one of the objects involved to have a non-kinematic Rigidbody attached. Also check your collision masks, ensure that neither is set to be a trigger, etc.

3

Thanks you fixed the problem I didn’t have a rigid-body connected to the Icon

4

I spoke a bit too soon, I added the rigid-body to the icon still same result but when I also added it to the sword it had a weird result where every step I took damaged the opponent and came up with the error result.

NullReferenceException: Object reference not set to an instance of an object
WoodSwordl.OnCollisionEnter (UnityEngine.Collision Col) (at Assets/WoodSwordl.cs:17)\

And I don’t know what is wrong with line 17.

Any Help Would Be Appreciated.

5

I figured out the error report but it still damages every step

6

Here is a video of what is happening

Hope You Can Help