Help with code

Unity Engine
1

I am trying to make it so i take damage when i touch some thing with tag “zombie”. Why no work?

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class damage2 : MonoBehaviour
{
public int maxHealth = 100;
public int currentHealth;
public int damage = 10;
public HealthBar healthBar;
// Start is called before the first frame update
void Start()
{
currentHealth = maxHealth;
healthBar.SetMaxHealth(maxHealth);
}
// Update is called once per frame
private void Update()
{

}
void OnCollisionEnter2D(Collision2D col)
{
if (col.gameObject.tag.Equals(“A”))
{
TakeDamage(10);
}
void TakeDamage(int damage)
{
currentHealth = currentHealth - damage;
healthBar.SetHealth(currentHealth);
}
}
}

2

You have now posted this so many times I have lost track.

What is often happening in these cases is one of the following:

  • the code you think is executing is not actually executing at all
  • the code is executing far EARLIER or LATER than you think
  • the code is executing far LESS OFTEN than you think
  • the code is executing far MORE OFTEN than you think
  • the code is executing on another GameObject than you think it is

To help gain more insight into your problem, I recommend liberally sprinkling Debug.Log() statements through your code to display information in realtime.

Doing this should help you answer these types of questions:

  • is this code even running? which parts are running? how often does it run? what order does it run in?
  • what are the values of the variables involved? Are they initialized? Are the values reasonable?
  • are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

Knowing this information will help you reason about the behavior you are seeing.

You can also put in Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene

You could also just display various important quantities in UI Text elements to watch them change as you play the game.

If you are running a mobile device you can also view the console output. Google for how on your particular mobile target.

Here’s an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

3

If I had written this so many times, why is this the first time you had actually replied?

4

What have you found by debugging like I suggested above?

If you post a code snippet, ALWAYS USE CODE TAGS:

How to use code tags: Using code tags properly

5

Well, that’s not actually the tag you’re checking for:

if (col.gameObject.tag.Equals("A"))
6

Do not spam duplicate topics.

–Eric