Help with OnTriggerEnter2D

Unity Engine
1

I have an OnTriggTrenter2D function with two if statements which compares the tag of a trail and power-ups.
But the thing is no matter which trail I collide with ,my player dies and the speed bosst powerup doesnt increase the move speed too. Even if i hit the power up it kills the player.
Pls help…

void OnTriggerEnter2D(Collider2D col)
    {
      

        if (!col.CompareTag("Trail"+playerno))
            {
            CurrentHealth = 0;
            OnDeath();
            Debug.Log("HIT");
            }

        else if(col.CompareTag("SpeedBoost"))
            {
           

            PlayerMovement.maxSpeed = PlayerMovement.maxSpeed + 4;
            //PlayerMovement is another script and maxspeed is a public static float variable.


            }

 
else if (col.CompareTag("Trail"+playerno))
            {
            Debug.Log("NO HIT");
            }


void OnDeath()
    {

        Dead = true;

 
        DeathParticles.transform.rotation = transform.rotation;
        DeathParticles.transform.position = transform.position;
        DeathParticles.gameObject.SetActive(true);

        DeathParticles.Play();

        gameObject.SetActive(false);

    }
2

Just to clarify, if they hit the trail they are supposed to die or no?

You have a statement that says if it’s not a trail, set health to zero and die. (first one).

3

it says that,
if it is not the trail of the same player then die…if its the same player print no hit.

4

Okay… I’m not sure why the trail won’t avoid itself - you want to check that the tag is correct.
You could also make the player’s trail ignore itself , using: Unity - Scripting API: Physics2D.IgnoreCollision

I am certain, however, that the reason you won’t get the power up is because of that “if it’s not this trail, then do death”.

5

but I have an if statement for the power up too… Will try ignoring collision.

6

Yes, and though it’s a small mystery as to why it doesn’t ignore the player’s own self, your statements would still be saying this:

  • If it’s not my trail, then do death. (this can include if it’s a powerup, because a power up is not your trail*)
  • otherwise (meaning, if it was my trail), and if it’s a power up (will never get here)
7

so should I say…
If its not my trail && not a powerup
Then do death.
Else if its a powerup do speedboost.
Else if its my trail ignore collision.

Thanks for your response btw…

8

Well, the very last one is a scratch (no need to even have it…) if you don’t ask for anything to happen, nothing will :slight_smile:

As for the first part, that sounds reasonable. You still have to find your bug with the tag, though.
An alternative, which is often good anyways , is if you have any script that is reliably attached to every trail game object, you could look for that component.

Imaginary code:

TrailScript ts = col.GetComponent<TrailScript>();
if(ts != null) {
       // just making this up, but ...
   if(ts.ownerGameObject != gameObject) {
       // death.
    }
}
else if(col.CompareTag("Power Up")) {
  // boost speed
  }

I’m not saying you have to add that, or that is the best idea… I just wrote it out as an example in case you think it’s something you could use…
I believe GetComponent is often superior to checking tags; however, tags are just sometimes more convenient (and often shown in quick examples, too) . :slight_smile: