how do i fix this health bar?

Unity Engine
1

public int Respawn;
public int maxHealth = 100;
public int currentHealth;

public HealthBar healthBar;

// Start is called before the first frame update
void Start()
{
currentHealth = maxHealth;
healthBar.SetMaxHealth(maxHealth);
}

void TakeDamage(int damage)
{
currentHealth -= damage;

healthBar.SetHealth(currentHealth);
}

void OnTriggerEnter2D(Collider2D other)
{
if(other.CompareTag(“Player”))
{
if(currentHealth = 0)
{
SceneManager.LoadScene(Respawn);
}

if(currentHealth > 0)
{
TakeDamage(15);
}
}
}
}

2

Well, first you should explain what is happening to it.
But I will try to answer anyway.

This line is probably wrong:
if(currentHealth = 0)
The operator for equal is not =. It is ==.
So that shouldn’t even compile.

Another thing:
You seem to start at 100HP and lose 15HP at a time, which means you will never have exactly 0HP, you will eventually have 10, and then -5, then -20 and so on. But that may be taken care of inside TakeDamage by setting the value to 0 if it reaches negative values.

In any case, to be in the safe side, I would change it to:
if(currentHealth <= 0)

1 Like
3

First, start with any one of the 2.7 million youtube tutorials on health bars. It’s SO simple it’s not even remotely worth someone here retyping.

If you post a code snippet, ALWAYS USE CODE TAGS:

How to use code tags: Using code tags properly

How to report your problem productively in the Unity3D forums:

http://plbm.com/?p=220

How to understand compiler and other errors and even fix them yourself:

If you want to debug any code you have, this will help:

What is often happening in these cases is one of the following:

  • the code you think is executing is not actually executing at all
  • the code is executing far EARLIER or LATER than you think
  • the code is executing far LESS OFTEN than you think
  • the code is executing far MORE OFTEN than you think
  • the code is executing on another GameObject than you think it is

To help gain more insight into your problem, I recommend liberally sprinkling Debug.Log() statements through your code to display information in realtime.

Doing this should help you answer these types of questions:

  • is this code even running? which parts are running? how often does it run? what order does it run in?
  • what are the values of the variables involved? Are they initialized? Are the values reasonable?
  • are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

Knowing this information will help you reason about the behavior you are seeing.

You can also put in Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene

You could also just display various important quantities in UI Text elements to watch them change as you play the game.

If you are running a mobile device you can also view the console output. Google for how on your particular mobile target.

Here’s an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong: