How do I make a High Score?

Unity Engine
1

I’m making a survival shooter game, and I’m trying to make it so when I kill an enemy and add points to my score, its added to the high score and it saves after each play. I have the script to add score, but I don’t think I’m doing high score right. I want the normal score to count up on the screen, and the high score to count up with it on another part of the screen, and when I stop the game and play again, the high score is still up on the screen. But when I play, the high score text replaces the score text, and it doesn’t even count up when I kill an enemy. Could someone help me with this please?

public class ScoreManager : MonoBehaviour
{
public static int score;
public static int highScore;

Text scoreText;
Text highScoreText;

void Awake ()
{
   scoreText = GetComponent <Text> ();
   highScoreText = GetComponent<Text>();
   score = 0;
   highScore = 0;

   highScoreText.text = PlayerPrefs.GetInt("High Score", 0).ToString();
}
void Update ()
{
   scoreText.text = "Score: " + score;
   highScoreText.text = "High Score: " + highScore;
   if(score>PlayerPrefs.GetInt("High Score", 0))
   {
       PlayerPrefs.SetInt("High Score", score);
       highScoreText.text = score.ToString();
   }
}
}

Here’s the enemy health script for adding to score when enemy dies. It’s in the enemySinking function.

public class EnemyHealth : MonoBehaviour
{
public int startingHealth = 100;
public int currentHealth;
public float sinkSpeed = 2.5f;
public int scoreValue = 10;
public AudioClip deathClip;


Animator anim;
AudioSource enemyAudio;
ParticleSystem hitParticles;
CapsuleCollider capsuleCollider;
bool isDead;
bool isSinking;


void Awake ()
{
   anim = GetComponent <Animator> ();
   enemyAudio = GetComponent <AudioSource> ();
   hitParticles = GetComponentInChildren <ParticleSystem> ();
   capsuleCollider = GetComponent <CapsuleCollider> ();

   currentHealth = startingHealth;
}


void Update ()
{
   if(isSinking)
   {
       transform.Translate (-Vector3.up * sinkSpeed * Time.deltaTime);
   }
}


public void TakeDamage (int amount, Vector3 hitPoint)
{
   if(isDead)
       return;

   enemyAudio.Play ();

   currentHealth -= amount;

   hitParticles.transform.position = hitPoint;
   hitParticles.Play();

   if(currentHealth <= 0)
   {
       Death ();
   }
}


void Death ()
{
   isDead = true;

   capsuleCollider.isTrigger = true;

   anim.SetTrigger ("Dead");

   enemyAudio.clip = deathClip;
   enemyAudio.Play ();
}


public void StartSinking ()
{
   GetComponent <UnityEngine.AI.NavMeshAgent> ().enabled = false;
   GetComponent <Rigidbody> ().isKinematic = true;
   isSinking = true;
   ScoreManager.score += scoreValue;
   Destroy (gameObject, 2f);
}
2

I had a (bad) joke when I first read your thread title…
You make a high score by beating all of the other scores!! :slight_smile:

Okay, done with that… So, one thing I noticed was that you’re doing: scoreText and highScoreText both equal to GetComponent()
That isn’t good. If you can assign them in the inspector, that would be better.
Keeping the variables private, you can add the attribute [SerializeField] above the 2 Text variables and save your script. When you go back to Unity, you should see them there and you can drag n drop the text.

That’s part one. Next, I would suggest that you turn the dealing damage into a method. That way, you can increment the score, check if it’s a high score, and display the text… and you can avoid the needless calls to Update(). That would be a lot more efficient.

Let me know how that goes/if ya like it… :slight_smile:

3

Ok, here’s what I tried, it gave me a high score, but it won’t change. I get 60, but when I go over that score, it stays 60 when i play again.

public class HighScoreManager : MonoBehaviour
{

    public static int highScore;
    Text text;


    void Awake()
    {
        text = GetComponent<Text>();
    }


    void Update()
    {
        text.text = "High Score: " + PlayerPrefs.GetInt("HighScore");
    }
}



public class ScoreManager : MonoBehaviour
{
    public static int score;   
    Text text;     


    void Awake()
    {
        text = GetComponent<Text>();
        score = 0;
    }

    void Update()
    {
        text.text = "Score: " + score;
        if (PlayerPrefs.GetInt("High Score") < score)
        {
            PlayerPrefs.SetInt("High Score", score);
        }
    }
}



public void StartSinking ()
    {
        GetComponent <UnityEngine.AI.NavMeshAgent> ().enabled = false;
        GetComponent <Rigidbody> ().isKinematic = true;
        isSinking = true;
        ScoreManager.score += scoreValue;
        HighScoreManager.highScore += scoreValue;
        Destroy (gameObject, 2f);
    }
4

Okay, well you didn’t have to make 2 separate scripts, but nevertheless…

So you have an issue with your PlayerPrefs key. You are not calling it the same “High Score” vs “HighScore”

5

Ok, I got it. Thanks