How do you get the x and y coordinates of a gameobject hit by a raycast (C#)?

2D
1

I have my attacking system set up so that the player attacks the enemy by clicking on them. Currently the raycast has no limits on it so i added a check to see if the target was 1 square above, below, left or right of the player. When the player attacks the enemy however it returns this error: NullReferenceException: Object reference not set to an instance of an object.

private void attackEnemy()
        {
            bool adjacent = false;
            Vector3 mousePos = Input.mousePosition;
            mousePos.z = 0;
            Vector3 screenPos = Camera.main.ScreenToWorldPoint(mousePos);
            //send out a raycast to check to see if the tile clicked has an enemy
            RaycastHit2D hit = Physics2D.Raycast(screenPos, Vector2.zero);
            //check to see if the raycast hit an enemy
            if ((hit) && hit.transform.tag == "Enemy")
            {
                float targetX = GameObject.Find(hit.collider.gameObject.name).transform.position.x;    //error starts on this line
                float targetY = GameObject.Find(hit.collider.gameObject.name).transform.position.y;
                float currentX = GameObject.Find("player").transform.position.x;
                float currentY = GameObject.Find("player").transform.position.y;

                if (Math.Round(targetX, 0) == Math.Round(currentX, 0))
                {
                    if (Math.Round(targetY, 0) == Math.Round(currentY +- 1, 0))
                    {
                        //checks to see if the traget is 1 tile above or below
                        adjacent = true;
                    }
                    else
                    { adjacent = false; print("miss"); }
                }
                else
                {
                    if (Math.Round(targetY, 0) == Math.Round(currentY, 0))
                    {
                        if (Math.Round(targetX, 0) == Math.Round(currentX +- 1, 0))
                        {
                            //check to see if the target is 1 tile to the left or right
                            adjacent = true;
                        }
                        else
                        { adjacent = false; print("miss"); }
                    }
                }
            }
        }

Is there a substitute for hit.collider.gameObject.name that I can use for GameObject.Find that will return x and y coordinates seperetly or another method that will return the same results?

2

First, Physics2D.Raycast will never return null, so checking if(hit) will always return true. You really need to check if hit.collider != null to find if you’ve actually got a hit. Secondly, you don’t need GameObject.Find as you already have the reference stored in the hit variable. This line;
float targetX = GameObject.Find(hit.collider.gameObject.name).transform.position.x; could be replaced with… float targetX = hit.collider.transform.position.x Third, it’s generally bad practice to repeatedly call GameObject.Find. Create a class level GameObject variable called player and either call GameObject.Find(“player”) in the Start method, or (better yet) make it public and drag and drop your player in the inspector. Then in your attackEnemy method, you can simply say

float currentX = player.transform.position.x;
float currentY = player.transform.position.y
3

FYI: The RaycastHit2D struct has an implicit bool operator to save you checking if the RaycastHit2D.collider is NULL or not.

1 Like
4

It seems to be working but there are a few other bugs i need to work out before I can tell for sure I will get back to you later

5

It worked thank you