How to make 2 Stage 'Fall Damage' System ? (SOLVED)

Unity Engine
1

I have a system in place that allows my player (FPS Controller) to take health damage if it falls more than a certain distance. I’m trying to make it into a 2 stage system where a higher fall would result in greater health loss.
Basic script-

#pragma strict

var lastPositionY : float = 0f;
var fallDistance : float = 0f;
var player : Transform;

private var controller : CharacterController;

var currentHealth : float = 100.0f;

function Start()
{
    controller = GameObject.Find("First Person Controller").GetComponent(CharacterController);
}
   
function Update ()
{  
    if(lastPositionY > player.transform.position.y)
    {
        fallDistance += lastPositionY - player.transform.position.y;
    }
  
    lastPositionY = player.transform.position.y;
  
    if(fallDistance >= 5 && controller.isGrounded)
    {
        currentHealth -= 20;
        ApplyNormal();
    }
       
    if(fallDistance <= 5 && controller.isGrounded)
    {
        ApplyNormal();
    }
}

function ApplyNormal()
{
        fallDistance = 0;
        lastPositionY = 0;
}

function OnGUI()
{
    GUI.Box(Rect(10, 20, 50, 20),"" + currentHealth);
}

This works fine as it is. I changed the script by adding an additional IF statement so as any fall greater than 10 would result in greater health loss BUT the script only recognises the first IF statement (any fall >=5) and not the second.

revamp script-

#pragma strict

var lastPositionY : float = 0f;
var fallDistance : float = 0f;
var player : Transform;

private var controller : CharacterController;

var currentHealth : float = 100.0f;

function Start()
{
    controller = GameObject.Find("First Person Controller").GetComponent(CharacterController);
}
   
function Update ()
{  
    if(lastPositionY > player.transform.position.y)
    {
        fallDistance += lastPositionY - player.transform.position.y;
    }
  
    lastPositionY = player.transform.position.y;
  
    if(fallDistance >= 5 && controller.isGrounded)
    {
        currentHealth -= 20;
        ApplyNormal();
    }
  
    if(fallDistance >= 10 && controller.isGrounded)
    {
        currentHealth -= 50;
        ApplyNormal();
    }
   
    if(fallDistance <= 5 && controller.isGrounded)
    {
        ApplyNormal();
    }
}

function ApplyNormal()
{
        fallDistance = 0;
        lastPositionY = 0;
}

function OnGUI()
{
    GUI.Box(Rect(10, 20, 50, 20),"" + currentHealth);
}

Any suggestions guys ?

2

Solved it myself :slight_smile:

Why I didn’t think to swap the IF statements around so as the first condition is the higher then if that condition wasn’t met a simple ‘else’ statement allowed the script to check IF the second condition was met.

here is the working script-

#pragma strict

var lastPositionY : float = 0f;
var fallDistance : float = 0f;
var player : Transform;

private var controller : CharacterController;

var currentHealth : float = 100.0f;

function Start()
{
    controller = GameObject.Find("First Person Controller").GetComponent(CharacterController);
}
    
function Update ()
{   
    if(lastPositionY > player.transform.position.y)
    {
        fallDistance += lastPositionY - player.transform.position.y;
    }
   
    lastPositionY = player.transform.position.y;
   
    if(fallDistance >= 10 && controller.isGrounded)
    {
        currentHealth -= 50;
        ApplyNormal();
    }
   
    else
   
    if(fallDistance >= 5 && controller.isGrounded)
    {
        currentHealth -= 20;
        ApplyNormal();
    }
      
    if(fallDistance <= 5 && controller.isGrounded)
    {
        ApplyNormal();
    }
}

function ApplyNormal()
{
        fallDistance = 0;
        lastPositionY = 0;
}

function OnGUI()
{
    GUI.Box(Rect(10, 20, 50, 20),"" + currentHealth);
}

(hopefully anybody else having similar issues may find this helpful)

:wink:

3

Do it backwards. Check the greater then 10 first, then the greater then 5.

You can also check velocity. Velocity is directly related to distance.

1 Like
4

Yeah, swapping them round worked. Thanks for the reply though anyway :slight_smile:

5

Sniped by the OP. I was about three seconds behind your post :slight_smile:

1 Like