How To Stop Uncrouching Under Object

[brygonnn]

Every time that I crouch and stand up under an object I phase through it, does anyone have a solution? I have posted about this and haven’t been able to find a solution yet.
I don’t use rigid body so here’s the code

public class PlayerMotor : MonoBehaviour
{

    private CharacterController controller;
    private Vector3 playerVelocity;
    public float speed = 2f;
    private bool isGrounded;
    public float gravity = -9.8f;
    bool lerpCrouch = false;
    bool crouching = false;
    bool sprinting = false;
    float crouchTimer;

    void Start()
    {
        controller = GetComponent<CharacterController>();
    }

    void Update()
    {
        isGrounded = controller.isGrounded;
        if (lerpCrouch)
        {
            crouchTimer += Time.deltaTime;
            float p = crouchTimer / 1;
            p *= p;
            if (crouching)
                controller.height = Mathf.Lerp(controller.height, 1, p);
            else
                controller.height = Mathf.Lerp(controller.height, 2, p);

            if (p > 1)
            {
                lerpCrouch = false;
                crouchTimer = 0f;
            }
        }
    }
    public void Crouch()
    {
        crouching = !crouching;
        crouchTimer = 0;
        lerpCrouch = true;
        if (crouching && sprinting)
            speed = 1;
        if (crouching)
            speed = 1;
        else
            speed = 2;
    }
    public void Sprint()
    {
        sprinting = !sprinting;
        if (sprinting)
            speed = 4;
        else
            speed = 2;
        if (crouching && sprinting)
            speed = 1;
    }
    public void ProcessMove(Vector2 input)
    {
        Vector3 moveDirection = Vector3.zero;
        moveDirection.x = input.x;
        moveDirection.z = input.y;
        controller.Move(transform.TransformDirection(moveDirection) * speed * Time.deltaTime);
        playerVelocity.y += gravity * Time.deltaTime;
        if (isGrounded && playerVelocity.y < 0)
            playerVelocity.y = -2f;
        controller.Move(playerVelocity * Time.deltaTime);
        Debug.Log(playerVelocity.y);
    }
}

There is no standing option, only a camera position as well as a crouching action. As a previous user mentioned, using ray cast should have done the trick but it didn’t work. This has halted my progress for months and hope someone knows how to help. Thank you.
(I want to point out that I’m new to coding and suck at it, so I used a tutorial)

[Kurt-Dekker]

@brygonnn

As a previous user mentioned, using ray cast should have done the trick but it didn’t work.

Time to start debugging! If you can’t tell, nobody here can either.

If you don’t want to fix your code, grab the controller at the bottom of this message. I just verified it crouches AND does not allow full standing if you’re under a ledge and crouching.

Here is how you can begin your exciting new debugging adventures:

You must find a way to get the information you need in order to reason about what the problem is.

Once you understand what the problem is, you may begin to reason about a solution to the problem.

What is often happening in these cases is one of the following:

• the code you think is executing is not actually executing at all
• the code is executing far EARLIER or LATER than you think
• the code is executing far LESS OFTEN than you think
• the code is executing far MORE OFTEN than you think
• the code is executing on another GameObject than you think it is
• you’re getting an error or warning and you haven’t noticed it in the console window

To help gain more insight into your problem, I recommend liberally sprinkling Debug.Log() statements through your code to display information in realtime.

Doing this should help you answer these types of questions:

• is this code even running? which parts are running? how often does it run? what order does it run in?
• what are the names of the GameObjects or Components involved?
• what are the values of the variables involved? Are they initialized? Are the values reasonable?
• are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

Knowing this information will help you reason about the behavior you are seeing.

You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as Debug.Log("Problem!",this);

If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

You could also just display various important quantities in UI Text elements to watch them change as you play the game.

Visit Google for how to see console output from builds. If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer for iOS: https://discussions.unity.com/t/700551 or this answer for Android: https://discussions.unity.com/t/699654

If you are working in VR, it might be useful to make your on onscreen log output, or integrate one from the asset store, so you can see what is happening as you operate your software.

Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

If your problem is with OnCollision-type functions, print the name of what is passed in!

Here’s an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

https://discussions.unity.com/t/839300/3

“When in doubt, print it out!™” - Kurt Dekker (and many others)

Note: the print() function is an alias for Debug.Log() provided by the MonoBehaviour class.

Otherwise, if you just want a basic FPS controller that has a crouch and the crouch won’t stand up when there’s something overhead, here’s one:

https://discussions.unity.com/t/855344

That one has run, walk, jump, slide, crouch… it’s crazy-nutty!!

For future reference…

How to report your problem productively in the Unity3D forums:

http://plbm.com/?p=220

This is the bare minimum of information to report:

• what you want
• what you tried
• what you expected to happen
• what actually happened, log output, variable values, and especially any errors you see
• links to documentation you used to cross-check your work (CRITICAL!!!)

The purpose of YOU providing links is to make our job easier, while simultaneously showing us that you actually put effort into the process. If you haven’t put effort into finding the documentation, why should we bother putting effort into replying?

[wideeyenow_unity]

I assume someone mentioned if you raycast from root position(ground/center of player) up, when “trying” to stand back up, the raycast should see the static layer of map, and determine that the height is not high enough to stand, therefor cancelling the stand up action. Which is one way of doing it, yes.

Another way would be have your character collider shrink in height(same as player crouching height), and when trying to “stand up” the collision would check if it hits the static layer of the play map and cancel said “standing up” and continue crouched.

But yeah, if you force a collider into another one, it will clip, and either get stuck, or fall through the map.

[Kurt-Dekker]

Whoops, just looked at your code. Unfortunately it calls .Move() twice per frame. That will cause all manner of issues.

This must be taken from that annoyingly defective tutorial that comes up so much. I wish I could find that and have it taken down. Here’s why:

CharacterController CharMover broken:

I wrote about this before: the Unity example code in the API no longer jumps reliably.

If you call .Move() twice in one single frame, the grounded check may fail.

I reported it to Unity via their docs feedback in October 2020. Apparently it is still broken:

Unity - Scripting API: CharacterController.Move

Here is a work-around:

How to correctly setup 3d Character Movement in Unity?

Welcome! First, please use code tags: Using code tags properly when you post code. But secondly, what is weird is that this is the second time recently that I’ve seen this code reported broken. I went and investigated and what appears to have happened is that Unity’s example used to work back on earlier versions of Unity. BUT… on more recent Unity versions, I concur with you that it presently does NOT work reliably, at least for jumping. If I had to guess why, I believe it is their two sepa…

I recommend you also go to that same documentation page and ALSO report that the code is broken.

When you report it, you are welcome to link the above workaround. One day the docs might get fixed.

If you would prefer something more full-featured here is a super-basic starter prototype FPS based on Character Controller (BasicFPCC):

A Basic First Person Character Controller for prototyping

https://www.youtube.com/watch?v=t0oN-PFXZEM Gist Link After some interest in an old post here , I spent the weekend frankensteining snippets of code to make a single script FPCC that could be used like the FPCC from Unity 4~5, including the crouch and run from Aldo, and I also added farcry sliding. There is a Menu Item function to easily create and configure a new FPCC object. Otherwise very easy to set up, it only requires a layer to exclude itself from sphere/raycasts. There is a check to …

That one has run, walk, jump, slide, crouch… it’s crazy-nutty!!

[brygonnn]

@Kurt-Dekker

Whoops, just looked at your code. Unfortunately it calls .Move() twice per frame. That will cause all manner of issues.

This must be taken from that annoyingly defective tutorial that comes up so much. I wish I could find that and have it taken down. Here’s why:

CharacterController CharMover broken:

I wrote about this before: the Unity example code in the API no longer jumps reliably.

If you call .Move() twice in one single frame, the grounded check may fail.

I reported it to Unity via their docs feedback in October 2020. Apparently it is still broken:

Unity - Scripting API: CharacterController.Move

Here is a work-around:

How to correctly setup 3d Character Movement in Unity?

I recommend you also go to that same documentation page and ALSO report that the code is broken.

When you report it, you are welcome to link the above workaround. One day the docs might get fixed.

If you would prefer something more full-featured here is a super-basic starter prototype FPS based on Character Controller (BasicFPCC):

A Basic First Person Character Controller for prototyping

That one has run, walk, jump, slide, crouch… it’s crazy-nutty!!

So I understand what you mean here, but since I really don’t understand unity 100%, how do you think I should redo this part to make sure that I don’t call .Move() twice without breaking my code?

[Kurt-Dekker]

@brygonnn

how do you think I should redo this part

So you didn’t look at the link where I showed you EXACTLY how to redo the script???

I’ll wait.

Or you’re welcome to just use the other script.

I am just not going to keep re-solving the same problem I’ve already solved twice in my post above.

[brygonnn]

@wideeyenow_unity

I assume someone mentioned if you raycast from root position(ground/center of player) up, when “trying” to stand back up, the raycast should see the static layer of map, and determine that the height is not high enough to stand, therefor cancelling the stand up action. Which is one way of doing it, yes.

Another way would be have your character collider shrink in height(same as player crouching height), and when trying to “stand up” the collision would check if it hits the static layer of the play map and cancel said “standing up” and continue crouched.

But yeah, if you force a collider into another one, it will clip, and either get stuck, or fall through the map.

I have tried as someone has tried telling me the same thing but it didn’t work, here’s what they gave me, and I did try to modify both codes given to me to no success.

Standing Up While Crouching

Hey @brygonnn, There are a few different ways to do this - considering you’re not using a RigidBody the simplest (imo) is to use a Raycast above the player. Some code; // Option A if(Input.GetKeyDown(KeyCode.Space)) if (!Physics.Raycast(transform.position, Vector3.up, 3f)) Jump() / Stand(); // Option B if (Input.GetKeyDown(KeyCode.Space)) { bool _isOverHead = Physics.Raycast(transform.position, Vector3.up, 3f); if (!_isOverHead) Jump() / Stand(); } Gave two diffe…

[brygonnn]

@Kurt-Dekker

So you didn’t look at the link where I showed you EXACTLY how to redo the script???

I’ll wait.

Or you’re welcome to just use the other script.

I am just not going to keep re-solving the same problem I’ve already solved twice in my post above.

Maybe I clicked on a link twice, my apologies, I’ll check right now

[wideeyenow_unity]

@brygonnn

I have tried as someone has tried telling me the same thing

Well to be fair, that raycast doesn’t have any checks for layers, so it would probably hit the player collider and immediately be false. But you want it to look for whatever layer you have the playMap, or other objects set to for collisions so player doesn’t stand through them.

Raycasts are fun, a little performance heavy(in my opinion), but they do work great. The only thing is you gotta keep playing with them. Always set your “start” and “direction” variables, so you can also use Debug.DrawLine(). So you can physically see them(with gizmos on(Scene View)) and correctly set directions or length of the ray.

But as DrawLine says, Debug! Keep messing with values, and print out collision hits, so you know exactly what it’s doing and why.

For sure you want some kind of check in place, if character crouched, crawling through a crawl space, you don’t want him standing. But just keep at it, the more you learn raycasts the more ideas of crazy things you can do with them!

[brygonnn]

@wideeyenow_unity

Well to be fair, that raycast doesn’t have any checks for layers, so it would probably hit the player collider and immediately be false. But you want it to look for whatever layer you have the playMap, or other objects set to for collisions so player doesn’t stand through them.

Raycasts are fun, a little performance heavy(in my opinion), but they do work great. The only thing is you gotta keep playing with them. Always set your “start” and “direction” variables, so you can also use Debug.DrawLine(). So you can physically see them(with gizmos on(Scene View)) and correctly set directions or length of the ray.

But as DrawLine says, Debug! Keep messing with values, and print out collision hits, so you know exactly what it’s doing and why.

For sure you want some kind of check in place, if character crouched, crawling through a crawl space, you don’t want him standing. But just keep at it, the more you learn raycasts the more ideas of crazy things you can do with them!

I get what you’re saying, I’ll let you know what I come up with, but before I start, how can I make a debug check for layers? Thanks.

[wideeyenow_unity]

I don’t know why this snippet is in my old notes, lol, the use functions are more caveman than I!

public class RaycastTest : MonoBehaviour {
float lenthRay = 10.0f;
Vector3 originePos;
Vector3 dir;
RaycastHit hitinfo;
GameObject hitten;
bool isHitting;
Color beforC;
int selectionLayer = 9;

void Update () {
    originePos = Camera.main.transform.position;
    dir = Camera.main.transform.forward * lenthRay;
    Debug.DrawRay(originePos, dir, Color.blue);

    if (Physics.Raycast(originePos, dir, out hitinfo, lenthRay , selectionLayer)) {
        hitten = hitinfo.transform.gameObject;
        MeshRenderer tmp = hitten.transform.GetComponent<MeshRenderer>();
        beforC = tmp.material.color;
        tmp.material.color = Color.black;
    }
}

But in all fairness, it should give you some pointers on what I meant in my previous post.

[wideeyenow_unity]

@brygonnn

but before I start, how can I make a debug check for layers? Thanks.

Sorry! totally missed that part.

This post should help, as I see some good pointers in it:
https://discussions.unity.com/t/403198

But mostly I meant, by debug, is print($"ray hit {collider.name}"); and then play around with the layers so that it ignores the player, as you only want it to hit wall/ceiling/object/etc…