I got a code for first person camera movement but there is an issue with it.

[luke5647]

I got this code for first person camera but it will only look up and down. I cannot look left or right with it nor will my character move with where the camera goes and I’m not too sure how I should go about fixing this.

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class FirstPersonCamera : MonoBehaviour
{
    public float minX = -60f;
    public float maxX = 60f;

    public float sensitivity;
    public Camera cam;

    float rotY = 0f;
    float rotX = 0f;

    void Start()
    {
        Cursor.lockState = CursorLockMode.Locked;
        Cursor.visible = false;
    }

    void Update()
    {
        rotY += Input.GetAxis("Mouse X") * sensitivity;
        rotX += Input.GetAxis("Mouse Y") * sensitivity;

        rotX = Mathf.Clamp(rotX, minX, maxX);

        transform.localEulerAngles = new Vector3(0, rotY, 0);
        cam.transform.localEulerAngles = new Vector3(-rotX, 0, 0);

        if (Input.GetKeyDown(KeyCode.Escape))
        {
            //Mistake happened here vvvv
            Cursor.lockState = CursorLockMode.None;
            Cursor.visible = true;
        }

        if (Cursor.visible && Input.GetMouseButtonDown(1))
        {
            Cursor.lockState = CursorLockMode.Locked;
            Cursor.visible = false;
        }
    }
}

[PraetorBlue]

The code itself looks ok I think - the question is which object is it attached to and how is your hierarchy set up? Please share your object hierarchy, and clearly show which object the script is attached to and the script inspector to show which objects are assigned in it?

Ideally your hierarchy looks like this:

• Player (This script, your movement script)
• Camera (Camera)

[luke5647]

This is how my hierarchys set up. it is attached to the camera

[AnimalMan]

Did you try without locking the cursor ?

Locked —-
Locks cursor to the center of the game window.

Is it possible the lock is so good that it’s not picking up your mouse left and right?

[Kurt-Dekker]

If that’s your hierarchy (Camera at root), then line 29 and 30 are the same transform, hence only one of those lines will win, the second one… the one that looks up / down.

Hey, look at that… that’s the exact problem you reported!

If I had to guess, the above script is supposed to be on the character, and the Camera is supposed to be a child, which is not the case in your hierarchy above.

PS. If you would prefer something more full-featured here is a super-basic starter prototype FPS based on Character Controller (BasicFPCC):

A Basic First Person Character Controller for prototyping

[BasicFPCC - A basic first person character controller] Gist Link After some interest in an old post here , I spent the weekend frankensteining snippets of code to make a single script FPCC that could be used like the FPCC from Unity 4~5, including the crouch and run from Aldo, and I also added farcry sliding. There is a Menu Item function to easily create and configure a new FPCC object. Otherwise very easy to set up, it only requires a layer to exclude itself from sphere/raycasts…

That one has run, walk, jump, slide, crouch… it’s crazy-nutty!!

[PraetorBlue]

@luke5647

This is how my hierarchys set up. it is attached to the camera

Yep your hierarchy is wrong for how the code expects things to be set up - try setting things up like I mentioned in my post above:

• Move the script to the player object (remove it from the camera)
• Make the camera object a child of the player object
• Make sure the camera is dragged and dropped into the slot in the script inspector.

[luke5647]

@AnimalMan

Did you try without locking the cursor ?

Locked —-
Locks cursor to the center of the game window.

Is it possible the lock is so good that it’s not picking up your mouse left and right?

That was exactly the problem. I took it out and its all good thanks man

[luke5647]

@Kurt-Dekker

If that’s your hierarchy (Camera at root), then line 29 and 30 are the same transform, hence only one of those lines will win, the second one… the one that looks up / down.

Hey, look at that… that’s the exact problem you reported!

If I had to guess, the above script is supposed to be on the character, and the Camera is supposed to be a child, which is not the case in your hierarchy above.

PS. If you would prefer something more full-featured here is a super-basic starter prototype FPS based on Character Controller (BasicFPCC):

https://discussions.unity.com/t/855344

That one has run, walk, jump, slide, crouch… it’s crazy-nutty!!

Thanks I made this change along with some others and its all good now

[luke5647]

@PraetorBlue

Yep your hierarchy is wrong for how the code expects things to be set up - try setting things up like I mentioned in my post above:

• Move the script to the player object (remove it from the camera)
• Make the camera object a child of the player object
• Make sure the camera is dragged and dropped into the slot in the script inspector.

Thanks man I made these changes and its all good now