Int not updating after player completes task

[jasonrward]

So, I’m building a simple puzzle in VR using the XR Interaction Toolkit. In order to complete the puzzle, the player needs to insert pieces into the correct sockets. The script tracks the number of correct pieces and the puzzle should be complete when the player inserts two pieces correctly. I have the script below. I have tried this over and over again, but the number of complete tasks does not update.

Here is the script on the individual sockets. The two should talk to each other. I feel like I must have made a simple mistake, but I can’t find it and it is driving me nuts.

[uwdlg]

EDIT: Disregard, I mixed something up.

[jasonrward]

@uwdlg

Not sure if that is the culprit here, but you should never compare two strings using ==, use string1.Equals(string2) instead. Strings are objects and the == operator checks if the left and right operand are referencing the same object. Due to compiler optimizations (“string interning”), string objects sometimes get reused (meaning creating two strings with the same contents “often” results in two references to the same string object under the hood) and thus the comparison returns true, but this is not something you can rely on. The Equals method instead checks if the contents of two strings are the same (and can optionally be fed with more info on how the comparison should handle special cases).

So, something like this?

Thank you. I will give it a try.

[jasonrward]

@jasonrward

So, something like this?

Thank you. I will give it a try.

Not sure if I had it right, but this did not fix the issue.

[kdgalla]

@uwdlg

Strings are objects and the == operator checks if the left and right operand are referencing the same object.

For C# strings the == operator is overloaded to compare the values, not the references.

[uwdlg]

My bad, mixed up my C# and Java. I’ll edit my post to avoid confusion, sorry about that.

The only other piece of advice I can give is to generously sprinkle Debug.Log(); calls into the code to see where exactly things don’t work as expected. To me the code doesn’t have any obvious mistakes, so I’d guess CompletedPuzzleTask isn’t called, maybe because the surrounding if-clause never evaluates to true or the ObjectSnapped callback is never called.

[jasonrward]

Ok, thank you both. I suspect that the CompletedPuzzleTask isn’t being called as well. Just need to figure out where the breakdown occurs.

[JeffDUnity3D]

@jasonrward

Ok, thank you both. I suspect that the CompletedPuzzleTask isn’t being called as well. Just need to figure out where the breakdown occurs.

Use Debug.Log to find out for sure, as was mentioned. https://discussions.unity.com/t/748729/14