Level updater

Unity Engine
1

I have this script that checks how many cubes were collected and then the amount collected is can be used since the the count variable is a getter.

using UnityEngine;
using UnityEngine.UI;
using System.Collections;

public class PlayerController : MonoBehaviour {

    /////////////////
    /// Variables ///
    /////////////////
    private int count = 0;
        .
        .
        .
    public int Count {
        get {
            return count;
        }
    }

        .
        .
        .

    /////////////////////////////
    /// Change score on touch ///
    /////////////////////////////
    void OnTriggerEnter(Collider other) {
        if(other.gameObject.CompareTag("PickUp")) {
            other.gameObject.SetActive(false);
            count++;
            UpdateScore();
        }
    }

    ///////////////////////////
    /// Collected all cubes ///
    ///////////////////////////
    void UpdateScore() {
        countText.text = "Score: " + count.ToString();
        if(count >= howManyToCollect.Length) {
            allCollectedText.text = "All cubes collected, roll to the portal!";
        }
    }

}

I also have this script that is suppose to load the next level after checking if the number of cubes in the level and the number of cubes collected (used the count getter).

using UnityEngine;
using System.Collections;

public class UpdateScene : MonoBehaviour {

    private GameObject[] howManyNeeded;

    ///////////////////////////////////
    /// How many needed to continue ///
    ///////////////////////////////////
    void Start() {
        howManyNeeded = GameObject.FindGameObjectsWithTag("PickUp");
    }

    ///////////////////////////////////////////////////////////////////
    /// Change level if player touches portal & all cubes collected ///
    ///////////////////////////////////////////////////////////////////
    void OnTriggerEnter(Collider other) {
        PlayerController countFromPlayerController = new PlayerController();
        if(other.gameObject.CompareTag("Portal") && howManyNeeded.Length >= countFromPlayerController.Count) {
            Application.LoadLevel(Application.loadedLevel + 1);
        }
    }

}

I checked the console and it doesn’t show any error.

Is it even possible to change the value of a getter in the same script? Or do I have to use another variable in the UpdateScene script in the same way I used the count in the PlayerController?

2 
PlayerController countFromPlayerController = new PlayerController();

This will create a new PlayerController each time OnTriggerEnter is called, and this PlayerController will have the default values, so your count variable will always be 0.

Instead, you want a reference to the PlayerController that already exists on your player. The easiest way to do this is to set it in the inspector, just add public PlayerController countFromPlayerController; in your UpdateScene script, and then remove the line PlayerController countFromPlayerController = new PlayerController(); and then drag your player into the countFromPlayerController field in the inspector.

There are also other ways to do this, you could get the PlayerController from script with FindObjectOfType or with static variables or a singleton, but try with a public variable and the inspector first.

1 Like
3

I found out I attached the UpdateScene script to the wrong object.

I changed it and the script I wrote before works but this time I get the warning:
You are trying to create a MonoBehaviour using the ‘new’ keyword. This is not allowed. MonoBehaviours can only be added using AddComponent(). Alternatively, your script can inherit from ScriptableObject or no base class at all
UnityEngine.MonoBehaviour:.ctor()
PlayerController:.ctor()
UpdateScene:OnTriggerEnter(Collider) (at Assets/Scripts/UpdateScene.cs:21)
(I get the warning everytime I pick up any of the PickUps)

If I change the script to what you suggested I get the error:
Object refrence not set to an instance of an object

It works without any error or warning when I use another variable in the same way I use the count variable in the PlayerController script (I can just do that but I want to use a different way since I’m still learning C#).

4

This is what I was saying, you shouldn’t be doing PlayerController countFromPlayerController = new PlayerController();

Did you remember to assign it in the inspector in the editor?

1 Like
5

Ok thank you it works fine now :slight_smile:

1 Like