Material Editor extreme lag

[pointcache]

Any modification to Lit material causes extreme lag.
Any property.

hdrp 4.0.1,
win 10, i7 4790, gtx 980,
2018.3.0b7

[pointcache]

What the hell.

[pointcache]

One click on the material property - 11938 get full name calls.

Bug case
1094991

[RecursiveRuby]

I’m getting this as well. Makes modifying materials borderline unusable. Seems to be worse in larger projects although I’ve not been able to identify what causes it to get increasingly worse.

[No3371]

+1, This should be very obvious though Unity not even mentioned this in patch note!

[MadeFromPolygons1]

is this fixed in b10?

[No3371]

@MadeFromPolygons_1

is this fixed in b10?

no

[RecursiveRuby]

I’m honestly surprised there isn’t more attention being brought to this. During play mode if I select an object in the hierarchy that has a renderer component it lags the editor so badly I have to end process and close Unity most of the time. I talked to the devs of Odin Inspector about this because I thought it was an issue with Odin when I encountered this initially. I soon after realised it wasn’t to do with Odin however he did figure this out

@bjarkeck

Looks like it scales with the number of managed types in any given project. The stack frame for any given frame in the Material Inspector looks like this:

DrawEditor()
DrawHeader()
OnHeaderIconGUI()
AssetPreview.GetAssetPreview()
// And here comes the interesting part.
Editor.CreateEditor()

So GetAssetPreview decides to create an editor to generate a preview, Editor.CreateEditor then enumerates a ton of assemblies in order to search for the appropriate editor, and this happens every frame, so the more types in the app domain, the more lag. I think Unity has a bug somewhere, it’s likely something isn’t cached correctly, or a dictionary lookup has gone wrong somewhere along the road. We should report this bug to Unity

So hopefully the devs can look into this and hopefully figure something out.

[bjarkeck]

@RecursiveRuby

I’m honestly surprised there isn’t more attention being brought to this. During play mode if I select an object in the hierarchy that has a renderer component it lags the editor so badly I have to end process and close Unity most of the time. I talked to the devs of Odin Inspector about this because I thought it was an issue with Odin when I encountered this initially. I soon after realised it wasn’t to do with Odin however he did figure this out

So hopefully the devs can look into this and hopefully figure something out.

Yeah, looks like the same error we had. It’s not the first time we catch Unity calling Editor.CreateEditor each frame in the inspector which it really doesn’t like.

Also made a bug report about it: https://fogbugz.unity3d.com/default.asp?1099071_p9h343vg0j0u6ig7

[pointcache]

So those get full name are the editor iterating all the types in the project? Dont think i have 11k types.

[bjarkeck]

@pointcache

So those get full name are the editor iterating all the types in the project? Dont think i have 11k types.

Yeah I think it is.

Tried this out in a clean Unity project in 2018.3

Debug.Log(AppDomain.CurrentDomain.GetAssemblies().SelectMany(x => x.GetTypes()).Count());

Which game me type count 18029, So you probably have atleast that Unity probably excludes some assemblies when scanning.

[iamarugin]

Same problem here in the release version of Unity and hdrp 4.6 >_<

[MadeFromPolygons1]

This problem is still persisting in 2018.3.0f2

[pointcache]

Ahaha, its damn mouse polling rate.
Ive noticed that this barrage of calls happened even in editor plugins that should be perfect like bolt,
ran editor profiler and saw like 10k calls, and scratched my head as to what could be the reason.
Then it ticked - the mouse and gui input is coming from the system, thus the poll rate defines the amount of unity events raised.

I had it at 1000
Now check this out
1000

125

Its still a shitton, but its 10 times less editor lag.
My editor lagged for years. I had no idea how it got worse with years.
But it wast the editor that got worse its the mouses that got better.
This is the most hilarious issue I’ve had.
I guess its the Christmas spirit touching my forehead.

[io-games]

The issue is still here, Unity 2019.1.10f1
Please fix, I can not work anymore