Material.Setfloat not working properly in Editor, is that a bug?

[RaymingW]

Hi all,

After I upgrade all my materials to the HDRP materials, the alpha clipping is turned off. I’m writing an editor script that can turn on alpha clipping for all transparent unlit materials.

Here is my code:

    public static void FixAlphaClipping(Material mat)
    {
        var shaderName = mat.shader.name;
        Debug.Log(shaderName);
        Debug.Log(mat.GetFloat("_AlphaCutoffEnable"));
        if (mat.shader.name == "HDRP/Unlit")
        {
            if (mat.GetFloat("_SurfaceType")==1f)
            {
                Debug.Log("Surface Type Transparent");
                mat.SetFloat("_AlphaCutoffEnable",1f);
                //mat.set("_SurfaceType",0);
            }
            else
            {
                Debug.Log("Surface Type Opaque");
            }
           
        }
    }

The code works fine. I can see the “Alpha Clipping” is turned on in the inspector. However, nothing happened in the scene view.
The funny thing is if I modify something completely irrelevant in the inspector, surface color, for example, the setting will apply.

Is this a bug?

[RaymingW]

Mystery Solved!

@bgolus

If you look at the Lit.shader itself you’ll find a bunch of #pragma shader_feature_local lines. Those are features that can be enabled or disabled on the shader via keywords. You can look at the code for the Lit shader’s custom material editor to get an idea of what keywords (or other settings) need to be set for various features. The custom editor only runs while in the editor while you have the material selected. When modifying the material from your own code you need to enable or disable those keywords on the material yourself.

For a normal map, it looks like you need to enable the "_NORMALMAP" and "_NORMALMAP_TANGENT_SPACE" keywords in addition to setting the texture.

https://docs.unity3d.com/ScriptReference/Shader.EnableKeyword.html