Melee attack on trigger with collider

Unity Engine
,
1

I have strange bug with my melee attack. Most of the time my melee attack is not working.
If im standing still and do the melee attack to the enemy, than maybe the first hit will do the damage,
but rest of the hits not. I have recorded it to show what happens:

I think the issue is the meleeTrigger script but I’m not sure.
Script is attached to the gameObject meleeTrigger with 2D collider.
Here is my code:

public class MeleeTrigger : MonoBehaviour
    {
    private int meleeDmg = -20;
    void OnTriggerEnter2D (Collider2D other)
    {
        if (other.isTrigger != true && other.CompareTag("Player_Njinja"))
        {
            HealthNjinja eHealth = other.gameObject.GetComponent<HealthNjinja>();
            eHealth.ModifyHealth(meleeDmg);
        }
    }
}

This is also my meleeAttack code, but I don’t think here is the problem (this script is attached to the player):

public class MeleeAttack : MonoBehaviour
    {
    private bool Attacking = false;
    private float attackTimer = 0.0f;
    private float attackCD = 0.01f;
    public Image meleeAttack;
    public float cooldown = 2f;
    bool isCooldown = false;
    public Collider2D meleeTrigger;
    public Animator animator;
    void Start()
    {
        meleeAttack.fillAmount = 0;
    }
    void Awake()
    {
        animator = gameObject.GetComponent<Animator>();
        meleeTrigger.enabled = false;
    }
 
    void Update()
    {
        if (Input.GetButtonDown("meleeAttack") && !Attacking && isCooldown == false)
        {
            isCooldown = true;
            Attacking = true;
            meleeAttack.fillAmount = 1;
            FindObjectOfType<AudioManager>().Play("SwordAttack");
            attackTimer = attackCD;
            meleeTrigger.enabled = true;
        }
        if (isCooldown)
        {
            meleeAttack.fillAmount -= 1 / cooldown * Time.deltaTime;
            if (meleeAttack.fillAmount <= 0)
            {
                meleeAttack.fillAmount = 0;
                isCooldown = false;
            }
        }
        if (Attacking)
        {
            if (attackTimer > 0)
            {
                attackTimer -= Time.deltaTime;
            }
            else
            {
                Attacking = false;
                meleeTrigger.enabled = false;
            }
        }
        animator.SetBool("IsAttacking", Attacking);
    }
}
2

I found a solution to this, and it worked perfectly. I used another script for it. Furthermore, I didn’t use melee Trigger anymore, rather MeleePrefabKnightAdvanturer (attach it to prefab and make it invisible) and the button where I Instantiate(meleePrefab, firePointMeleeAttack.position, firePointMeleeAttack.rotation); After instantiate the prefab will be very fast destroyed, so it would be like melee attack. :smile:

This is the game I developed from it: https://play.google.com/store/apps/details?id=com.CertiDevelopment.MontheeAdventure

SCRIPTS

public class MeleePrefabKnightAdvanturer  : MonoBehaviour  {
    public Rigidbody2D rb;
    public int damageDoneMeleeAttack; //it deals 40 damage close range, 20 damage long range
    private readonly float speedOfMeleeAttack = 100f;

    void Start()
    {
        StartCoroutine(DestroyGameobject());
        rb.velocity = transform.right * speedOfMeleeAttack;
    }

        switch (other.tag)
        {
            case "Enemy_1":
                Enemy1 eHealth = other.gameObject.GetComponent<Enemy1Health>();
                eHealth.ModifyHealth(damageDoneMeleeAttack);
                break;
            case "Enemy_2":
                Enemy2 eHealth2 = other.gameObject.GetComponent<Enemy2Health >();
                eHealth2.ModifyHealth(damageDoneMeleeAttack);
                break;
        }

    IEnumerator DestroyGameobject()
    {
        yield return new WaitForSeconds(0.09f);
        Destroy(gameObject);
    }
}

public class MeleeAttackButton : MonoBehaviour
{

    public Transform firePointMeleeAttack;
    public GameObject meleePrefab;
    public Animator animator;
    public Image shootingMeleeAttack;
    public MeleePrefabKnightAdvanturer meleeDamage;
    private readonly float coolddownMeleeAttacking = 0.5f;
    private bool isCooldownMeleeAttack = false;
    private bool isMeleeAttacking = false;
    private float maleeAttackTimer = 0.0f;
    private float maleeAttackSpeed = 0.01f;
    private bool isPressed;

    void Start()
    {
        shootingMeleeAttack.fillAmount = 0;
        isPressed = false;
    }
    public void Update()
    {
        if (isPressed && isCooldownMeleeAttack == false)
        {
            Instantiate(meleePrefab, firePointMeleeAttack.position, firePointMeleeAttack.rotation);
            isCooldownMeleeAttack = true;
            isMeleeAttacking = true;
            shootingMeleeAttack.fillAmount = 1;
            maleeAttackTimer = maleeAttackSpeed;
            ShootMeleeAttack();
            FindObjectOfType<AudioManager>().Play("SwordAttack");
        }
        isPressed = false;
        if (isCooldownMeleeAttack)
        {
            shootingMeleeAttack.fillAmount -= 1 / coolddownMeleeAttacking * Time.deltaTime;
            if (shootingMeleeAttack.fillAmount <= 0)
            {
                shootingMeleeAttack.fillAmount = 0;
                isCooldownMeleeAttack = false;
            }
        }
        if (isMeleeAttacking)
        {
            if (maleeAttackTimer > 0)
            {
                maleeAttackTimer -= Time.deltaTime;
            }
            else
            {
                isMeleeAttacking = false;
            }
        }
        animator.SetBool("IsAttacking", isMeleeAttacking);
    }
    public void ShootMeleeAttack()
    {
        isPressed = true;     
    }

}