Minor bugs in my gun shooting script

[caleb_b]

I’ve created this script attached to a gun. The script fires the gun, and I am working to make the gun deal damage if the bullet hits an enemy. Here is the script

using UnityEngine;
using System.Collections;

public class PlayerGunController : MonoBehaviour 
{
	public float fireRate = 1;
	public GameObject bullet;
	public int damage;
	public int ammo = 15;

	private float nextFire = 1;

	void Update () 
	{
		if(Input.GetButton("Fire1") && Time.time > nextFire)
		{
			nextFire = Time.time + fireRate;
			Fire();
			ammo--;
		}
	}
	void Fire() 
	{
		float range= Mathf.Infinity;
		Ray ray= Camera.main.ScreenPointToRay(Input.mousePosition);
		RaycastHit hit;

		if(Physics.Raycast(ray, out hit, range))
		{
			bullet.transform.position = hit.point;
			if(hit.transform.gameObject.tag == "Enemy")
			{
				hit.transform.GetComponent<EnemyHealth>().health -= damage;
			}
		}
	}
}

The functionality of this script is simple. There is a block in the level that acts as the bullet. It is assigned as Bullet for this script. When the “fire” button is clicked, the block’s position is changed to the location of the cursor at that moment. If the object the block is touching is tagged as enemy, the enemy takes damage. It works in that sense.

The problem is that is “fire” is pressed multiple times without moving the cursor, the first block hits the enemy, but the second click only hits the position of the previous block, not the enemy.

I was thinking I could just say to destroy the gameobject when it hits something (Don’t know how or where I’ll do that. Haven’t gotten that far yet). The problem with that is there is only one bullet. If I destroy it, that’s it. No more ammo. We can’t have that.

The solution for THAT problem is to use prefabs. So can I edit this script to retain this functionality, but use a prefab of a bullet instead?

[Habitablaba]

You’re not really using that ‘bullet’ the way you think you are.

What is likely happening here is:

• Ray cast from mouse pointer forward
• Ray hits object, returns true
• Move ‘bullet’ to collision point
• check if the raycast hit an enemy, returns true
• do damage
• Ray cast again, hitting the bullet that you just moved, returns true (it did hit something after all)
• check if the raycast hit an enemy, return false (it hit the bullet)

Instead of keeping an actual bullet around that you transform from place to place, why not just represent “ammo” as a number? you are already doing ammo–; so it isn’t that far off from what you’re doing. As a bonus, you don’t have to worry about prefabs, and the game won’t slow down if you fire your gun a whole bunch of times.