Minor outdated code comments

In the 1.3.0-pre.1 manual, under
https://docs.unity3d.com/Packages/com.unity.sentis@1.3/manual/run-a-model-a-layer-at-a-time.html

the code comments refer to a do-while loop

but the code is “just” checking a return value inside a vanilla monobehaviour Update(), not really a do-while loop

Edit: I guess its referring to the Run a model a layer at a time sample, which does use a do-while loop, but thats not obvious from the manual text

Also, in Sentis.cs, on line 363 in ModelExtensions.CreateWorker(), the comment says it calls ModelLoader.Load() followed by WorkerFactory.CreateWorker(), buuut since its an extension of Model (not ModelAsset) the code just calls WorkerFactory.CreateWorker(). The comment was probably just copied from ModelAssetExtensions.CreateWorker() below it, obviously not a huge issue

Ah yes good call, we’ll update thanks

1 Like

This is known internally as Issues 205 and 206