my code does not seem to work

[Khabi12]

the error is that it says: The modifier ‘private’ is not valid for this item

the code is:

private void AddToInventory(string itemName);
        }

[MelvMay]

The above isn’t valid code at all. You’ve got a random bracket there, no idea what that’s supposed to be. The function doesn’t have any defined body.

Maybe you should post all the code.

Are you completely new to scripting?

Also, don’t use the Bug tag, this isn’t a bug, it’s a typo or misunderstanding of how to write code. It’s the compiler telling you that it doesn’t understand what you’re typing.

[Khabi12]

ok

@MelvMay

ok here all of the code:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class InventorySystem : MonoBehaviour
{
  
    public static InventorySystem Instance { get; set; }
    public GameObject inventoryScreenUI;
    public bool isOpen;
    public List<GameObject> slotList = new List<GameObject>();
    public List<string> itemList = new List<string>();
    private GameObject itemToAdd;
    private GameObject whatSlotToEquip;
    //public bool isFull;
    private void Awake()
    {
        if (Instance != null && Instance != this)
        {
            Destroy(gameObject);
        }
        else
        {
            Instance = this;
        }
    }
    void Start()
    {
    
        isOpen = false;
        PopulateSlotList();
      
    }
        // it makes it so i dont need to drag and drop the slots to the slotlist [DOES WORK NOW]
    private void PopulateSlotList()
    {
       foreach (Transform child in inventoryScreenUI.transform)
       {
          if (child.CompareTag("Slot"))
          {
           Debug.Log("slotlist is working");
             slotList.Add(child.gameObject);
          }
       }
    }
// makes it so i can open the inventory
    void Update()
    {
        if (Input.GetKeyDown(KeyCode.E) && !isOpen)
        {
             Debug.Log("5");
            Debug.Log("E is pressed");
            Cursor.lockState = CursorLockMode.None;
            inventoryScreenUI.SetActive(true);
            isOpen = true;
        }
        else (Input.GetKeyDown(KeyCode.E) && isOpen);
        {
             Debug.Log("5");
            Cursor.lockState = CursorLockMode.Locked;
            inventoryScreenUI.SetActive(false);
            isOpen = false;
        }
        private void AddToInventory(string itemName);
        {
             Debug.Log("3");
               isFull = true;
    
                Debug.Log("inventory is full");
         whatSlotToEquip = FindNextEmptySlot();
         itemToAdd = Instantiate(Resources.Load<GameObject>(itemName), whatSlotToEquip.transform.position, whatSlotToEquip.transform.rotation);
         itemToAdd.transform.SetParent(whatSlotToEquip.transform);
         itemList.Add(itemName);
        
        
      
        
        }
    }
    public bool CheckIsFull()
    {
  Debug.Log("4");
        isFull =true;
       int counter = 0;
       foreach (GameObject slot in slotList)
       {
          if (slot.transform.childCount >0)
          {
             counter == 1;
          }
       }
       if (counter == 21)
          {
             return true;
          }
          else
          {
              return false;
          } 
    }
    private GameObject FindNextEmptySlot()
    {
    
       foreach(GameObject slot in slotList)
       {
         Debug.Log("2");
          if (slot.transform.childCount == 0)
          {
            Debug.Log("working 2");
             return slot;
          }
       }
       return new GameObject();
    }
}

.

[MelvMay]

You’re adding random “';” onto the ends of things! You only do that on the ends of statements yet you’ve done it at least on lines 57 and 64 (above).

Also, you define a function within another function because you don’t match the end braces “}” with the open “{” braces. You’re defining “private void AddToInventory” inside the “Update” function.

You just need to look at your code carefully.

[Khabi12]

@MelvMay

You’re adding random “';” onto the ends of things! You only do that on the ends of statements yet you’ve done it at least on lines 57 and 64 (above).

Also, you define a function within another function because you don’t match the end braces “}” with the open “{” braces. You’re defining “private void AddToInventory” inside the “Update” function.

You just need to look at your code carefully.

tell my wich lines

[MelvMay]

Did I not just say lines 57 and 64 and tell you other problems?

If you don’t understand how to write C# code then you a forum isn’t the place to learn it.

[Kurt-Dekker]

@Khabi12

tell my wich lines

ALL lines must be perfect. Keep this in mind:

Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

How to do tutorials properly, two (2) simple steps to success:

Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That’s how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.
Fortunately this is the easiest part to get right: Be a robot. Don’t make any mistakes.
BE PERFECT IN EVERYTHING YOU DO HERE!!

If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there’s an error, you will NEVER be the first guy to find it.

Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

Finally, when you have errors… GO FIX THEM!

Remember: NOBODY here memorizes error codes. That’s not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

The complete error message contains everything you need to know to fix the error yourself.

The important parts of the error message are:

• the description of the error itself (google this; you are NEVER the first one!)
• the file it occurred in (critical!)
• the line number and character position (the two numbers in parentheses)
• also possibly useful is the stack trace (all the lines of text in the lower console window)

Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don’t have to stop your progress and fiddle around with the forum.