My Score Counter works just fine, but it keeps going up rather than stopping at 100 points

Unity Engine
,
1 
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class ScoreManager : MonoBehaviour
{
    public static int scoreCount;
    public static int highScoreCount;
    public Text scoreText;
    public Text highScoreText;
    public GameObject zombie;
    public CanvasGroup score;
    // Start is called before the first frame update
    void Start()
    {
        scoreCount = 0; // set the score to 0 at the start of the game
        highScoreCount = PlayerPrefs.GetInt("HighScore", highScoreCount); // store the highScore
        highScoreText.text = "High Score: " + highScoreCount.ToString(); // display the player's high score
        score.alpha = 1;
        score.interactable = true;
        score.blocksRaycasts = true;
    }

    // Update is called once per frame
    void Update()
    {
        if (GameObject.FindGameObjectWithTag(tag: "Zombie") == null)
        {
            scoreCount += 100;
            scoreText.text = "Score: " + scoreCount.ToString(); // display the player's score
            if (scoreCount > highScoreCount)
            {
                highScoreCount = scoreCount;
                PlayerPrefs.SetInt("HighScore", highScoreCount);
                PlayerPrefs.Save();
            }

            if (Time.timeScale == 0)
            {
                score.alpha = 0;
                score.interactable = false;
                score.blocksRaycasts = false;
            }
        }
    }
}

This code is working great for keeping the player’s score, but each kill it keeps adding 100 points. Not stopping until another zombie spawns. think line 28 could be the culprit, but if it is I don’t know the fix.

2

Don’t run your score incrementing code in Update. That runs every frame. Instead, run it when the zombie dies. You could have the Zombie script call a function on your ScoreManager to increment the score when it dies.

3

Before destryoing the zombie you can update your score. You can get component of your score manager from your zombie.

This is on your zombie: (You need to getcomponent of your scoremanger first)

        if (health == 0)
        {
            scoreManager.updateScore();
            destroy(this);
        }

This is on your score manager:

    public void updateScore()
    {
        scoreCount += 100;
    }
4

GetCompontent doesn’t work when I try to use it, I am running Unity 2019.4.11f LTS, is that version bugged or something?

5

No, literally every Unity project would break if GetComponent was bugged. Show us the code that doesn’t work. Most likely, you’re attempting to call GetComponent on an object that doesn’t have the component being requested.

2 Likes
6

You’re right, I don’t think that’s even a possibility, I’m probably just messing up somewhere…
As for the code that doesn’t work. here it is:

  private void Awake()
    {
        ScoreManager scoreManager = score.GetComponent<ScoreManager>(); // gets the scoremanager script
    }

This isn’t getting the ScoreManager script, it’s on the Score GameObject

public GameObject score; // stores a reference to the score GameObject

Here’s where Visual Studio is giving me errors:

     if (health == 0)
        {
            scoreManager.updateScore();
            Die();
        }

If you wish to see what the Die function is doing:

void Die()
            {
                Destroy(transform.parent.gameObject);


            }
7

Did you add the script “ScoreManager” to your score gameobject ?

What does not work ? Do you get a Nullreferenceexception if you try to call scoreManager.updateScore(); ?

You can add Debug.Log to see, if your scoreManager object is null or not:
Debug.Log(scoreManager);

If it is not null, the error should be in the updateScore method.

8

It does say the name scoreManager does not exist

It says the name scoreManager does not exist in the current context in this line of code:

 if (health == 0)
        {
            scoreManager.updateScore();
            Die();
        }

Although I GetCompontent here:

private void Awake()
    {
        ScoreManager scoreManager = score.GetComponent<ScoreManager>();
    }

And if it matters, these are both in the same class.

9

You need to create an instance variable. Right now this is just a local variable that exists only inside Awake()

private void Awake()
    {
        ScoreManager scoreManager = score.GetComponent<ScoreManager>();
    }

You won’t be able to use that variable in any other functions. You need to declare ScoreManager scoreManager; OUTSIDE of any functions to make it into an instance variable which can be used across different functions.

1 Like
10

Is this what you mean?

if (health == 0)
        {
                ScoreManager scoreManager = score.GetComponent<ScoreManager>();
                scoreManager.updateScore();
            Die();
        }
11

Not really but that may work too since score is an instance variable. Does that object also have the ScoreManager attached to it? It will work if it does.

12

@PraetorBlue ment actually:

public GameObject score;
private ScoreManager scoreManager ; // Global declaration of your object instance

private void Awake()
{
    scoreManager = score.GetComponent<ScoreManager>();
}

With that global declaration you can use your object instance in the whole class. If you declare it in a method it´s only “visible” inside of that method, means you can only use it inside that method

1 Like
13

Where is your scoreManager script located? You can create a new empty gameobject called"Game Manager" and put scoremanager in it so you can easly findd it from your zombie code. Put a tag on your gamemanager.

private GameObject gameManager;
    void Start()
    {
        gameManager = GameObject.FindGameObjectWithTag("Game Manager");
     
    }

and you can call the score manager script like this:

        if (health == 0)
        {
            gameManager.getcomponent<scoreManager>().updateScore();
            Die();
        }

There are lots of ways to do it.

14

The way I did it score runs under its own Panel called Score in a Canvas called UI. I would think the problem is having the script located in a canvas except I am unable to use GetCompontent on any script in my game.

15

You can add an empty gamobject as child of your canvas and add the script to that gameobject. Set a tag like “ScoreManager” (or anything else) o the gameobject and it should work like @Atix07 said (you just have to adapt the tag name in the method FindGameObjectWithTag).

16

My only problem is that It’s the prefabbed zombie is what’s trying to access the ScoreManager. Should I prefab the empty object that has the script on it? Or take another approach?

17

But why is that a problem ? if you access the empty gameobject with the script to your canvas and put a tag on it, you can access it from where ever you want. You just need any gameobject that has the script (and the tag).

No i wouldn´t create a prefab of the that empty gameobject only for that.

18

The score

Thank you @Sphinks and @Atix07 ! I have been trying to find a solution to this problem for an embarrassingly long time!