Need Help With Errors In Movement Code

Unity Engine
1

Hi! I am VERY new to unity, and I was watching a tutorial on how to make a 2D ragdoll move. I have 2 errors after making the movement script:

Assets\PlayerController.cs(22,22): error CS1001: Identifier expected

Assets\PlayerController.cs(39,34): error CS1002: ; expected

Here is my code for the script:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PlayerController : MonoBehaviour
{

    public Animator anim;
    public Rigidbody2D rb;
    public float jumpForce;
    public float playerSpeed;
    public Vector2 jumpHeight;
    private bool isOnGround;
    public float positionRadius;
    public LayerMask ground;
    public Transform playerPos;


    // Start is called before the first frame update
    void Start()
    {
        Collider2D[] = transform.GetComponentsInChildren<Collider2D>();
        for (int i = 0; i < colliders.Length; i++)
        {
            for(int k = i + 1; k < colliders.Length; k++)
            {
                Physics2D.IgnoreCollision(colliders[i], colliders[k]);
            }
        }
    }

    // Update is called once per frame
    void Update()
    {
        if(Input.GetAxisRaw("Horizontal") != 0)
        {
            if(Input.GetAxisRaw("Horizontal") > 0)
            {
                anim.Play("Walk")
                    rb.AddForce(Vector2.right * playerSpeed);
            }
            else
            {
                anim.Play("walk backwards");
                rb.AddFoece(Vector2.left * playerSpeed);
            }
        }
        else
        {
            anim.Play("idle");
        }

        isOnGround = Physics2D.OverlapCircle(plaperPos.position, positonRadius, ground);
        if(isOnGround == true && Input.GetKeyDown(KeyCode.Space))
        {
            Debug.Log("jumping");
            rb.AddForce(Vector2.up * jumpForce);
        }
    }
}

If it helps, my ragdoll is not exactly the same as the one in the tutorial.

Thanks!
2

So you know, this isn’t a 2D question, it’s not even a Unity question, it’s a basic C# question so it seems you’re new to C# rather than just Unity which is fine but for the future, please keep scripting/C# related questions to the scripting forum although I will say it’s nice to see a new user post code using code-tags and also posting the full error codes and not just the description which is a very common thing to do so welcome! :slight_smile:

The first error is on line 22 and you’ve not named the variable, you’ve just specified its type. You then go on to iterate it with a variable called “colliders” so I guess you meant to put:

Collider2D[] colliders = transform.GetComponentsInChildren<Collider2D>();

The second error tells you again which line and column and actually tells you explicitly what is wrong; “; expected” (semi-colon expected) so it seems that you’re just not reading what it’s telling you. C# requires a semi-colon at the end of lines/statements.

Take a look at line 44 which is correct, now compare it to line 39. Missing a semi-colon right? As it said “; expected”.

Good luck.

3

Welcome!

These are all just typographic mistakes. You need to be perfectly accurate when typing code in.

Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

How to do tutorials properly:

Tutorials are a GREAT idea. Tutorials should be used this way:

Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That’s how software engineering works. Every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly. Fortunately this is the easiest part to get right.

Be a robot. Don’t make any mistakes. BE PERFECT IN EVERYTHING YOU DO HERE.

If you get any errors, learn how to read the error code and fix it. Google is your friend here. Do NOT continue until you fix the error. The error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there’s an error, you will NEVER be the first guy to find it.

Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!