Need help with some movement code

Unity Engine
1

So I have a script that makes the player move, and It moves using velocity and It all works, its just when I right click it switches the players and the player that I was previously moving still moves for a little bit, is there any way to just full stop the player once i switch to the other player?

Heres the code:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PlayerMovement : MonoBehaviour
{
    private bool player1Using = true;
    public GameObject player1;
    public GameObject player2;

    public float speed;
    Rigidbody rb;

    void EnableOtherPlayer()
    {
        player1.GetComponent<PlayerMovement>().enabled = player1Using;
        player2.GetComponent<PlayerMovement>().enabled = !player1Using;
    }

    void Start()
    {
        EnableOtherPlayer();

        rb = GetComponent<Rigidbody>();
    }

    void Update()
    {
        float xMove = Input.GetAxisRaw("Horizontal");
        float zMove = Input.GetAxisRaw("Vertical");

        rb.velocity = new Vector3(xMove * speed, rb.velocity.y, zMove * speed);

        if(Input.GetMouseButtonDown(1))
        {
            player1Using = !player1Using;

            EnableOtherPlayer();
        }
    }
}

Update: I found a solution.

2

Tick! Looks like you got your switching back and forth going?

For the above “still moves a bit” problem, one way is to set the Rigidbody.velocity to zero for the player losing control.

3

I still cant fix the fact that, in my if statement, I want it to be that when I click a single time then it switches the player, but it only happens when i click twice, sometimes even three times

4

I’m telling you man, you gotta put your Debug.Log() just immediately inside the if statement.

Here’s why: for all we know right-click is being blocked by the editor for some reason!

At least eliminate that notion, and then we know it’s some logic problem.

Otherwise we can’t reason about it.

5

The Debug.Log(); works and it shows the message every time i click. But it doesnt switch every time i click.

6

What happens when you:

  • move EnableOtherPlayer(); completely out of any if statements (just do it at the end of Update())

  • print the player1Using bool: a) every frame, and b) when clicked (with a different marker on the debug.log to show the difference)

While you’re doing that use the second form of Debug.Log() that accepts an object argument and give it gameObject:

Debug.Log( name + ": clicked to:" + player1Using, gameObject);

That way you can click and be sure which GameObject(s) this is on.

7

The Debug.Log(player1Using); that goes every frame works, and it says true every time until I click once, after I click once then it says false every two frames and it says true every two frames. Once I click twice then it says false every frame. And the EnableOtherPlayer(); doesnt do anything at all when I move it straight into the Update function. And the Debug.Log(); that is in the if statement never goes through. Also after I click once, then it moves both players at the same time.

By the way, I added the velocity removal if that changes anything. This is the script after I changed what u told me to change:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PlayerMovement : MonoBehaviour
{
    private bool player1Using = true;
    public GameObject player1;
    public GameObject player2;

    public float speed;
    Rigidbody rb;

    void EnableOtherPlayer()
    {
        player1.GetComponent<PlayerMovement>().enabled = player1Using;
        player2.GetComponent<PlayerMovement>().enabled = !player1Using;
    }

    void Start()
    {
        EnableOtherPlayer();
        rb = GetComponent<Rigidbody>();
    }

    void Update()
    {
        float xMove = Input.GetAxisRaw("Horizontal");
        float zMove = Input.GetAxisRaw("Vertical");

        rb.velocity = new Vector3(xMove * speed, rb.velocity.y, zMove * speed);

        if(Input.GetMouseButtonDown(0))
        {
            Debug.Log(name + ": clicked to:" + player1Using, gameObject);
            rb.velocity = new Vector3(0, 0, 0);
            player1Using = !player1Using;
        }
        Debug.Log(player1Using);
        EnableOtherPlayer();
    }
}
8

By the way, if it makes any difference. I am not using a button to click on or anything else to click on, I just tried to make it so when I click anywhere in the game it is supposed to switch players

9

You should really have the code that’s responsible for switching on a different script than the player movement script!

Right now if both scripts are enabled at the same time, or they have different things slotted into player1 or player2, everything will break.

10

That worked, thanks.