No reference on script after adding enum

Unity Engine
1

I am creating a channel-based object movement script (designed for doors) and everything was working before I decided to add both MoveTowards and Lerp modes to it using an Enum.

Once I did this, I lost the ability to check for objects on that channel (line 20).

using UnityEngine;
using System.Collections;

public class GateScript : MonoBehaviour
{
    public bool IsActive = true;
    public Vector3 Movement;
    public int BroadcastChannel;
    public enum Method { MoveTowards, Lerp };
    public Method MovementMethod = Method.MoveTowards;
    private GateControl[] ControlsPanels;

    void Start()
    {
        GateControl[] ControlsPanels = FindObjectsOfType(typeof(GateControl)) as GateControl[];
    }

    void Update()
    {
        foreach (GateControl ControlPanel in ControlsPanels)
        {
            if (ControlPanel.BroadcastChannel == BroadcastChannel && ControlPanel.SignalSent)
            {
                this.gameObject.transform.position += Movement;
                if (MovementMethod == Method.MoveTowards)
                {
                    this.gameObject.transform.position = Vector3.MoveTowards(this.gameObject.transform.position, Movement, Time.deltaTime);
                }

                if (MovementMethod == Method.Lerp)
                {
                    this.gameObject.transform.position = Vector3.Lerp(this.gameObject.transform.position, Movement, Time.deltaTime);
                }
            }
        }
    }
}
2

I can’t see anything that would cause an error - can you give more details on what “I lost the ability to check for objects” means? And what “No reference” is? Any errors output to the console?

As an aside, I’d also use a switch statement rather than if statements for the enum value checks (but this is mostly a style thing and will not cause any errors).

EDIT: just noticed your error, in Start() you create a local version of GateControl[ ] ControlsPanels, remove the GateControl[ ] from that.

3

Your edit fixed it, I previously had it all in start, must have forgotten to remove it.

Now how would I get it to stop moving once it has added the vector3 once? Because it is in the Update function it is moving forever.

4

You’re not using Lerp correctly: How to Lerp like a pro | Chico Unity3D

5

From what I can see, this is just another method of, it is no better or more efficient, it still uses essentially the same premise. But this still does not fix my infinite movement problem.
I need to be able to check for SignalSent constantly, but by running the MoveTowards or Lerp every frame, the object constantly moves without stopping (obviously).

using UnityEngine;
using System.Collections;

public class GateScript : MonoBehaviour
{
    public bool IsActive = true;
    public Vector3 Movement;
    public int BroadcastChannel;
    public enum Method { MoveTowards, Lerp };
    public Method MovementMethod = Method.MoveTowards;
    private GateControl[] ControlsPanels;

    void Start()
    {
        ControlsPanels = FindObjectsOfType(typeof(GateControl)) as GateControl[];
    }

    void Update()
    {
        foreach (GateControl ControlPanel in ControlsPanels)
        {
            if (ControlPanel.BroadcastChannel == BroadcastChannel && ControlPanel.SignalSent)
            {
                this.gameObject.transform.position += Movement;
                if (MovementMethod == Method.MoveTowards)
                {
                    this.gameObject.transform.position = Vector3.MoveTowards(this.gameObject.transform.position, Movement, Time.deltaTime);
                }

                if (MovementMethod == Method.Lerp)
                {
                    this.gameObject.transform.position = Vector3.Lerp(this.gameObject.transform.position, Movement, Time.deltaTime);
                }
            }
        }
    }
}
6

Not really answering your question but I’d strongly consider using something like LeanTwean (my favourite tweening engine) to do things like this - it creates vastly more simplified and readable code (and hence more maintainable).

Rather than check the channel in the update loop are you able to invert the control so that the messages are pushed to the receivers instead? So that when the event occurs you just notify all channel listeners and they act on that rather than polling the channel state every frame.

Every invocation of Update() has a cost, it’s best to avoid doing things via Update() when practical.

7

Unsure about what your recommendation means?
I think you are saying that I should be using custom methods to run this but not sure.

Something I am trying to find at the moment is a way to fall out of the if statement once completing the line once but I don’t want to do anything like that, I usually consider things like that to be last resorts.

UPDATE: I have tried setting ControlPanel.SignalSent to false after the line but that causes the object to instantly jump to the location, instead of MoveTowards or Lerp towards it.