Object not deactivating [SOLVED]

Unity Engine
1

Hello,

i have a relatively noobish system of weapon switching, activating and deactivating objects on a player object, but the objects and its children stay activated on runtime though there are no errors in the console. Here’s the script:

using UnityEngine;
using System.Collections;
using System.Collections.Generic;

public class WeaponSwitcher : MonoBehaviour {

public GameObject blaster;
public GameObject blaster2;

public void Awake(){


blaster = GameObject.Find("Blaster");
blaster2 = GameObject.Find("Blaster2");
blaster.SetActive(true);
blaster2.SetActive(false);
}

public void Update()
   
    {
   
       
        if (Input.GetKeyDown("space"))

        {
            Debug.Log("Update Here!");
            blaster.SetActive(false);
            blaster2.SetActive(true);
        }
    }
}

Any ideas?

2

Are you sure that awake and update is called? Your WeaponSwitcher class does not derive from MonoBehaviour and Awake and Update is specified private (which cannot be called from outside). If you are not deriving from MonoBehaviour - how did you attach the script to a game object?
You can also put some debug loggin into the awake and update method do see if it is called, or attach the debugger to unity and set a breakpoint.

3

Oh my god, i forgot :MonoBehaviour. Just a second, let me try.

4

Well, you were right, update is not called, but i don’t know why? It is still not working btw.

5

Are you sure that update is not called?
I’m thinking more that the if clause is never fulfilled. Try to use the KeyCode.Space enum instead of the string if you want to poll the space key directly (Unity - Scripting API: KeyCode.Space).

6

Tried it like this:

public void Update()
   
    {
   
       
        if (Input.GetKeyDown(KeyCode.Space))
        {
            Debug.Log("Update Here!");
            blaster.SetActive(false);
            blaster2.SetActive(true);
        }
    }
}

But nothing. Furthermore, in the awake method, the blaster2 is not deactivated, so both weapons are firing simultaneously.

7

After a bit of deeper googling and reading the manual, i think i have to move the awake method to update method for object to deactivate, and reactivate the object via coroutine. I’ll check it out later.

8

You can’t “move the awake method to update method”. That doesn’t make any sense.

You need to learn to use Debug.Log liberally. Is your Update method running? The fastest way to really know is to put a Debug.Log inside of it.

There’s a bunch of things that can be going wrong here:

  • You might have several objects named “Blaster” or “Blaster2”. GameObject.Find will find the first one, whichever that is.
  • You might not have the script in the scene.
  • The script might be on a deactivated object.
  • ???
9

By moving the awake method to update i meant moving the body from the Awake() to Update()

using UnityEngine;
using System.Collections;
using System.Collections.Generic;

public class WeaponSwitcher : MonoBehaviour {

public GameObject blaster;
public GameObject blaster2;

void Update()

{

blaster = GameObject.Find("Blaster");
blaster2 = GameObject.Find("Blaster2");
blaster.SetActive(true);
blaster2.SetActive(false);

 
    {
         
        if (Input.GetKeyDown("space"))
             
        {
            StartCoroutine(Switch ());
        }
    }
}
    IEnumerator Switch ()
 
    {
            yield return null;
            blaster.SetActive(false);
            blaster2.SetActive(true);
    }
}

There’s only one of each blaster and blaster2 objects and the script is in the scene, of course, on a parent object. The first part of the script now works, blaster2 is disabled, but the coroutine is not switching objects active/unactive state.

10

Well,

looks like the simplest solution is to deactivate the scripts themselves on the objects.

11

Wait. do you have the first part of the script in update? You do realize that even if your coroutine runs, your update will hit, thus enabling blaster and disabling blaster2 again, right?

12

Wow, what an obvious oversight :hushed:

Alright, here’s the working script, thanks everyone for help

using UnityEngine;
using System.Collections;
using System.Collections.Generic;

public class WeaponSwitcher : MonoBehaviour {

GameObject blaster;
GameObject blaster2;

void Start()

{

blaster = GameObject.Find("Blaster");
blaster2 = GameObject.Find("Blaster2");   
blaster.SetActive(true);
blaster2.SetActive(false);

} 

void Update()

{

        if (blaster.active && Input.GetKeyDown("space"))
             
        {
            StartCoroutine(Switch ());
        }
   
       
        if (blaster2.active && Input.GetKeyDown("space"))
           
        {
            StartCoroutine(SwitchBack ());
        }
}

    IEnumerator Switch ()

    {
            yield return null;
            blaster.SetActive(false);
            blaster2.SetActive(true);
    }
   
    IEnumerator SwitchBack ()

    {
            yield return null;
            blaster2.SetActive(false);
            blaster.SetActive(true);
           
    }
}