Part of code in a coroutine is sometimes not executing correctly

[asdfasdf234]

Hello, I’ve been trying to figure out why this part of the code does not always execute as it is supposed to. I just cant figure it out, sometimes it works sometimes it doesnt

            while (Mathf.Abs(this.transform.position.y - player.transform.position.y) > 0.1f)
            {
                float posx = Mathf.SmoothDamp(transform.position.x, player.transform.position.x, ref velocity.x, smoothTimeX);
                float posy = Mathf.SmoothDamp(transform.position.y, player.transform.position.y, ref velocity.y, smoothTimeTransitionY);

                transform.position = new Vector3(posx, posy, transform.position.z);

                yield return new WaitForFixedUpdate();
            }

[/QUOTE__]__

Here is full code:

   public void callCrotuine(float y, Vector3 newMinCameraPos, Vector3 newMaxCameraPos, bool a)
    {
        StartCoroutine(LerpCameraToAnotherHeightPos(y, newMinCameraPos, newMaxCameraPos, a));
    }
 
    IEnumerator LerpCameraToAnotherHeightPos(float y, Vector3 newMinCameraPos, Vector3 newMaxCameraPos, bool x)
    {
        normalFollow = false;

        if(x == true)
        {
            while (Mathf.Abs(this.transform.position.y - y) > 0.01f)
            {
                float posx = Mathf.SmoothDamp(transform.position.x, player.transform.position.x, ref velocity.x, smoothTimeX);
                float posy = Mathf.SmoothDamp(transform.position.y, y, ref velocity.y, smoothTimeTransition);

                transform.position = new Vector3(posx, posy, transform.position.z);

                yield return new WaitForFixedUpdate();
            }
        }
        else if(x == false)
        {
            while (Mathf.Abs(this.transform.position.y - player.transform.position.y) > 0.1f)
            {
                float posx = Mathf.SmoothDamp(transform.position.x, player.transform.position.x, ref velocity.x, smoothTimeX);
                float posy = Mathf.SmoothDamp(transform.position.y, player.transform.position.y, ref velocity.y, smoothTimeTransitionY);

                transform.position = new Vector3(posx, posy, transform.position.z);

                yield return new WaitForFixedUpdate();
            }
        }

        minCameraPos = newMinCameraPos;
        maxCameraPos = newMaxCameraPos;

        normalFollow = true;
        StartCoroutine(FollowPlayer());
    }

    IEnumerator FollowPlayer()
    {
        while (normalFollow)
        {
            pX = Mathf.SmoothDamp(transform.position.x, player.transform.position.x, ref velocity.x, smoothTimeX);
            pY = Mathf.SmoothDamp(transform.position.y, player.transform.position.y, ref velocity.y, smoothTimeY);

            transform.position = new Vector3(Mathf.Clamp(pX, minCameraPos.x, maxCameraPos.x),
                Mathf.Clamp(pY, minCameraPos.y, maxCameraPos.y),
                Mathf.Clamp(transform.position.z, minCameraPos.z, maxCameraPos.z));
            yield return new WaitForFixedUpdate();
        }
    }

here is video(0:09 is where that part of code doesnt work, 0:15 it does work)

https://www.youtube.com/watch?v=TZhBPD52f8o

[fire7side]

There are basically two possibilities. You have very small characters, or the loop is not firing.

[Brathnann]

Yep, debug your variables/conditions to make sure you are getting expected values back.

[simonlvschal]

i have a feeling it’s because your waiting yield return new WaitForFixedUpdate();.

since you’re basicly waiting til the next frame. also

Waits until next fixed frame rate update function. See Also: FixedUpdate.

WaitForFixedUpdate can only be used with a yield statement in coroutines.

thats from the docs. i would just return it immendiately

[asdfasdf234]

@simonlvschal

i have a feeling it’s because your waiting yield return new WaitForFixedUpdate();.

since you’re basicly waiting til the next frame. also

Waits until next fixed frame rate update function. See Also: FixedUpdate.

WaitForFixedUpdate can only be used with a yield statement in coroutines.

thats from the docs. i would just return it immendiately

i tried yield return null, still same

[asdfasdf234]

@fire7side

There are basically two possibilities. You have very small characters, or the loop is not firing.

Characher is not small, and loop does fire but for a very short amount of time, and smooth damp’s smoothTimeTransitionY doesnt seam to be affecting the speed of the camera movement. I

[asdfasdf234]

I also now made this litle video just a walk through the code. Maybe this will make it easier for someone to tell me why this is happening

Untitled

EDIT: oh and smoothTimeY doesnt affect the speed of the second loop

[fire7side]

It looked like it happened when the character was jumping from what I saw. There is a max speed in the damp function which is set to infinity by default. Maybe if it was lower? I haven’t used that function much.