Problem with nested for loops

Unity Engine
,
1

I’m experimenting with grids and 2d arrays, and I have a class that handles visuals.

in Start() I use 2 for loops for creating the tiles and it works fine.

        for (int x = 0; x < gridDimentions_x; x++)
        {
            for (int y = 0; y < gridDimentions_y; y++)
            {
                tiles[x, y] = new GameObject("Tile", components).GetComponent<SpriteRenderer>();

                SpriteRenderer renderer = tiles[x, y];

                Debug.Log(x.ToString() + ", " + y.ToString());

                renderer.transform.position = grid.GetOrigin() + grid.GetCellSize() * new Vector3(x, y);
                renderer.sprite = sprites[grid.GetValue(x, y).Tile];
                renderer.flipY = true;
                renderer.transform.localScale = scale * Vector3.one;
                renderer.transform.parent = TileMap.transform;
            }
        }

Then I have a function called when the grid changes that should update the tiles with the new values, but the same for loops run only one time.

    void UpdateVisuals()
    {
        for (int x = 0; x < gridDimentions_x; x++)
        {
            for (int y = 0; y < gridDimentions_y; y++)
            {
                TileType currentTile = grid.GetValue(x, y).Tile;
                Debug.Log($"{x}, {y}");

                if (sprites[currentTile] == tiles[x, y].sprite)
                    return;

                tiles[x, y].sprite = sprites[currentTile];
            }
        }
    }

The console only shows 0, 0

Also there aren’t errors in the console.

2

Line 11 in the second block might be your problem.

Perhaps you are looking for the keyword continue instead of return ?

If that ain’t it, I’ll be surprised. :slight_smile: You must find a way to get the information you need in order to reason about what the problem is.

What is often happening in these cases is one of the following:

  • the code you think is executing is not actually executing at all
  • the code is executing far EARLIER or LATER than you think
  • the code is executing far LESS OFTEN than you think
  • the code is executing far MORE OFTEN than you think
  • the code is executing on another GameObject than you think it is
  • you’re getting an error or warning and you haven’t noticed it in the console window

To help gain more insight into your problem, I recommend liberally sprinkling Debug.Log() statements through your code to display information in realtime.

Doing this should help you answer these types of questions:

  • is this code even running? which parts are running? how often does it run? what order does it run in?
  • what are the values of the variables involved? Are they initialized? Are the values reasonable?
  • are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

Knowing this information will help you reason about the behavior you are seeing.

You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as Debug.Log("Problem!",this);

If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

You could also just display various important quantities in UI Text elements to watch them change as you play the game.

If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: https://discussions.unity.com/t/700551 or this answer for Android: https://discussions.unity.com/t/699654

Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

Here’s an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

https://discussions.unity.com/t/839300/3

When in doubt, print it out!™

Note: the print() function is an alias for Debug.Log() provided by the MonoBehaviour class.

3

Thank you Kurt-Dekker, using continue fixed the problem.
I was trying to find the issue using Debug.log() but I couldn’t figure that return stop everything

1 Like