Separate class method not being found.

Questions & Answers
1

Hello all,

I’m trying to get code from one of my classes and use it as a global variable. I’ve tried a multitude of things. Here is my current code:

   public Health health;
    
    void Awake() {
        health = GameObject.FindGameObjectWithTag("Player").GetComponent < Health > ();

        if (health) {
            Debug.Log("Found Health");
        }
        else {
            Debug.Log("Cannot find Health");
        }
    }

What I’m trying to do is simple: see if it can find the Health script. However, it cannot find the component. I have attached the script to the player object and put the Health variable set as the Player in the editor. It will always say it cannot find the Health script on the Player object though.

This is the Health script from top to bottom:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

//A lot of this is probably useless and me just experimenting with code but I figured I'd put it in //here just in case
public class Health : MonoBehaviour {
    public GameObject Phealthbar;
    public GameObject Ehealthbar;
    public GameObject Ehealthnotify;
    public GameObject Phealthnotify;
    private int phealth;
    public int Phealth {
        get {
            return phealth;
        }
        set {
            phealth = value;
        }
    }
    private int ehealth;
    public int Ehealth {
        get {
            return ehealth;
        }
        set {
            ehealth = value;
            Ehealthbar.GetComponent<Text>().text = "Enemy Health: " + Ehealth.ToString();
        }
    }

    public void TakeHealth(string player, int amount) {
        if(player == "Enemy") {
            Ehealth -= amount;
            Ehealthbar.GetComponent<Text>().text = "Enemy Health: " + Ehealth.ToString();
        }
    }
}

These are pictures of the editor to show what I mean if I was unclear:

84829-see-player.png
84829-see-player.png378×854 56.8 KB

84830-see-health.png

Please let me know if more information is needed. Thank you.

2

Hi

From pictures looks like everything is fine and seems like you doing everything correct.
However, try to debug the problem step by step

  1. Make sure your Player object is found
  2. Instead of searching Player object, try to save it reference to some other object

Here is what I mean:

GameObject player = GameObject.FindGameObjectWithTag("Player");
if (player != null)
{
	Health health = player.GetComponent<Health>();
	if (health != null)
	{
		//DO something
	}
	else
	{
		Debug.Log("Helth Script not found");
	}
}
else
{
	Debug.Log("Player not found");
}

Regarding 2nd point - it is kind of expensive to search objects by name or by tag… it is always good practice to have references.

Create some Class like “GameController” and create in it variable public GameObject player where you would link reference in the editor.

However, from provided screenshots, I don’t see what you are doing wrong

3

It turns out my geniusness decided to set another object with the Player tag and it was probably referencing that.