Separating Input.GetKey and Input.GetKeyDown

Questions & Answers
1

I’m using the observer pattern to create a layer of abstraction between player input and game logic. I have an InputManager class that other classes can subscribe to to listen for keypresses they’re interested in. I’ve come across an issue where I need to differentiate between Input.GetKey and Input.GetKeyDown calls. E.g. Some spells can be cast as soon as they come off cooldown by holding down the key, but others can’t. This would be a trivial fix if I hardcoded the condition into the spell script, but I’d rather keep all inputs in the InputManager class. How can I achieve this?

2

I’d make a bool like “RefreshKeyPress” that you toggle. And a bool for each spell that checks if it requires you to “Refresh” your key press before it activates again.

Without testing anything, this is my guess at it:

so like

if (Input.GetKey(KeyCode.Q))
{
    if (spell1.requireRefresh)
    {
        if (RefreshKeyPress) 
            spell1.CastSpell();
    }
    else
        spell1.CastSpell();
   
    RefreshKeyPress = false;
}
else if (Input.GetKey(KeyCode.W))
{
    if (spell2.requireRefresh)
    {
        if (RefreshKeyPress) 
            spell2.CastSpell();
    }
    else
        spell2.CastSpell();

     RefreshKeyPress = false;
}
else
{
     RefreshKeyPress = true;
}

Oh, and obviously you’d need to check the recharge time of the spell inside your CastSpell function in this instance. Otherwise you could always access it with spell1.CheckRecharge() or something and return true or false

if (spell1.CheckRecharge())
{

}



//In your spell's script

public bool CheckRecharge ()
{
    if (time >= rechargeTime)
        return true;
    else
        return false;
}