Spawning objects efficiently C#

[greg1992]

Hello so i’ve been on and off working on a spawning script for my game, it’s changed alot to suit the needs of the game and how it’s going to play. I’ve made up a code but for what it does i feel that there are many more efficient possibilities. Basically is there a better way of doing what i’m doing? -less code-.

At the moment(as shown below) i’m spawning 3 different objects at the start of each game, it then goes to the respective spawn method creates a list of points for the object to spawn at, picks a random point, spawns the object and then removes that point.(which is a bit of code i left on from my last script thought, basically it stops a object from spawning at the same place if i spawn 2 objects at 2 different points).

using UnityEngine;
using System.Collections;
using System.Collections.Generic;


public class SpawnTest : MonoBehaviour {
	
	
	public GameObject Copper;
	public Transform[] copperSpawns;
	public GameObject wood;
	public Transform[] woodSpawns;
	public GameObject Sand;
	public Transform[] sandSpawn;
	public int maxCopper = 0;
	public int maxWood = 0;
	public int maxSand = 0;
	
	
	void Start(){
		
		
		
	}
	
	
	void  Update (){
		
		
		if(GameObject.Find("Copper(Clone)") == false)
		{
			spawnMetal();
		}
		
		
		
		
		
		if(GameObject.Find("Wood(Clone)") == false)
		{
			spawnWood ();

		}

		if(GameObject.Find ("Sand(Clone)" == false)
		{
			spawnSand();

		}
		
	}
	
	
	
	
	void spawnMetal (){
		
		List<Transform> spawn = new List<Transform>(copperSpawns); 
		
		for( int copperCount = 0; copperCount < maxCopper; copperCount++){
			
			
			//select a random spawn point
			int randomPick = Random.Range(0,spawn.Count);
			
			
			Transform pos = spawn[randomPick];
			
			spawn.RemoveAt(randomPick);
			
			//create the object at point of the location variable
			Instantiate(Copper, pos.position, transform.rotation);
			
			
			
		}
	}
	
	
	void spawnWood (){
		
		List<Transform> spawn = new List<Transform>(woodSpawns); 
		
		for( int woodCount = 0; woodCount < maxWood; woodCount++){
			
			
			//select a random spawn point
			int randomPick = Random.Range(0,spawn.Count);
			
			
			Transform pos = spawn[randomPick];
			
			spawn.RemoveAt(randomPick);
			
			//create the object at point of the location variable
			Instantiate(wood, pos.position, transform.rotation);
			
			
			
		}
		
		
	}

		void spawnSood (){
			
			List<Transform> spawn = new List<Transform>(woodSpawns); 
			
			for( int sandCount = 0; sandCount < maxSand; sandCount++){
				
				
				//select a random spawn point
				int randomPick = Random.Range(0,spawn.Count);
				
				
				Transform pos = spawn[randomPick];
				
				spawn.RemoveAt(randomPick);
				
				//create the object at point of the location variable
				Instantiate(Sand, pos.position, transform.rotation);
	

			}
			
			
	 }		
			
}

[fafase]

First off, less code does not mean better code. It just means less code. So your point should not be to lessen the amount but just to make it work. Also, less code is sometime less readable.

Now for the code, you use the GameObject.Find, 3 times in the update, I would rather place the instantiated objects in a list and check for the Count of the list.

if(listMetal.Count == 0) spawnMetal();

Other thing could be to have a pool of object instead of creating/destroying. You place them on a stack and you pull to get a new object and push when an object gets destroyed. You also deactivate and other actions. This way you do not get to play too much with the memory management.