I know the advantages of StartCoroutine. I use it when I need to all the time. What I don’t understand is times where I am not trying to simplify asynchronous code but that Unity won’t execute a method correctly unless I call it using StartCoroutine.
So, aside from the cases where I want to leverage the power of StartCoroutine, as is outlined in the documentation, how can I know when it has to be used?
You never have to use them, but they can be helpful when scheduling a series of actions.
For instance:
Might be implemented as follows:
private IEnumerator FireWeapon() {
SpawnBullet();
lockUserInput = true;
yield return new WaitForSeconds(0.1f);
PlaySoundEffect();
SpawnMuzzleFlash();
yield return new WaitForSeconds(0.5f);
lockUserInput = false;
}
private void Update() {
if (Input.GetButtonDown("Fire") && !lockUserInput)
StartCoroutine(FireWeapon());
}
I have a different problem then perhaps. But sometimes when I make a method, usually a private method, I can’t call that method from within the script elsewhere. Just sometimes, mind you. And when I throw a StartCoroutine around it the problem goes away. And in fact I’m having that problem right now. Here’s the code I’m using right now:
It starts out with a click on a button (new UGUI). That click executes the code here. It’s a bit big so suffice it to say the only important line for the purposes of this question is “intializeCurrentMatches();”.
public void TogglePlay()
{
if (!_showingMatches)
{
CurrentMatchesObject.SetActive(true);
_showingMatches = true;
HOTween.Rewind(string.Format("ShowMatches{0}", TeamIndex));
HOTween.Rewind(string.Format("ShowFindNewMatch{0}", TeamIndex));
HOTween.Play(string.Format("ShowMatches{0}", TeamIndex));
HOTween.Play(string.Format("ShowFindNewMatch{0}", TeamIndex));
// refresh the active battles
intializeCurrentMatches();
((ManageTeamScript)ManageTeamObject.GetComponent<ManageTeamScript>()).FeatureTeam(TeamIndex);
}
else
{
CurrentMatchesObject.SetActive(false);
_showingMatches = false;
HOTween.Rewind(string.Format("HideMatches{0}", TeamIndex));
HOTween.Rewind(string.Format("HideFindNewMatch{0}", TeamIndex));
HOTween.Play(string.Format("HideMatches{0}", TeamIndex));
HOTween.Play(string.Format("HideFindNewMatch{0}", TeamIndex));
((ManageTeamScript)ManageTeamObject.GetComponent<ManageTeamScript>()).CancelFeature();
}
}
That code calls a private method with a single line shown here:
private void intializeCurrentMatches()
{
((CurrentMatchesScript)CurrentMatchesObject.GetComponent<CurrentMatchesScript>()).InitializeActiveBattles(Party.PartyId);
}
Here’s the method that is never called successfully. If I step into with my debugger the execution hits the method signature line, but then returns without stepping into the method.
public IEnumerator GetActiveBattlesByPartyId(int partyId, CurrentMatchesScript matchesScript)
{
WWW www = new WWW(string.Format("http://localhost:12527/api/battle?teamId={0}", partyId), null, DirectorHelper.GetHeaders());
yield return www;
byte[] data = Convert.FromBase64String(www.text.Replace("\"", string.Empty));
if (OnGetBattlesByPartyIdSucceeded != null)
{
OnGetBattlesByPartyIdSucceeded(this, DirectorHelper.DeserializeFromNetwork<List<Battleschool.Common.Entities.Contract.Battle>>(data));
}
}
However, if I change that second snippet to the following, then the method in the third snippet executes just fine.
private void intializeCurrentMatches()
{
StartCoroutine(((CurrentMatchesScript)CurrentMatchesObject.GetComponent<CurrentMatchesScript>()).InitializeActiveBattles(Party.PartyId));
}
Can you post InitializeActiveBattles()? Do you have any yields in that function? How does GetActiveBattlesByPartyId() get called?
Sorry, yeah didn’t mean to leave one out.
public IEnumerator InitializeActiveBattles(int partyId)
{
BattleDirector director = gameObject.AddComponent("BattleDirector") as BattleDirector;
director.OnGetBattlesByPartyIdSucceeded += (caller, battles) =>
{
Battles = battles;
int index = 0;
foreach (var current in Battles)
{
var currentMatch = CurrentMatches[index];
var currentMatchScriptComponent = currentMatch.GetComponent(typeof(MatchScript));
((MatchScript)CurrentMatches[index].GetComponent(typeof(MatchScript))).Battle = current;
CurrentMatches[index].SetActive(true);
}
};
yield return StartCoroutine(director.GetActiveBattlesByPartyId(partyId, this));
}
You can’t call Coroutines like normal functions and expect them to work. Coroutines, especially as implemented in Unity, require some magic behind the scenes to work like they do. This is expected behaviour. So the answer to your question is always call StartCoroutine when you want to… start a coroutine.
However, as a matter of style, I don’t like using Coroutines to just “churn time” so to speak. Something that just sits there and yield return null’s until the cow’s come home is a waste of perf and a messy implementation. You should be using events and callbacks for those kind of patterns.
Check this article out for an in depth explanation of the coroutine implementation.
I don’t need InitializeActiveBattles to be treated any differently than a normal function, but I do want GetActiveBattlesByPartyId to be. However, there’s no way to call GetActiveBattlesByPartyId without a yield return statement, which cascades the requirement for an IEnumerator return type back to InitializeActiveBattles. OK, fine but still I didn’t see the need to run that method with StartCoroutine. Anyway I think I just misunderstood what Unity considers to BE a coroutine. Is it any method with an IEnumerator return type? Well maybe it doesn’t matter as long as I know that even methods that can execute in a linear fashion need to be executed with StartCoroutine so long as I want the asynchronous functionality out of a separate method call within the first method call.
Why do you need to call GetActiveBattlesByPartyId with a yield statement? It seems like you’re just throwing away that IEnumerator value. You can have a function with a IEnumerator return type without it being considered a coroutine. However, calling yield within that function WILL make it one.
You have to use StartCoroutine when doing calls with WWW otherwise the game will hang on the network call. I didn’t realize calling yield in a method made it a coroutine. I thought it was just a coroutine if you called it with StartCoroutine and that a requirement of the coroutine method itself was returning IEnumerator.
The yield is what’s requiring the StartCoroutine().
Pretty much when you yield a coroutine you are saying come back to this function later. You can’t use normal functions like that because you usually don’t want the computer to just sit and freeze until the yield is ready.
Oh of course. Duh, why I never thought of it in that way I don’t know. I always thought “yield” is a C# construct and StartCoroutine is not so yield should work independently of StartCoroutine. And of course it does, but not by just a straight call, you’d have to use it in an iterator or something. OK, don’t know why I never looked at it that way.
Thanks
yield is a C# construct and StartCoroutine is unique to Unity. It’s basically a way to use IEnumerator to monitor the execution progress of a set of instructions. @superpig had a fantastic overview of Coroutines on AltDev which is sadly lost now. Hopefully he’ll see this and have a backup somewhere.