Stop click to move when dropping

Unity Engine
1

Hi guys im working in a click to move game Rpg type, right now all work fine i just wanna know one thing.

I have and inventory system that if we place an item out of inventory it delete the item and work 100% but when i click out of inventory to drop it the payer move to the position since it works the click to move. wt i wanan know is how i can stop character to move if im deleting the item??

Scripts:

using UnityEngine;
using System.Collections;

public class ClickToMove : MonoBehaviour
{
    NavMeshAgent navAgent;

    public Inventory inventory;

    // Use this for initialization
    void Start ()
    {
        navAgent = GetComponent<NavMeshAgent> ();
    }

Appreciate. Cheers
   
    // Update is called once per frame
    void Update ()
    {
        if (GameObject.Find ("MouseOverUI").GetComponent<MouseOverUI> ().IsmouseOverGUI)
        {

        }
        else
        {
            RaycastHit hit;
            Ray ray = Camera.main.ScreenPointToRay (Input.mousePosition);

            if (Input.GetMouseButtonUp (0)) {
                if (Physics.Raycast (ray, out hit, 1000)) {
                    navAgent.SetDestination (hit.point);
                }
            }
        }
    }

    private void OnTriggerEnter(Collider other)
    {
        if (other.tag == "Item")
        {
            inventory.AddItem(other.GetComponent<Item>());
            Destroy (other.gameObject);
        }
    }
}

using UnityEngine;
using System.Collections;
using System.Collections.Generic;
using UnityEngine.UI;
using UnityEngine.EventSystems;
using System;

public class Inventory : MonoBehaviour
{
    private RectTransform inventoryRect;

    private float inventoryWidth, inventoryHeight;

    public int slots;

    public int rows;

    public float slotPaddingLeft;

    public float slotPaddingTop;

    public float slotSize;

    public GameObject slotPrefab;

    private static Slot from, to;

    private List<GameObject> allSlots;

    public GameObject iconPrefab;

    private static GameObject hoverObject;

    public Canvas canvas;

    private float hoverYOffset;

    public EventSystem eventSystem;


    private static CanvasGroup canvasGroup;

    public static CanvasGroup CanvasGroup
    {   
        get{ return canvasGroup; }
    }


    private bool fadingIn;

    private bool fadingOut;

    public float fadeTime;


    //need to have has much prototypes has the number of diferente items, right now only mana and health potions
    public GameObject mana;

    public GameObject health;

    public GameObject weapon;


    private static int emptySlots;

    public static int EmptySlots
    {
        get{ return emptySlots; }
        set{ emptySlots = value; }
    }


    public GameObject tooltipObject;

    private static GameObject tooltip;


    public Text sizeTextObject;

    private static Text sizeText;


    public Text visualTextObject;

    private static Text visualText;



    void Start ()
    {
        tooltip = tooltipObject;

        sizeText = sizeTextObject;

        visualText = visualTextObject;

        canvasGroup = transform.parent.GetComponent<CanvasGroup>();

        CreateLayout();
    }
   
    void Update ()
    {
        if (Input.GetMouseButtonUp (0))
        {
            //Removes the selected item from the inventory
            if(!eventSystem.IsPointerOverGameObject(-1) && from != null)
            {
                from.GetComponent<Image>().color = Color.white;

                from.ClearSlot();

                Destroy (GameObject.Find ("Hover"));

                to = null;

                from = null;

                emptySlots++;
            }
        }

        if (hoverObject != null)
        {
            Vector2 position;

            RectTransformUtility.ScreenPointToLocalPointInRectangle(canvas.transform as RectTransform, Input.mousePosition, canvas.worldCamera, out position);

            position.Set(position.x, position.y - hoverYOffset);

            hoverObject.transform.position = canvas.transform.TransformPoint(position);
        }

        if (Input.GetKeyDown (KeyCode.I))
        {
            if(canvasGroup.alpha > 0)
            {
                StartCoroutine("FadeOut");

                PutItemBack();
            }
            else
            {
                StartCoroutine("FadeIn");
            }
        }

        if (Input.GetMouseButton (2))
        {
            if(eventSystem.IsPointerOverGameObject(-1))
            {
                MoveInventory();
            }
        }
    }

    public void ShowToolTip(GameObject slot)
    {
        Slot tmpslot = slot.GetComponent<Slot>();

        if (!tmpslot.IsEmpty && hoverObject == null)
        {
            visualText.text = tmpslot.CurrentItem.GetToolTip();

            sizeText.text = visualText.text;


            tooltip.SetActive(true);


            float xPos = slot.transform.position.x + slotPaddingLeft;

            float yPos = slot.transform.position.y - slot.GetComponent<RectTransform>().sizeDelta.y - slotPaddingTop;

            tooltip.transform.position = new Vector2(xPos, yPos);
        }

    }

    public void HideToolTip()
    {
        tooltip.SetActive(false);
    }

    public void SaveInventory()
    {
        string content = string.Empty;

        for (int i = 0; i < allSlots.Count; i++)
        {
            Slot tmp = allSlots[i].GetComponent<Slot>();

            if(!tmp.IsEmpty)
            {
                content += i + "-" + tmp.CurrentItem.type.ToString() + "-" + tmp.Items.Count.ToString() + ";";
            }
        }

        PlayerPrefs.SetString ("content", content);

        PlayerPrefs.SetInt ("slots", slots);

        PlayerPrefs.SetInt ("rows", rows);

        PlayerPrefs.SetFloat ("slotPaddingLeft", slotPaddingLeft);

        PlayerPrefs.SetFloat ("slotPaddingTop", slotPaddingTop);

        PlayerPrefs.SetFloat ("slotSize", slotSize);

        PlayerPrefs.SetFloat ("xPos", inventoryRect.position.x);

        PlayerPrefs.SetFloat ("yPos", inventoryRect.position.y);

        PlayerPrefs.Save();
    }

    public void LoadInventory()
    {
        string content = PlayerPrefs.GetString ("content");

        slots = PlayerPrefs.GetInt ("slots");

        rows = PlayerPrefs.GetInt ("rows");

        slotPaddingLeft = PlayerPrefs.GetFloat ("slotPaddingLeft");

        slotPaddingTop = PlayerPrefs.GetFloat ("slotPaddingTop");

        slotSize = PlayerPrefs.GetFloat ("slotSize");

        inventoryRect.position = new Vector3 (PlayerPrefs.GetFloat ("xPos"), PlayerPrefs.GetFloat ("yPos"), inventoryRect.position.z);

        CreateLayout();

        string[] splitContent = content.Split (';');    //0-MANA-3

        for (int x = 0; x < splitContent.Length-1; x++)
        {
            string[] splitValues = splitContent[x].Split('-');

            int index = Int32.Parse(splitValues[0]);    //"0"

            ItemType type = (ItemType)Enum.Parse(typeof(ItemType), splitValues[1]);    //"MANA"

            int amount = Int32.Parse(splitValues[2]);    //"3"

            //replace the item in inventory has many times has we have before
            for(int i = 0; i < amount; i++)
            {
                switch (type)
                {
                    case ItemType.MANA:
                        allSlots[index].GetComponent<Slot>().AddItem(mana.GetComponent<Item>());
                        break;
                    case ItemType.HEALTH:
                        allSlots[index].GetComponent<Slot>().AddItem(health.GetComponent<Item>());
                        break;
                    case ItemType.WEAPON:
                        allSlots[index].GetComponent<Slot>().AddItem(weapon.GetComponent<Item>());
                        break;
                }
            }
        }
    }

    private void CreateLayout()
    {
        if(allSlots != null)
        {
            foreach(GameObject go in allSlots)
            {
                Destroy(go);
            }
        }

        allSlots = new List<GameObject>();

        hoverYOffset = slotSize * 0.01f;

        emptySlots = slots;

        inventoryWidth = (slots/rows) * (slotSize + slotPaddingLeft) + slotPaddingLeft;
        inventoryHeight = rows * (slotSize + slotPaddingTop) + slotPaddingTop;

        inventoryRect = GetComponent<RectTransform>();

        inventoryRect.SetSizeWithCurrentAnchors (RectTransform.Axis.Horizontal, inventoryWidth);
        inventoryRect.SetSizeWithCurrentAnchors (RectTransform.Axis.Vertical, inventoryHeight);
   
        int columns = slots / rows;

        for (int y = 0; y < rows; y++)
        {
            for(int x = 0; x < columns; x++)
            {
                GameObject newSlot = (GameObject)Instantiate(slotPrefab);

                RectTransform slotRect = newSlot.GetComponent<RectTransform>();

                newSlot.name = "Slot";

                //set slot as parent of inventory, who is parent from canvas that draw sprites
                newSlot.transform.SetParent(this.transform.parent);

                slotRect.localPosition = inventoryRect.localPosition + new Vector3(slotPaddingLeft * (x + 1) + (slotSize * x), -slotPaddingTop * (y + 1) - (slotSize * y));

                slotRect.SetSizeWithCurrentAnchors(RectTransform.Axis.Horizontal, slotSize * canvas.scaleFactor);   

                slotRect.SetSizeWithCurrentAnchors(RectTransform.Axis.Vertical, slotSize * canvas.scaleFactor);       

                newSlot.transform.SetParent(this.transform);

                allSlots.Add (newSlot);
            }
        }
    }

    public bool AddItem(Item item)
    {
        if (item.maxSize == 1)
        {
            PlaceEmpty(item);
            return true;
        }
        else
        {
            foreach (GameObject slot in allSlots)
            {
                Slot tmp = slot.GetComponent<Slot>();

                if(!tmp.IsEmpty)
                {
                    if(tmp.CurrentItem.type == item.type && tmp.IsAvailable)
                    {
                        tmp.AddItem(item);
                        return true;
                    }
                }
            }
            if(emptySlots > 0)
            {
                PlaceEmpty(item);
            }
        }

        return false;
    }

    private void MoveInventory()
    {
        Vector2 mousePos;

        RectTransformUtility.ScreenPointToLocalPointInRectangle (canvas.transform as RectTransform, new Vector3 (Input.mousePosition.x - (inventoryRect.sizeDelta.x / 2 * canvas.scaleFactor), Input.mousePosition.y + (inventoryRect.sizeDelta.y / 2 * canvas.scaleFactor)), canvas.worldCamera, out mousePos);

        transform.position = canvas.transform.TransformPoint (mousePos);
    }

    private bool PlaceEmpty(Item item)
    {
        if (emptySlots > 0)
        {
            foreach (GameObject slot in allSlots)
            {
                Slot tmp = slot.GetComponent<Slot>();

                if(tmp.IsEmpty)
                {
                    tmp.AddItem(item);
                    emptySlots --;
                    return true;
                }
            }
        }

        return false;
    }

    public void MoveItem(GameObject clicked)
    {
        if (from == null && canvasGroup.alpha == 1) 
        {
            if (!clicked.GetComponent<Slot>().IsEmpty)
            {
                from = clicked.GetComponent<Slot>();

                from.GetComponent<Image>().color = Color.gray;


                hoverObject = (GameObject)Instantiate(iconPrefab);

                hoverObject.GetComponent<Image>().sprite = clicked.GetComponent<Image>().sprite;

                hoverObject.name = "Hover";


                RectTransform hoverTransform = hoverObject.GetComponent<RectTransform>();

                RectTransform clickedTransform = clicked.GetComponent<RectTransform>();


                hoverTransform.SetSizeWithCurrentAnchors(RectTransform.Axis.Horizontal, clickedTransform.sizeDelta.x);

                hoverTransform.SetSizeWithCurrentAnchors(RectTransform.Axis.Vertical, clickedTransform.sizeDelta.y);


                hoverObject.transform.SetParent(GameObject.Find ("Canvas").transform, true);

                hoverObject.transform.localScale = from.gameObject.transform.localScale;
            }
        }
        else if (to == null)
        {
            to = clicked.GetComponent<Slot>();

            Destroy(GameObject.Find ("Hover"));
        }
        if (to != null && from != null)
        {
            Stack<Item> tmpTo = new Stack<Item>(to.Items);

            to.AddItems(from.Items);

            if(tmpTo.Count == 0)
            {
                from.ClearSlot();
            }
            else
            {
                from.AddItems(tmpTo);
            }

            from.GetComponent<Image>().color = Color.white;

            //reset "to" and "from"
            to = null;

            from = null;

            Destroy(GameObject.Find ("Hover"));
        }
    }

    private void PutItemBack()
    {
        if (from != null)
        {
            Destroy(GameObject.Find("Hover"));

            from.GetComponent<Image>().color = Color.white;

            from = null;
        }
    }

    private IEnumerator FadeOut()
    {
        if (!fadingOut)
        {
            fadingOut = true;

            fadingIn = false;

            StopCoroutine("FadeIn");


            float startAlpha = canvasGroup.alpha;

            float rate = 1.0f / fadeTime;

            float progress = 0.0f;


            while(progress < 1.0)
            {
                canvasGroup.alpha = Mathf.Lerp(startAlpha, 0, progress);

                progress += rate * Time.deltaTime;

                yield return null;
            }

            canvasGroup.alpha = 0;

            fadingOut = false;
        }
    }

    private IEnumerator FadeIn()
    {
        if (!fadingIn)
        {
            fadingOut = false;
           
            fadingIn = true;
           
            StopCoroutine("FadeOut");
           
           
            float startAlpha = canvasGroup.alpha;
           
            float rate = 1.0f / fadeTime;
           
            float progress = 0.0f;
           
           
            while(progress < 1.0)
            {
                canvasGroup.alpha = Mathf.Lerp(startAlpha, 1, progress);
               
                progress += rate * Time.deltaTime;
               
                yield return null;
            }
           
            canvasGroup.alpha = 1;
           
            fadingIn = false;
        }
    }
}
2

Might I recommend a clear button so you click the button instead of the ground.

sorry for the non coding answer.

3

I already thing on that… Appreciate :wink:

4

sorry for being no help then. Have a nice day.

5

Np. its an option… anyway i will see if someone has other ideas. have a nice day too

6

Hi again guys. So back to this thread i still get this big problem to solve after some attempts, using diferente bools and so on. So right now wts going on is this:

1 - the functionality of my system is click to move player, open inventory with “I” key and bank with “E” key

2 - if i click with left mouse button in on inventory icon and click in other slot it change position

3 - if i click left mouse to take item to the mouse and click out of inventory it destroys it

4 - if i click left mouse to take item and click in bank inventory it puts it in bank

Now the problem is this, if i click on item inside inventory and i move mouse out of inventory even without click the player start to move, for example when im moving from inventory to bank i i pass with mouse out of a inventory/bank window player start move alone, and when i try to delete item when i click in floor to delete player move to that same position.

I try alot of way, so wt i need is when i hv a item “Hover” the icon the place it in other place or delete it i have to stop my player to move.

This are my inventory / clicktomove scripts and this is a pick of my game. If someone can help me i will appreciate alot :slight_smile:

PS: Sorry for the big code -.-

using UnityEngine;
using System.Collections;

[RequireComponent(typeof(NavMeshAgent))]       
public class ClickToMove : MonoBehaviour
{
    private Vector3 targetPosition;               

    const int LEFT_MOUSE_BUTTON = 0;           

    NavMeshAgent navAgent;

    public Inventory inventory;

    private Inventory bank;



    // Use this for initialization
    void Awake ()
    {
        navAgent = GetComponent<NavMeshAgent>();
    }



    void Start()
    {
        targetPosition = transform.position;
    }



    // Update is called once per frame
    void Update ()
    {
        if (Input.GetMouseButton (LEFT_MOUSE_BUTTON))
            SetTargetPosition();

        MovePlayer();

        if (Input.GetKeyDown (KeyCode.I))
        {
            inventory.Open();
        }
        if(Input.GetKeyDown (KeyCode.E))
        {
            if(bank != null)
            {
                bank.Open();
            }
        }
    }



    void SetTargetPosition()
    {
        Plane plane = new Plane(Vector3.up, transform.position);
        Ray ray = Camera.main.ScreenPointToRay (Input.mousePosition);
        float point = 0;

        if (plane.Raycast (ray, out point))
            targetPosition = ray.GetPoint (point);
    }



    private void MovePlayer()
    {
        if (GameObject.Find ("MouseOverUI").GetComponent<MouseOverUI>().IsmouseOverGUI)
        {

        }
        else
        {
            navAgent.SetDestination(targetPosition);
        }
    }



    private void OnTriggerEnter(Collider other)
    {
        if (other.tag == "Item")
        {
            //pick 0 or 1 or 2
            int randomType = UnityEngine.Random.Range(0, 3);
       
            GameObject tmp = Instantiate(InventoryManager.Instance.itemObject);

            int randomItem;

            switch (randomType)
            {
                case 0:
                    tmp.AddComponent<ItemScript>();
                    ItemScript newConsumable = tmp.GetComponent<ItemScript>();
                    randomItem = UnityEngine.Random.Range(0, InventoryManager.Instance.ItemCountainer.Consumables.Count);
                    newConsumable.Item = InventoryManager.Instance.ItemCountainer.Consumables[randomItem];
                    inventory.AddItem(newConsumable);
                    Destroy(tmp);
                    break;
                case 1:
                    tmp.AddComponent<ItemScript>();
                    ItemScript newWeapon = tmp.GetComponent<ItemScript>();
                    randomItem = UnityEngine.Random.Range(0, InventoryManager.Instance.ItemCountainer.Weapons.Count);
                    newWeapon.Item = InventoryManager.Instance.ItemCountainer.Weapons[randomItem];
                    inventory.AddItem(newWeapon);
                    Destroy(tmp);
                    break;
                case 2:
                    tmp.AddComponent<ItemScript>();
                    ItemScript newEquipment = tmp.GetComponent<ItemScript>();
                    randomItem = UnityEngine.Random.Range(0, InventoryManager.Instance.ItemCountainer.Equipment.Count);
                    newEquipment.Item = InventoryManager.Instance.ItemCountainer.Equipment[randomItem];
                    inventory.AddItem(newEquipment);
                    Destroy(tmp);
                    break;
            }
        }

        if (other.tag == "Bank")
        {
            bank = other.GetComponent<BankScript>().bankInventory;
        }
    }



    private void OnTriggerExit(Collider other)
    {
        if (other.gameObject.tag == "Bank")
        {
            if(bank.IsOpen)
            {
                bank.Open();
            }
            bank = null;
        }
    }
}

using UnityEngine;
using System.Collections;
using System.Collections.Generic;
using UnityEngine.UI;
using UnityEngine.EventSystems;
using System;

public class Inventory : MonoBehaviour
{
    private RectTransform inventoryRect;

    private float inventoryWidth, inventoryHeight;

    public int slots;

    public int rows;

    public float slotPaddingLeft;

    public float slotPaddingTop;

    public float slotSize;

    private List<GameObject> allSlots;

    private float hoverYOffset;

    private CanvasGroup canvasGroup;

    private bool fadingIn;

    private bool fadingOut;

    public float fadeTime;

    public static bool mouseInside = false;

    private bool isOpen;

    public bool IsOpen
    {
        get{ return isOpen; }
        set{ isOpen = value; }
    }


    private int emptySlots;

    public int EmptySlots
    {
        get{ return emptySlots; }
        set{ emptySlots = value; }
    }



    void Start ()
    {
        isOpen = false;

        canvasGroup = GetComponent<CanvasGroup>();

        CreateLayout();
    }



    void Update ()
    {
        if (Input.GetMouseButtonUp (0))
        {
            //Removes the selected item from the inventory
            if(!mouseInside && InventoryManager.Instance.From != null)
            {
                InventoryManager.Instance.From.GetComponent<Image>().color = Color.white;

                InventoryManager.Instance.From.ClearSlot();

                Destroy (GameObject.Find ("Hover"));

                InventoryManager.Instance.To = null;

                InventoryManager.Instance.From = null;

                emptySlots++;
            }
        }

        if (InventoryManager.Instance.HoverObject != null)
        {
            Vector2 position;

            RectTransformUtility.ScreenPointToLocalPointInRectangle(InventoryManager.Instance.canvas.transform as RectTransform, Input.mousePosition, InventoryManager.Instance.canvas.worldCamera, out position);

            position.Set(position.x, position.y - hoverYOffset);

            InventoryManager.Instance.HoverObject.transform.position = InventoryManager.Instance.canvas.transform.TransformPoint(position);
        }

        if (canvasGroup.alpha == 0)
        {
            canvasGroup.interactable = false;
            canvasGroup.blocksRaycasts = false;
        }
        else
        {
            canvasGroup.interactable = true;
            canvasGroup.blocksRaycasts = true;
        }
    }



    public void OnDrag()
    {
        MoveInventory();
    }



    public void PointerExit()
    {
        mouseInside = false;
    }



    public void PointerEnter()
    {
        if (canvasGroup.alpha > 0)
        {
            mouseInside = true;
        }
    }



    public void Open()
    {
        if(canvasGroup.alpha > 0)
        {
            StartCoroutine("FadeOut");
               
            PutItemBack();

            HideToolTip();

            isOpen = false;
        }
        else
        {
            StartCoroutine("FadeIn");

            isOpen = true;
        }
    }



    public void ShowToolTip(GameObject slot)
    {
        Slot tmpslot = slot.GetComponent<Slot>();

        if (slot.GetComponentInParent<Inventory>().isOpen && !tmpslot.IsEmpty && InventoryManager.Instance.HoverObject == null)
        {
            InventoryManager.Instance.visualTextObject.text = tmpslot.CurrentItem.GetToolTip();

            InventoryManager.Instance.sizeTextObject.text = InventoryManager.Instance.visualTextObject.text;


            InventoryManager.Instance.tooltipObject.SetActive(true);


            float xPos = slot.transform.position.x + slotPaddingLeft;

            float yPos = slot.transform.position.y - slot.GetComponent<RectTransform>().sizeDelta.y - slotPaddingTop;

            InventoryManager.Instance.tooltipObject.transform.position = new Vector2(xPos, yPos);
        }

    }



    public void HideToolTip()
    {
        InventoryManager.Instance.tooltipObject.SetActive(false);
    }



    public void SaveInventory()
    {
        string content = string.Empty;

        for (int i = 0; i < allSlots.Count; i++)
        {
            Slot tmp = allSlots[i].GetComponent<Slot>();

            if(!tmp.IsEmpty)
            {
                content += i + "-" + tmp.CurrentItem.Item.ItemName.ToString() + "-" + tmp.Items.Count.ToString() + ";";
            }
        }

        PlayerPrefs.SetString (gameObject.name + "content", content);

        PlayerPrefs.SetInt (gameObject.name + "slots", slots);

        PlayerPrefs.SetInt (gameObject.name + "rows", rows);

        PlayerPrefs.SetFloat (gameObject.name + "slotPaddingLeft", slotPaddingLeft);

        PlayerPrefs.SetFloat (gameObject.name + "slotPaddingTop", slotPaddingTop);

        PlayerPrefs.SetFloat (gameObject.name + "slotSize", slotSize);

        PlayerPrefs.SetFloat (gameObject.name + "xPos", inventoryRect.position.x);

        PlayerPrefs.SetFloat (gameObject.name + "yPos", inventoryRect.position.y);

        PlayerPrefs.Save();
    }



    public void LoadInventory()
    {
        string content = PlayerPrefs.GetString (gameObject.name + "content");

        slots = PlayerPrefs.GetInt (gameObject.name + "slots");

        rows = PlayerPrefs.GetInt (gameObject.name + "rows");

        slotPaddingLeft = PlayerPrefs.GetFloat (gameObject.name + "slotPaddingLeft");

        slotPaddingTop = PlayerPrefs.GetFloat (gameObject.name + "slotPaddingTop");

        slotSize = PlayerPrefs.GetFloat (gameObject.name + "slotSize");

        inventoryRect.position = new Vector3 (PlayerPrefs.GetFloat (gameObject.name + "xPos"), PlayerPrefs.GetFloat (gameObject.name + "yPos"), inventoryRect.position.z);

        CreateLayout();

        string[] splitContent = content.Split (';');    //0-MANA-3

        for (int x = 0; x < splitContent.Length-1; x++)
        {
            string[] splitValues = splitContent[x].Split('-');

            int index = Int32.Parse(splitValues[0]);

            string itemName = splitValues[1];

            int amount = Int32.Parse(splitValues[2]);

            Item tmp = null;

            //replace the item in inventory has many times has we have before
            for(int i = 0; i < amount; i++)
            {
                GameObject loadedItem = Instantiate(InventoryManager.Instance.itemObject);

                if(tmp == null)
                {
                    tmp = InventoryManager.Instance.ItemCountainer.Consumables.Find(item => item.ItemName == itemName);
                }
                if(tmp == null)
                {
                    tmp = InventoryManager.Instance.ItemCountainer.Equipment.Find(item => item.ItemName == itemName);

                }
                if(tmp == null)
                {
                    tmp = InventoryManager.Instance.ItemCountainer.Weapons.Find(item => item.ItemName == itemName);
                   
                }

                loadedItem.AddComponent<ItemScript>();

                loadedItem.GetComponent<ItemScript>().Item = tmp;

                allSlots[index].GetComponent<Slot>().AddItem(loadedItem.GetComponent<ItemScript>());

                Destroy(loadedItem);
            }
        }
    }



    private void CreateLayout()
    {
        if(allSlots != null)
        {
            foreach(GameObject go in allSlots)
            {
                Destroy(go);
            }
        }

        allSlots = new List<GameObject>();

        hoverYOffset = slotSize * 0.01f;

        emptySlots = slots;

        inventoryWidth = (slots/rows) * (slotSize + slotPaddingLeft) + slotPaddingLeft;
        inventoryHeight = rows * (slotSize + slotPaddingTop) + slotPaddingTop;

        inventoryRect = GetComponent<RectTransform>();

        inventoryRect.SetSizeWithCurrentAnchors (RectTransform.Axis.Horizontal, inventoryWidth);
        inventoryRect.SetSizeWithCurrentAnchors (RectTransform.Axis.Vertical, inventoryHeight);
   
        int columns = slots / rows;

        for (int y = 0; y < rows; y++)
        {
            for(int x = 0; x < columns; x++)
            {
                GameObject newSlot = (GameObject)Instantiate(InventoryManager.Instance.slotPrefab);

                RectTransform slotRect = newSlot.GetComponent<RectTransform>();

                newSlot.name = "Slot";

                //set slot as parent of inventory, who is parent from canvas that draw sprites
                newSlot.transform.SetParent(this.transform.parent);

                slotRect.localPosition = inventoryRect.localPosition + new Vector3(slotPaddingLeft * (x + 1) + (slotSize * x), -slotPaddingTop * (y + 1) - (slotSize * y));

                slotRect.SetSizeWithCurrentAnchors(RectTransform.Axis.Horizontal, slotSize * InventoryManager.Instance.canvas.scaleFactor);   

                slotRect.SetSizeWithCurrentAnchors(RectTransform.Axis.Vertical, slotSize * InventoryManager.Instance.canvas.scaleFactor);       

                newSlot.transform.SetParent(this.transform);

                allSlots.Add (newSlot);
            }
        }
    }



    public bool AddItem(ItemScript item)
    {
        if (item.Item.MaxSize == 1)
        {
            PlaceEmpty(item);
            return true;
        }
        else
        {
            foreach (GameObject slot in allSlots)
            {
                Slot tmp = slot.GetComponent<Slot>();

                if(!tmp.IsEmpty)
                {
                    if(tmp.CurrentItem.Item.ItemName == item.Item.ItemName && tmp.IsAvailable)
                    {
                        tmp.AddItem(item);
                        return true;
                    }
                }
            }
            if(emptySlots > 0)
            {
                PlaceEmpty(item);
            }
        }

        return false;
    }



    private void MoveInventory()
    {
        Vector2 mousePos;

        RectTransformUtility.ScreenPointToLocalPointInRectangle (InventoryManager.Instance.canvas.transform as RectTransform, new Vector3 (Input.mousePosition.x - (inventoryRect.sizeDelta.x / 2 * InventoryManager.Instance.canvas.scaleFactor), Input.mousePosition.y + (inventoryRect.sizeDelta.y / 2 * InventoryManager.Instance.canvas.scaleFactor)), InventoryManager.Instance.canvas.worldCamera, out mousePos);

        transform.position = InventoryManager.Instance.canvas.transform.TransformPoint (mousePos);
    }



    private bool PlaceEmpty(ItemScript item)
    {
        if (emptySlots > 0)
        {
            foreach (GameObject slot in allSlots)
            {
                Slot tmp = slot.GetComponent<Slot>();

                if(tmp.IsEmpty)
                {
                    tmp.AddItem(item);
                    emptySlots --;
                    return true;
                }
            }
        }

        return false;
    }



    public void MoveItem(GameObject clicked)
    {
        if (clicked.transform.parent.GetComponent<CanvasGroup>().alpha > 0)
        {
            if (InventoryManager.Instance.From == null && clicked.transform.parent.GetComponent<Inventory>().isOpen)
            {
                if (!clicked.GetComponent<Slot>().IsEmpty)
                {
                    InventoryManager.Instance.From = clicked.GetComponent<Slot>();
                   
                    InventoryManager.Instance.From.GetComponent<Image>().color = Color.gray;
                   
                   
                    InventoryManager.Instance.HoverObject = (GameObject)Instantiate(InventoryManager.Instance.iconPrefab);
                   
                    InventoryManager.Instance.HoverObject.GetComponent<Image>().sprite = clicked.GetComponent<Image>().sprite;
                   
                    InventoryManager.Instance.HoverObject.name = "Hover";
                   
                   
                    RectTransform hoverTransform = InventoryManager.Instance.HoverObject.GetComponent<RectTransform>();
                   
                    RectTransform clickedTransform = clicked.GetComponent<RectTransform>();
                   
                   
                    hoverTransform.SetSizeWithCurrentAnchors(RectTransform.Axis.Horizontal, clickedTransform.sizeDelta.x);
                   
                    hoverTransform.SetSizeWithCurrentAnchors(RectTransform.Axis.Vertical, clickedTransform.sizeDelta.y);
                   
                   
                    InventoryManager.Instance.HoverObject.transform.SetParent(GameObject.Find ("Canvas").transform, true);
                   
                    InventoryManager.Instance.HoverObject.transform.localScale = InventoryManager.Instance.From.gameObject.transform.localScale;
                }
            }
            else if (InventoryManager.Instance.To == null)
            {
                InventoryManager.Instance.To = clicked.GetComponent<Slot>();

                Destroy(GameObject.Find ("Hover"));
            }
            if (InventoryManager.Instance.To != null && InventoryManager.Instance.From != null)
            {
                Stack<ItemScript> tmpTo = new Stack<ItemScript>(InventoryManager.Instance.To.Items);
               
                InventoryManager.Instance.To.AddItems(InventoryManager.Instance.From.Items);
               
                if(tmpTo.Count == 0)
                {
                    InventoryManager.Instance.From.ClearSlot();
                }
                else
                {
                    InventoryManager.Instance.From.AddItems(tmpTo);
                }
               
                InventoryManager.Instance.From.GetComponent<Image>().color = Color.white;
               
                //reset "to" and "from"
                InventoryManager.Instance.To = null;
               
                InventoryManager.Instance.From = null;
               
                Destroy(GameObject.Find ("Hover"));
            }
        }
    }



    private void PutItemBack()
    {
        if (InventoryManager.Instance.From != null)
        {
            Destroy(GameObject.Find("Hover"));

            InventoryManager.Instance.From.GetComponent<Image>().color = Color.white;

            InventoryManager.Instance.From = null;
        }
    }



    private IEnumerator FadeOut()
    {
        if (!fadingOut)
        {
            fadingOut = true;

            fadingIn = false;

            StopCoroutine("FadeIn");


            float startAlpha = canvasGroup.alpha;

            float rate = 1.0f / fadeTime;

            float progress = 0.0f;


            while(progress < 1.0)
            {
                canvasGroup.alpha = Mathf.Lerp(startAlpha, 0, progress);

                progress += rate * Time.deltaTime;

                yield return null;
            }

            canvasGroup.alpha = 0;

            fadingOut = false;
        }
    }



    private IEnumerator FadeIn()
    {
        if (!fadingIn)
        {
            fadingOut = false;
           
            fadingIn = true;
           
            StopCoroutine("FadeOut");
           
           
            float startAlpha = canvasGroup.alpha;
           
            float rate = 1.0f / fadeTime;
           
            float progress = 0.0f;
           
           
            while(progress < 1.0)
            {
                canvasGroup.alpha = Mathf.Lerp(startAlpha, 1, progress);
               
                progress += rate * Time.deltaTime;
               
                yield return null;
            }
           
            canvasGroup.alpha = 1;
           
            fadingIn = false;
        }
    }
}
7

For one you have too many dependencies in your Click to Move script.

What I would do, is set a boolean property on the Inventory callen IsOpen and set that to true when the inventory is, well, open.

Then just check if it is open, and if it is, just disable movement altogether.

void Update ()
{
    if(!Inventory.IsOpen)
    {
        if (Input.GetMouseButton (LEFT_MOUSE_BUTTON))
            SetTargetPosition();

        MovePlayer();
    }
8

The question is i already have a isOpen bool in inventory and is set to true when inventory is open (alpha>0) and false when is close (alpha=0) but when i use it in clicktomove script i get an error saying

Static member Inventory.IsOpen cannot be accessed with an instance reference, qualify it with a type name instead…

I change the private bool i create in inventory to public static to access it in clicktomove but i get the error…

9

Don’t make it static. In your ClickToMove script you already have a reference to your inventory (that you set from the inspector I guess?)public Inventory inventory;
Use that for the check

10

Dumb!! It works… But when its open i cant move at all… Could be good or not… Cuz for game concerns we probably will need open inventory during combart (to take potions for example) and in that way its quite “impossible” . Not with the bank… cuz the bank are made to be in town but with inventory…

The ideal is just stop player movement when i hv a item on my mouse “Hover” other way we can have inventory open and move anyway…

But at least it works. Ty m8

11

Then just set a bool whenever you pick an item from your inventory :slight_smile: Same logic applies for constraining movement then :slight_smile:

12

Well the problem is that the pick item is inside the inventory script… so for that i hv to access the clicktomove script and then and in clicktomove set a bool ismoving and when i pick set is moving to false is that? A bit bad explained but i think is that :slight_smile:

13

Now that im trying this i figure the problem… Wts going on is that when i click in a icon inside the inventory the player dont move has i expected, but wts going on ithe that in the moment that i leave the inventory window it assumes the click i made over the icon 1stly and thats why it moves to that position when i leave the inventory image…

Its there a way to fix this diferente then a bool, cuz this seems to be a diferente problem…

ty

14

As the Inventory is a UI element, try any of these to see if they can help:

15

1st option works flawless xD Ty m8 really appreciate all the time u lose with me :wink:

16

Glad you found a fix already.

I’m not sure what you guys used as a fix, but…

I think you might want to check out GetMouseButtonDown vs. GetMouseButton still though for picking up objects. I’m not sure if that was covered already. That would allow you to pick the item up and keep it on the cursor without moving the character, in theory, if you set it up.

17

The fix was use eventsystem in my clicktomove script, like the 1st example of the video that Timelog posted in the thread :slight_smile: