Terrain Sample Asset Pack 2.0 - SG BiRP Lit doesn't support instancing

Unity Engine
,
1

Hi there, I just imported the new terrain sample pack and there are some issues in SG with BiRP + Lit + GPU Instancing:

  1. Created a new Builtin Render Pipeline 2021.2.6 project, installed SG 12.1 before importing the terrain package.
    7737753--972321--upload_2021-12-15_9-36-31.png

  2. Imported the sample pack and add a few prefabs to a scene, all good with the Unlit shader.

    7737753--972324--upload_2021-12-15_9-41-26.png
    7737753--972324--upload_2021-12-15_9-41-26.png1162×588 144 KB

  3. Changing the shader to Lit is breaking the shader:

    7737753--972327--upload_2021-12-15_9-42-30.png
    7737753--972327--upload_2021-12-15_9-42-30.png1155×594 161 KB

  4. Disabling Instancing fixes the shader:

    7737753--972330--upload_2021-12-15_9-45-47.png
    7737753--972330--upload_2021-12-15_9-45-47.png1225×475 103 KB

So while the new details system is designed to work with instancing, and instancing is broken with lit shaders created with SG in BIRP, I guess going with Unlit material type was the only choice.

Except for that little bug, nice sample pack! Waiting for trees :slight_smile: Cheers!

2

Is this supposed to work? Last I checked Shader Graph didn’t support BiRP.
https://docs.unity3d.com/Packages/com.unity.shadergraph@10.8/manual/Getting-Started.html

3

Yes, since 2021.2

7738569--972558--upload_2021-12-15_16-28-33.png
7738569--972558--upload_2021-12-15_16-28-33.png794×449 54.8 KB

1 Like
4

Wow, I somehow missed that. The documentation needs a bit of an update, apparently. :frowning: Sorry for the interruption then!

1 Like
5

Compared to other features which are marketed here and there, I don’t think I saw anything related to it. It is available since 2021.2 since the alpha release if I remember correctly. GPU Instancing was broken at that point, looks like it remained the same.