The animation doesn't play!

Unity Engine
, , , , , ,
1

Hi everyone, I’m making a Player Controller and if the Player press the left mouse button the attack animation should start but doesn’t works or if it works, it works just 0.1s.
I think the problem is that the animator.SetBool(“is attacking”, isAttacking) doesn’t update the value in the animator.
Thanks in advance.

The code is:

void Attack()
{
int attackNum = 0;
if(attackNum > 3)
   attackNum = 0;

if(Input.GetMouseButtonDown(0) && cooldownTimer > attackCooldown && isOnGround)
{
isAttacking= true;
anim.SetBool("isAttacking", isAttacking);
anim.SetInteger("AttackNum", attackNum);
}
else
{
isAttacking = false;
anim.SetBool("isAttacking", isAttacking);
}

attackNum++;
cooldownTimer = 0;
}
1 Like
2

Please provide a screenshot of the Animator Window and all properties of transitions, and so on.

Also, you didn’t provide the entire class, so I can only guess.
Input states must be monitored in Update() function, which is not shown in your code.

3

Hi! First off,check if the condition is met when pressing the mouse button.
If so, the problem is surely somewhere else, specifically inside the AnimatorController.

You should provide a picture of the transition between animations as well as the inspector of the animations states to receive the right support for your problem.

Waiting for any news!

4

Fix that FIRST.

Anything with Animations / Animators / Mechanic:

Always start with the Animator state machine and prove it works in isolation, no code at all:

5

tomorrow I will post the screenshot and the complete code, however this Attack() function is called in FixedUpdate()

6

Tomorrow I’ll try to see if it receives input from the mouse thanks

7

Thanks, tomorrow I will read the article

8

If it is called in FixedUpdate also check that it doesn’t get called every frame. If something like this happens, looking at the way “Attack()” is written, it might cause the issue

9

Ok, if this were to be the problem then it would be enough to move the if-statement into the FixedUpdate() and if it is true execute the Attack() method?

10

I cannot see any reason in your code to use FixedUpdate() that is targeted to Physics operating.

Use Update() instead: for Animation changes, Input checking.

1 Like
11

OK I’ve changed it, i also moved the if(Input.GetMouseButtonDown(0) in yhe Update() and now I can play the animation but I can’t stop it, I’m a disaster, I know ahahah

The complete code is:

Vector2 movement;
Animator anim;
Rigidbody2D rb;

private float coolDownTimer;
private int attackNum;
[SerializeField] int speed = 5;
[SerializeField] float attackCooldown;
[SerializeField] bool isMoving;
[SerializeField] bool isOnGround;
[SerializeField] bool isAttacking;
[SerializeField] Vector2 jumpForce;

// Start is called once before the first execution of Update after the MonoBehaviour is created
void Start()
{
    anim = GetComponent<Animator>();
    rb = GetComponent<Rigidbody2D>();
    anim.SetFloat("moveX", 1f);
}

// Update is called once per frame
void Update()
{
    Movement();
    Jump();
    if (Input.GetMouseButtonDown(0) && isOnGround)
    {
        Debug.Log("press");
        Attack();
    }
    else
        coolDownTimer += Time.deltaTime;
}

void Movement()
{
    movement.x = Input.GetAxisRaw("Horizontal");

    if (isOnGround)
    {
        transform.Translate(Vector2.right * movement * speed * Time.deltaTime);
        rb.velocity = movement * speed;

        if (movement != Vector2.zero)
        {
            isMoving = true;
            anim.SetFloat("moveX", movement.x);
            anim.SetBool("isMoving", isMoving);
        }
        else
        {
            isMoving = false;
            anim.SetBool("isMoving", isMoving);

        }
    }
}

void Jump()
{
    if (Input.GetKeyDown(KeyCode.Space) && isOnGround)
    {
        isOnGround = false;
        
        rb.AddForce(jumpForce, ForceMode2D.Impulse);

        anim.SetBool("isMoving", isMoving);
        anim.SetBool("isJumping", true);
    }
    else
        anim.SetBool("isJumping", false);
}

void Attack()
{
    if (attackNum > 2)
        attackNum = 0;

    if (coolDownTimer > attackCooldown)
    {
        isAttacking = true;
        anim.SetBool("isAttacking", isAttacking);
        anim.SetInteger("AttackNum", attackNum);
        coolDownTimer = 0;
        attackNum++;
        Debug.Log("Attack");
    }
    else
    {
        isAttacking = false;
        anim.SetBool("isAttacking", isAttacking);
    }
}

void OnCollisionEnter2D(Collision2D collsion)
{
    isOnGround = collsion.gameObject.CompareTag("Ground");
}

The animator is:

image
image752×354 28.7 KB

1 Like
12

Again, go back to the animator. How did you design it stop normally (eg, via what parameters or exit conditions), WITHOUT any code?

When you have that working absolutely dead-nuts solid, then study your code.

How is your code NOT giving the animator what you gave it by hand to prove it works?

Sounds like you wrote a bug… and that means… time to start debugging!

By debugging you can find out exactly what your program is doing so you can fix it.

Use the above techniques to get the information you need in order to reason about what the problem is.

You can also use Debug.Log(...); statements to find out if any of your code is even running. Don’t assume it is.

Once you understand what the problem is, you may begin to reason about a solution to the problem.

13

Yeah, int he end I resolved it just some minute after I posted the reply and I fixed it by adding a parameter in the animator, thanks

2 Likes