Two guns shooting at once, need help fixing.

Unity Engine
,
1

When I have two guns one in my players hand and on the ground, it seems that both are shooting and I don’t know what to do to fix this.

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class Shooting : MonoBehaviour
{

    public GameObject theBullet;
    public Transform barrelEnd;

    public int bulletSpeed;
    public float despawnTime = 3.0f;

    public bool shootAble = true;
    public float waitBeforeNextShot = 0.25f;

    private void Update()
    {
        if (Input.GetKeyDown(KeyCode.Mouse0))
        {
            if (shootAble)
            {
                shootAble = false;
                Shoot();
                StartCoroutine(ShootingYield());
            }
        }
    }

    IEnumerator ShootingYield()
    {
        yield return new WaitForSeconds(waitBeforeNextShot);
        shootAble = true;
    }
    void Shoot()
    {
        var bullet = Instantiate(theBullet, barrelEnd.position, barrelEnd.rotation);
        bullet.GetComponent<Rigidbody>().velocity = bullet.transform.forward * bulletSpeed;

        Destroy(bullet, despawnTime);
    }
}

If also needing the pick up script say and i’ll show it.

2

Is this script attached to the gun? If so, either move your input check to a script on the player (my actual recommendation), or set shootAble to false by default. Only set shootAble to true if it is in the player’s hand.

1 Like
3

Yes it is attached, how would I set shootAble to true if its in the players hand and when you say move, so delete it from this script and add it to a player script?

Edit: So i did move it to the player script, now i have 4 errors and there all cs0103, 2 for shootAble, 1 for Shoot, and 1 for ShootingYield.

4

I’d assume there is some code you run when you attach the gun to the player’s hand. You’d set shootAble to true in that code. In whatever code you run when you remove the gun from the player’s hand, you set shootAble to false and also kill all of the gun’s coroutines.

No one memorizes error codes. Unity gives a descriptive error with line numbers.

1 Like
5

Okay so I did that to which fixed a lot of it to now I’m stuck with one more error to which says, “Type ‘PickupScript’ already defines a member called ‘Update’ with the same parameter types”
How would I fix this?

6

So the error basically says you have two Update methods in PickupScript. Make PickupScript have just a single Update method.

7

Okay, now its saying how, ‘shooting’ and ‘ShootingYield’ does not exist in the current context. What would I need to do to fix this? Sorry for asking a lot and errors but thanks.

8

You might want to take some C# tutorials, as these are really basic C# issues which aren’t really related to Unity. If you call a method, you either call it as part of the same class, or you need a reference to the instance of the class you are calling the method on (with some exception). So if you want to call “shooting” from this other class now, you need a reference to the object which actually has the shooting method, and you call it on that reference. When I suggested moving your input check over to the player, I wasn’t suggesting to just cut/paste your existing code. You’d have to redesign your system so you check for input on the player, and then call the proper method on the gun object.

When you pick up the gun you’d probably want to store a reference to the gun. Then when the player tries to shoot, you call a method on the gun that starts it off. That method would handle the shooting of the gun and the starting of any coroutines on the gun, since the player object shouldn’t really need to know how the gun works (as it is generally bad design otherwise).

9

Oh okay, thanks, think I may have it now, but for C# tutorials what would you suggest?

10

I don’t have a specific suggestion, since I learned C# when learning from actual printed books was still the norm, but I know Unity has their own C# essentials tutorials, and since it is an industry standard language there are an endless number of tutorials and even classes which teach C# unrelated to Unity.

1 Like
11

Okay, thanks for all this man, hope you have a great rest of the day.

1 Like